From: Yijing Wang <wangyijing@huawei.com>
To: Jiang Liu <jiang.liu@linux.intel.com>,
Yinghai Lu <yinghai@kernel.org>, Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
"Dan Williams" <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Ashok Raj <ashok.raj@intel.com>
Cc: <iommu@lists.linux-foundation.org>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <dmaengine@vger.kernel.org>
Subject: Re: [Patch Part1 V2 07/17] iommu/vt-d, trivial: check suitable flag in function detect_intel_iommu()
Date: Mon, 2 Dec 2013 09:44:15 +0800 [thread overview]
Message-ID: <529BE5EF.7040706@huawei.com> (raw)
In-Reply-To: <1385715030-20553-8-git-send-email-jiang.liu@linux.intel.com>
On 2013/11/29 16:50, Jiang Liu wrote:
> Flag irq_remapping_enabled is only set by intel_enable_irq_remapping(),
> which is called after detect_intel_iommu(). So we should check flag
> disable_irq_remap instead of irq_remapping_enabled in function
> detect_intel_iommu().
>
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
> drivers/iommu/dmar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
> index f3043a2..77a066b 100644
> --- a/drivers/iommu/dmar.c
> +++ b/drivers/iommu/dmar.c
> @@ -561,7 +561,7 @@ int __init detect_intel_iommu(void)
>
> dmar = (struct acpi_table_dmar *) dmar_tbl;
>
> - if (ret && irq_remapping_enabled && cpu_has_x2apic &&
> + if (ret && !disable_irq_remap && cpu_has_x2apic &&
> dmar->flags & 0x1)
> pr_info("Queued invalidation will be enabled to support x2apic and Intr-remapping.\n");
>
>
Reviewed-by: Yijing Wang <wangyijing@huawei.com>
--
Thanks!
Yijing
next prev parent reply other threads:[~2013-12-02 1:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1385715030-20553-1-git-send-email-jiang.liu@linux.intel.com>
[not found] ` <1385715030-20553-2-git-send-email-jiang.liu@linux.intel.com>
2013-12-02 1:38 ` [Patch Part1 V2 01/17] iommu/vt-d: use dedicated bitmap to track remapping entry allocation status Yijing Wang
[not found] ` <1385715030-20553-3-git-send-email-jiang.liu@linux.intel.com>
2013-12-02 1:40 ` [Patch Part1 V2 02/17] iommu/vt-d: fix PCI device reference leakage on error recovery path Yijing Wang
[not found] ` <1385715030-20553-5-git-send-email-jiang.liu@linux.intel.com>
2013-12-02 1:41 ` [Patch Part1 V2 04/17] iommu/vt-d: fix resource leakage on error recovery path in iommu_init_domains() Yijing Wang
[not found] ` <1385715030-20553-9-git-send-email-jiang.liu@linux.intel.com>
2013-12-02 1:42 ` [Patch Part1 V2 07/17] iommu/vt-d. trivial: check suitable flag in function detect_intel_iommu() Yijing Wang
[not found] ` <1385715030-20553-8-git-send-email-jiang.liu@linux.intel.com>
2013-12-02 1:44 ` Yijing Wang [this message]
[not found] ` <1385715030-20553-14-git-send-email-jiang.liu@linux.intel.com>
2013-12-02 1:47 ` [Patch Part1 V2 12/17] iommu/vt-d: fix invalid memory access when freeing DMAR irq Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529BE5EF.7040706@huawei.com \
--to=wangyijing@huawei.com \
--cc=ashok.raj@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).