From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eu1sys200aog118.obsmtp.com ([207.126.144.145]:48298 "EHLO eu1sys200aog118.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864Ab3LKLJi (ORCPT ); Wed, 11 Dec 2013 06:09:38 -0500 Message-ID: <52A847D1.5000409@st.com> Date: Wed, 11 Dec 2013 16:39:05 +0530 From: Rajeev kumar MIME-Version: 1.0 To: Mohit KUMAR Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Pratyush ANAND , Viresh Kumar , spear-devel , "devicetree@vger.kernel.org" Subject: Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr References: <1078549fa412fb34ab2c95a6232096570abee12d.1386752447.git.mohit.kumar@st.com> In-Reply-To: <1078549fa412fb34ab2c95a6232096570abee12d.1386752447.git.mohit.kumar@st.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 12/11/2013 3:08 PM, Mohit KUMAR wrote: > DT field name for the phy address changed since kernel 3.10. Set the > snps,phy-addr to 0xffffffff so that the driver probes for the phy. > > Signed-off-by: Mohit Kumar > Cc: Pratyush Anand > Cc: Viresh Kumar > Cc: spear-devel@list.st.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: devicetree@vger.kernel.org > --- > arch/arm/boot/dts/spear13xx.dtsi | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/spear13xx.dtsi b/arch/arm/boot/dts/spear13xx.dtsi > index 4382547..3518803 100644 > --- a/arch/arm/boot/dts/spear13xx.dtsi > +++ b/arch/arm/boot/dts/spear13xx.dtsi > @@ -155,6 +155,7 @@ > > gmac0: eth@e2000000 { > compatible = "st,spear600-gmac"; > + snps,phy-addr =<0xffffffff>; Don't you think it should be st,phy-addr =<0xffffffff>, as the manufacturer is 'st' as the compatible suggest ~Rajeev > reg =<0xe2000000 0x8000>; > interrupts =<0 33 0x4 > 0 34 0x4>;