From: Joseph Salisbury <joseph.salisbury@canonical.com>
To: Yinghai Lu <yinghai@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio
Date: Wed, 11 Dec 2013 14:19:33 -0500 [thread overview]
Message-ID: <52A8BAC5.70006@canonical.com> (raw)
In-Reply-To: <CAE9FiQXf6w0u+JLu-JHd45ofSTShaB0MoMNbck9EE-y3u6B98w@mail.gmail.com>
On 12/09/2013 03:10 PM, Yinghai Lu wrote:
> On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> That doesn't answer my question at all.
>>
>> I understand that this change makes it so Joseph doesn't have to use
>> "pci=realloc=off". But why should auto-reallocation be limited to
>> buses that have resources above 4GB? That doesn't make any sense.
>>
>> We should fix the reallocation code so it can deal with this case. If
>> there's not enough space for everything, obviously we have to leave
>> something unassigned. A ROM BAR is a good candidate for leaving
>> unassigned, because most of the time we can get along without it.
> Yes, that is ideal and not that simple.
> but that would be hard to backport to old kernels.
>
> BTW, Joseph, can you try
> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git
> for-pci-3.14
> with pci=realloc=on
>
> on that system?
>
> Thanks
>
> Yinghai
I noticed there was some back and forth on this thread. Do you still
want me to test this version, Yinghai?
next prev parent reply other threads:[~2013-12-11 19:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 23:54 [PATCH 0/2] PCI: Don't enable realloc automatically when above 4g 64bit mmio is not supported Yinghai Lu
2013-12-08 23:54 ` [PATCH 1/2] PCI: pcibus address to resource converting take bus instead of dev Yinghai Lu
2013-12-09 17:52 ` Bjorn Helgaas
2013-12-09 19:21 ` Yinghai Lu
2013-12-09 20:03 ` Yinghai Lu
2013-12-09 20:43 ` Greg KH
2013-12-09 20:47 ` Yinghai Lu
2013-12-09 21:06 ` Bjorn Helgaas
2013-12-08 23:54 ` [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio Yinghai Lu
2013-12-09 17:54 ` Bjorn Helgaas
2013-12-09 19:20 ` Yinghai Lu
2013-12-09 19:42 ` Bjorn Helgaas
2013-12-09 20:10 ` Yinghai Lu
2013-12-09 20:20 ` Bjorn Helgaas
2013-12-09 20:44 ` Yinghai Lu
2013-12-09 21:05 ` Bjorn Helgaas
2013-12-11 19:19 ` Joseph Salisbury [this message]
2013-12-11 19:55 ` Yinghai Lu
2014-01-08 16:38 ` Joseph Salisbury
2014-01-10 16:19 ` Joseph Salisbury
2014-01-10 17:13 ` Yinghai Lu
2014-01-10 21:54 ` Joseph Salisbury
2014-01-10 23:12 ` Yinghai Lu
2014-09-16 20:21 ` Joseph Salisbury
2014-09-16 22:27 ` Yinghai Lu
2014-09-17 7:46 ` Yinghai Lu
2014-09-24 23:48 ` Bjorn Helgaas
2014-09-25 18:19 ` Joseph Salisbury
2014-09-25 18:24 ` Yinghai Lu
2014-09-25 15:49 ` Joseph Salisbury
2014-09-25 16:04 ` Bjorn Helgaas
2014-09-25 18:04 ` Joseph Salisbury
2014-09-25 18:23 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A8BAC5.70006@canonical.com \
--to=joseph.salisbury@canonical.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).