From: Lian Minghuan-b31939 <b31939@freescale.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Scott Wood <scottwood@freescale.com>
Cc: Minghuan Lian <Minghuan.Lian@freescale.com>,
<linuxppc-dev@lists.ozlabs.org>,
Zang Roy-R61911 <r61911@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>,
<linux-pci@vger.kernel.org>
Subject: Re: [PATCH 02/12][v4] pci: fsl: add structure fsl_pci
Date: Thu, 9 Jan 2014 13:45:21 +0800 [thread overview]
Message-ID: <52CE3771.1040009@freescale.com> (raw)
In-Reply-To: <20140109001252.GA20070@google.com>
Hi Bjorn,
I am very sorry, The mail was filtered to another directory, I did not
notice update. The next versions will include these updates.
Thanks,
Minghuan
On 01/09/2014 08:12 AM, Bjorn Helgaas wrote:
> On Wed, Jan 08, 2014 at 03:58:08PM -0600, Scott Wood wrote:
>> On Wed, 2014-01-08 at 13:01 +0800, Minghuan Lian wrote:
>>> PowerPC uses structure pci_controller to describe PCI controller,
>>> but ARM uses structure pci_sys_data. In order to support PowerPC
>>> and ARM simultaneously, the patch adds a structure fsl_pci that
>>> contains most of the members of the pci_controller and pci_sys_data.
>>> Meanwhile, it defines a interface fsl_arch_sys_to_pci() which should
>>> be implemented in architecture-specific PCI controller driver to
>>> convert pci_controller or pci_sys_data to fsl_pci.
>>>
>>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
>>> ---
>>> change log:
>>> v4:
>>> Added indirect type macro
>>> v1-v3:
>>> Derived from http://patchwork.ozlabs.org/patch/278965/
>>>
>>> Based on upstream master.
>>> Based on the discussion of RFC version here
>>> http://patchwork.ozlabs.org/patch/274487/
>>>
>>> include/linux/fsl/pci-common.h | 48 ++++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 48 insertions(+)
>> Same comments on this patchset as last time.
> Minghuan, when you address Scott's comments, can you also add a
> MAINTAINERS update?
>
> Bjorn
>
>
next prev parent reply other threads:[~2014-01-09 5:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 5:01 [PATCH 01/12][v4] pci: fsl: derive the common PCI driver to drivers/pci/host Minghuan Lian
2014-01-08 5:01 ` [PATCH 02/12][v4] pci: fsl: add structure fsl_pci Minghuan Lian
2014-01-08 21:58 ` Scott Wood
2014-01-09 0:12 ` Bjorn Helgaas
2014-01-09 5:45 ` Lian Minghuan-b31939 [this message]
2014-01-09 2:22 ` Lian Minghuan-b31939
2014-01-08 5:01 ` [PATCH 03/12][v4] pci: fsl: add PCI indirect access support Minghuan Lian
2014-01-08 5:01 ` [PATCH 04/12][v4] pci: fsl: add early " Minghuan Lian
2014-01-08 5:01 ` [PATCH 05/12][v4] pci: fsl: port PCI ATMU related code Minghuan Lian
2014-01-08 5:01 ` [PATCH 06/12][v4] pci: fsl: port PCI controller setup code Minghuan Lian
2014-01-08 5:01 ` [PATCH 07/12][v4] pci: fsl: port PCI platform driver Minghuan Lian
2014-01-08 5:01 ` [PATCH 08/12][v4] pci: fsl: add PowerPC PCI driver Minghuan Lian
2014-01-08 5:02 ` [PATCH 09/12][v4] pci: fsl: update PCI PM driver Minghuan Lian
2014-01-08 5:02 ` [PATCH 10/12][v4] pci: fsl: support function fsl_pci_assign_primary Minghuan Lian
2014-01-08 5:02 ` [PATCH 11/12][v4] pci: fsl: update PCI EDAC driver Minghuan Lian
2014-01-08 5:02 ` [PATCH 12/12][v4] pci: fsl: fix function check_pci_ctl_endpt_part Minghuan Lian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CE3771.1040009@freescale.com \
--to=b31939@freescale.com \
--cc=Minghuan.Lian@freescale.com \
--cc=bhelgaas@google.com \
--cc=galak@kernel.crashing.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r61911@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox