linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz@mellanox.com>
To: Wei Yang <weiyang@linux.vnet.ibm.com>,
	<linux-pci@vger.kernel.org>, <yinghai@kernel.org>,
	<bhelgaas@google.com>, <amirv@mellanox.com>,
	<jackm@dev.mellanox.co.il>, <eugenia@mellanox.com>,
	Guo Chao <yan@linux.vnet.ibm.com>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@au1.ibm.com>
Subject: Re: mlx4_core probe error after applying Yinghai's patch
Date: Tue, 14 Jan 2014 09:55:09 +0200	[thread overview]
Message-ID: <52D4ED5D.80105@mellanox.com> (raw)
In-Reply-To: <20140114062215.GA19345@richard>

On 14/01/2014 08:22, Wei Yang wrote:
> All,
>
> I am testing Yinghai's patch based on 3.13-rc1, after applying these four
> patches, there is an error during probe for mlx4_core.
>
> Code base we did the test:
>    $ git oneline -5
>    298a335 PCI: Try best to allocate pref mmio 64bit above 4g
>    b730e81 PCI: Try to allocate mem64 above 4G at first
>    4e27325 PCI: Don't use 4G bus address directly in resource allocation
>    ab6c20f PCI: pcibus address to resource converting take bus instead of dev
>    6ce4eac Linux 3.13-rc1
>    
> Error log:
>    mlx4_core 0003:05:00.0: Multiple PFs not yet supported.  Skipping PF.
>    mlx4_core: probe of 0003:05:00.0 failed with error -22
>
> My analysis:
>    After careful investigation, I guess this error is not introduced by
>    Yinghai's patch. This looks more like an error from device itself. Since
>    this error really happens after applying Yinghai's patch(especially the last
>    one 298a335), I would like to include Yinghai in this loop.

Sorry, can you provide pointers please? I don't see 298a335 on Linus 
3.13-rc8+ tree nor in net-next,

$ git log --oneline --author=Yinghai v3.12..
e7cc5cf PCI: Remove duplicate pci_disable_device() from 
pcie_portdrv_remove()
cf3e1fe PCI: Workaround missing pci_set_master in pci drivers
bee7f9c ACPI / x86: Increase override tables number limit
6979287 x86/mm: Add 'step_size' comments to init_mem_mapping()

So  are you referring to patches on the PCI development tree
git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git "next" 
branch? which

Or.

  reply	other threads:[~2014-01-14  7:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14  6:22 mlx4_core probe error after applying Yinghai's patch Wei Yang
2014-01-14  7:55 ` Or Gerlitz [this message]
2014-01-14  8:27   ` Wei Yang
2014-01-14  8:39     ` Or Gerlitz
2014-01-14  8:52       ` Wei Yang
2014-01-14  8:50 ` Jack Morgenstein
2014-01-14  9:15   ` Wei Yang
2014-01-14 10:25     ` Jack Morgenstein
2014-01-14 11:19       ` Guo Chao
     [not found]       ` <52d51b4c.c413ec0a.290f.03c3SMTPIN_ADDED_BROKEN@mx.google.com>
2014-01-14 11:21         ` Jack Morgenstein
     [not found]   ` <20140114103712.GD27684@richard>
     [not found]     ` <20140114132340.50df7d6f@jpm-OptiPlex-GX620>
     [not found]       ` <52d52032.4981e00a.3dcc.ffff81fdSMTPIN_ADDED_BROKEN@mx.google.com>
     [not found]         ` <20140115094113.64ca756e@jpm-OptiPlex-GX620>
     [not found]           ` <1389772791.6933.84.camel@pasglop>
     [not found]             ` <52d653d3.8425e00a.76d0.1e60SMTPIN_ADDED_BROKEN@mx.google.com>
     [not found]               ` <20140115160204.24a44af0@jpm-OptiPlex-GX620>
     [not found]                 ` <20140116020946.GA8702@richard>
     [not found]                   ` <20140116021429.GB8702@richard>
2014-01-29  8:50                     ` Or Gerlitz
2014-01-30  7:08                       ` Wei Yang
2014-01-30  8:09                         ` Or Gerlitz
2014-01-14  8:54 ` Jack Morgenstein
2014-01-14  9:16   ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D4ED5D.80105@mellanox.com \
    --to=ogerlitz@mellanox.com \
    --cc=amirv@mellanox.com \
    --cc=benh@au1.ibm.com \
    --cc=bhelgaas@google.com \
    --cc=eugenia@mellanox.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=linux-pci@vger.kernel.org \
    --cc=shangw@linux.vnet.ibm.com \
    --cc=weiyang@linux.vnet.ibm.com \
    --cc=yan@linux.vnet.ibm.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).