From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ducie-dc1.codethink.co.uk ([37.128.190.40]:36565 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbaBEJbs (ORCPT ); Wed, 5 Feb 2014 04:31:48 -0500 Message-ID: <52F20501.6030909@codethink.co.uk> Date: Wed, 05 Feb 2014 09:31:45 +0000 From: Ben Dooks MIME-Version: 1.0 To: Magnus Damm CC: linux-kernel@lists.codethink.co.uk, Valentine Barshak , Simon Horman , Bjorn Helgaas , linux-pci@vger.kernel.org, SH-Linux Subject: Re: [PATCH 2/3] PCI: rcar: add error interrupt handling References: <1390902468-7753-1-git-send-email-ben.dooks@codethink.co.uk> <1390902468-7753-3-git-send-email-ben.dooks@codethink.co.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 05/02/14 08:50, Magnus Damm wrote: > On Tue, Jan 28, 2014 at 6:47 PM, Ben Dooks wrote: >> Add option to enable interrupts to report any errors from >> the AHB-PCI bridge to help find any issues with the bridge >> when in use. >> >> Signed-off-by: Ben Dooks > > Thanks for your patches. Handling errors sounds good. About this > particular one, I'm not so keen on introducing Kconfig options for > each driver. Instead I'd prefer to handle this during runtime or as > Valentine suggested using CONFIG_PCI_DEBUG. Ok, I will change to using that. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius