From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] xen-pciback: Use pci_enable_msix_range() instead of pci_enable_msix()
Date: Wed, 19 Feb 2014 11:24:29 -0500 [thread overview]
Message-ID: <5304DABD.9000605@oracle.com> (raw)
In-Reply-To: <20140219160501.GA32067@dhcp-26-207.brq.redhat.com>
On 02/19/2014 11:05 AM, Alexander Gordeev wrote:
> On Wed, Feb 19, 2014 at 10:40:19AM -0500, Boris Ostrovsky wrote:
>>>> diff --git a/drivers/xen/xen-pciback/pciback_ops.c
>>>> b/drivers/xen/xen-pciback/pciback_ops.c
>>>> index 64eb0cd..f5b4c3e 100644
>>>> --- a/drivers/xen/xen-pciback/pciback_ops.c
>>>> +++ b/drivers/xen/xen-pciback/pciback_ops.c
>>>> @@ -213,9 +213,15 @@ int xen_pcibk_enable_msix(struct
>>>> xen_pcibk_device *pdev,
>>>> entries[i].vector = op->msix_entries[i].vector;
>>>> }
>>>> - result = pci_enable_msix(dev, entries, op->value);
>>>> + result = pci_enable_msix_range(dev, entries, op->value, op->value);
>>>> + if (result < op->value) {
>>>
>>> I think it would be better to have 'if (result != op->value)', in
>>> case op->value is negative (which presumably it should never be).
>>
>> Better yet, at the top of the routine we check 'if (op->value >
>> SH_INFO_MAX_VEC)'. If you add '|| op->value < 0' we'd be all set.
> xen_pci_op::value is uint32_t
Ah, OK --- then 'if (op->value > SH_INFO_MAX_VEC)' alone will catch this
(hopefully its' not in billions).
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
next prev parent reply other threads:[~2014-02-19 16:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 10:15 [PATCH] xen-pciback: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-19 15:22 ` Boris Ostrovsky
2014-02-19 15:40 ` Boris Ostrovsky
2014-02-19 16:05 ` Alexander Gordeev
2014-02-19 16:24 ` Boris Ostrovsky [this message]
2014-02-21 16:52 ` Alexander Gordeev
2014-02-21 16:53 ` [PATCH v2] xen-pciback: Use pci_enable_msix_exact() " Alexander Gordeev
2014-02-21 17:02 ` Alexander Gordeev
2014-02-21 18:33 ` Boris Ostrovsky
2014-02-21 18:58 ` Alexander Gordeev
2014-02-21 19:09 ` Boris Ostrovsky
2014-02-21 21:15 ` Konrad Rzeszutek Wilk
2014-02-24 19:18 ` Konrad Rzeszutek Wilk
2014-02-25 8:32 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5304DABD.9000605@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=agordeev@redhat.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).