From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org, Gleb Natapov <gleb@kernel.org>,
kvm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] kvm: Use pci_enable_msix_exact() instead of pci_enable_msix()
Date: Fri, 21 Feb 2014 18:11:29 +0100 [thread overview]
Message-ID: <530788C1.6030109@redhat.com> (raw)
In-Reply-To: <20140221170504.GN17353@dhcp-26-207.brq.redhat.com>
Il 21/02/2014 18:05, Alexander Gordeev ha scritto:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Gleb Natapov <gleb@kernel.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: kvm@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> ---
> virt/kvm/assigned-dev.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/virt/kvm/assigned-dev.c b/virt/kvm/assigned-dev.c
> index 8db4370..bf06577 100644
> --- a/virt/kvm/assigned-dev.c
> +++ b/virt/kvm/assigned-dev.c
> @@ -395,7 +395,8 @@ static int assigned_device_enable_host_msix(struct kvm *kvm,
> if (dev->entries_nr == 0)
> return r;
>
> - r = pci_enable_msix(dev->dev, dev->host_msix_entries, dev->entries_nr);
> + r = pci_enable_msix_exact(dev->dev,
> + dev->host_msix_entries, dev->entries_nr);
> if (r)
> return r;
>
>
It's okay, but it's not clear to me whether I should include this patch
or someone else will. :)
Paolo
next prev parent reply other threads:[~2014-02-21 17:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 10:15 [PATCH] kvm: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-19 13:24 ` Paolo Bonzini
2014-02-21 17:04 ` Alexander Gordeev
2014-02-21 17:05 ` [PATCH v2] kvm: Use pci_enable_msix_exact() " Alexander Gordeev
2014-02-21 17:11 ` Paolo Bonzini [this message]
2014-02-21 18:56 ` Alexander Gordeev
2014-02-21 21:36 ` Paolo Bonzini
2014-02-22 8:50 ` Alexander Gordeev
2014-02-22 8:58 ` Paolo Bonzini
2014-04-21 13:38 ` Alexander Gordeev
2014-04-24 20:45 ` Paolo Bonzini
2014-04-28 9:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530788C1.6030109@redhat.com \
--to=pbonzini@redhat.com \
--cc=agordeev@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).