From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Phil.Edworthy@renesas.com
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Simon Horman <horms@verge.net.au>,
linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Valentine Barshak <valentine.barshak@cogentembedded.com>
Subject: Re: [PATCH 1/9 v3] PCI: host: rcar: Add Renesas R-Car PCIe driver
Date: Thu, 20 Mar 2014 17:49:24 +0100 [thread overview]
Message-ID: <532B1C14.6050902@codethink.co.uk> (raw)
In-Reply-To: <OFA03366C1.FF33E94A-ON80257CA1.005B32AE-80257CA1.005BAE71@eu.necel.com>
On 20/03/14 17:41, Phil.Edworthy@renesas.com wrote:
> Hi,
>
> Whilst looking at something else, I've realised that I completely messed
> up my use of runtime PM in this driver... I'll fix that up & resend.
Yes, you don't need the suspend/resume hooks at-all by the looks
of it. Hopefully the pm_runtime driver for shmobile will be sorted
upstream soon.
And it looks as if your hooks would never have been called anyway
as your probe does a pm_runtime_get_sync() to keep the pm_runtime
for the device open (which probably for this bus bridge is what
you wanted)
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-03-20 16:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 9:49 [PATCH 0/9 v3] R-Car Gen2 PCIe host driver Phil Edworthy
2014-03-13 9:50 ` [PATCH 1/9 v3] PCI: host: rcar: Add Renesas R-Car PCIe driver Phil Edworthy
2014-03-20 16:41 ` Phil.Edworthy
2014-03-20 16:49 ` Ben Dooks [this message]
2014-03-13 9:50 ` [PATCH 2/9] PCI: host: rcar: Add MSI support Phil Edworthy
2014-03-13 9:50 ` [PATCH 3/9] ARM: shmobile: r8a7790: Add PCIe clock device tree nodes Phil Edworthy
2014-03-13 9:50 ` [PATCH 4/9] ARM: shmobile: r8a7791: " Phil Edworthy
2014-03-13 9:50 ` [PATCH 5/9] dt-bindings: pci: rcar pcie device tree bindings Phil Edworthy
2014-03-13 10:00 ` Arnd Bergmann
2014-03-13 10:28 ` Phil.Edworthy
2014-03-13 11:30 ` Arnd Bergmann
2014-03-13 9:50 ` [PATCH 6/9] ARM: shmobile: Add PCIe device tree nodes for R8A7790 Phil Edworthy
2014-03-13 9:50 ` [PATCH 7/9] ARM: shmobile: Add PCIe device tree nodes for R8A7791 Koelsch board Phil Edworthy
2014-03-13 9:50 ` [PATCH 8/9] ARM: koelsch: Add PCIe to defconfig Phil Edworthy
2014-03-13 9:50 ` [PATCH 9/9] ARM: koelsch: Add HAVE_ARM_ARCH_TIMER " Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B1C14.6050902@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=Phil.Edworthy@renesas.com \
--cc=bhelgaas@google.com \
--cc=horms@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=valentine.barshak@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).