From: Ryan <ryan@desfo.org>
To: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus'
Date: Sun, 30 Mar 2014 16:59:28 -0400 [thread overview]
Message-ID: <533885B0.5010001@desfo.org> (raw)
In-Reply-To: <1396034018-5645-1-git-send-email-ryan@desfo.org>
Hello,
This is my first patch. I'm looking for feedback pertaining to my
submission that way I can submit more patches correctly in the future.
Any constructive feedback is welcome.
I have one question in particular regarding the 'Sign by' section in the
git commit message. Am I suppose to add a 'Sign by' line for myself or
is that for the core kernel team?
Thank you for time and feedback,
Ryan
On 03/28/2014 03:13 PM, Ryan Desfosses wrote:
> change made to resolve following checkpatch message:
> drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index fdbc294..a50d542 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -106,7 +106,7 @@ static bool pcie_ari_disabled;
> * Given a PCI bus, returns the highest PCI bus number present in the set
> * including the given PCI bus and its list of child PCI buses.
> */
> -unsigned char pci_bus_max_busnr(struct pci_bus* bus)
> +unsigned char pci_bus_max_busnr(struct pci_bus *bus)
> {
> struct list_head *tmp;
> unsigned char max, n;
next prev parent reply other threads:[~2014-03-30 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 19:13 [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus' Ryan Desfosses
2014-03-30 20:59 ` Ryan [this message]
2014-03-31 9:49 ` Liviu Dudau
-- strict thread matches above, loose matches on Subject: below --
2014-03-31 16:47 Ryan Desfosses
2014-04-04 21:23 Ryan Desfosses
2014-04-04 21:44 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533885B0.5010001@desfo.org \
--to=ryan@desfo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).