From: Mathias Nyman <mathias.nyman@intel.com>
To: Alexander Gordeev <agordeev@redhat.com>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-pci@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH v2 RESEND 4/4] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix()
Date: Wed, 02 Apr 2014 17:05:13 +0300 [thread overview]
Message-ID: <533C1919.3010506@intel.com> (raw)
In-Reply-To: <20140402114127.GA10007@dhcp-26-207.brq.redhat.com>
On 04/02/2014 02:41 PM, Alexander Gordeev wrote:
> On Tue, Mar 25, 2014 at 03:27:30PM +0100, Alexander Gordeev wrote:
>> On Thu, Mar 06, 2014 at 01:56:46PM -0800, Sarah Sharp wrote:
>>> What do you mean by this sentence? Are you fixing some bug in those two
>>> functions, or just cleaning up how they look? Either way, this should
>>> really be two patches.
>> Hi Sarah,
>>
>> Any feedback on v2?
>
Hi
Thanks for the patches,
I'll queue patch 2/2 for usb-linus once 3.15-rc1 comes out.
But I'm going to omit patch 1/2 because it doesn't really improve
code readability and doesn't change functionality.
At this stage I'd like to avoid extra patches as much as possible.
And besides, it adds one extra line of code
-Mathias
next prev parent reply other threads:[~2014-04-02 13:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1394128952.git.agordeev@redhat.com>
2014-03-06 20:11 ` [PATCH v2 RESEND 1/4] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-03-06 21:09 ` Dan Williams
2014-03-06 21:43 ` Alexander Gordeev
2014-03-06 21:50 ` Dan Williams
2014-03-07 7:49 ` [PATCH v2] " Alexander Gordeev
2014-04-21 13:36 ` Alexander Gordeev
2014-08-25 16:35 ` Alexander Gordeev
2014-08-25 16:31 ` Dan Williams
2014-03-06 20:11 ` [PATCH v2 RESEND 2/4] portdrv: " Alexander Gordeev
2014-03-13 3:56 ` Bjorn Helgaas
2014-04-14 16:18 ` Alexander Gordeev
2014-03-06 20:11 ` [PATCH v2 RESEND 3/4] tsi721: " Alexander Gordeev
2014-03-07 13:35 ` Bounine, Alexandre
2014-04-21 13:28 ` Alexander Gordeev
2014-03-06 20:11 ` [PATCH v2 RESEND 4/4] xhci: " Alexander Gordeev
2014-03-06 21:56 ` Sarah Sharp
2014-03-07 7:46 ` [PATCH v2 1/2] xhci: Cleanup xhci_setup_msi() and xhci_setup_msix() Alexander Gordeev
2014-03-07 7:48 ` [PATCH v2 2/2] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-03-25 14:27 ` [PATCH v2 RESEND 4/4] " Alexander Gordeev
2014-04-02 11:41 ` Alexander Gordeev
2014-04-02 14:05 ` Mathias Nyman [this message]
2014-04-02 15:20 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C1919.3010506@intel.com \
--to=mathias.nyman@intel.com \
--cc=agordeev@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).