From: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
To: Alexander Gordeev <agordeev@redhat.com>, linux-kernel@vger.kernel.org
Cc: Lukasz Dorau <lukasz.dorau@intel.com>,
Maciej Patelczyk <maciej.patelczyk@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
intel-linux-scu@intel.com, linux-scsi@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 08/23] isci: Use pci_enable_msix_exact() instead of pci_enable_msix()
Date: Wed, 16 Apr 2014 14:51:19 +0200 [thread overview]
Message-ID: <534E7CC7.7050300@intel.com> (raw)
In-Reply-To: <8a203f9f8b7844e46676d526188965e877751edb.1397461652.git.agordeev@redhat.com>
On 04/14/2014 10:05 AM, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Lukasz Dorau <lukasz.dorau@intel.com>
> Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: intel-linux-scu@intel.com
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> ---
> drivers/scsi/isci/init.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
> index 695b34e..4198e45 100644
> --- a/drivers/scsi/isci/init.c
> +++ b/drivers/scsi/isci/init.c
> @@ -356,7 +356,7 @@ static int isci_setup_interrupts(struct pci_dev *pdev)
> for (i = 0; i < num_msix; i++)
> pci_info->msix_entries[i].entry = i;
>
> - err = pci_enable_msix(pdev, pci_info->msix_entries, num_msix);
> + err = pci_enable_msix_exact(pdev, pci_info->msix_entries, num_msix);
> if (err)
> goto intx;
>
>
Looks good.
Acked-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Thanks,
Artur
next prev parent reply other threads:[~2014-04-16 12:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 8:05 [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() " Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 02/23] bfa: Do not call pci_enable_msix() after it failed once Alexander Gordeev
2014-04-16 9:03 ` Anil Gurumurthy
2014-04-14 8:05 ` [PATCH v2 RESEND 03/23] bfa: Cleanup bfad_setup_intr() function Alexander Gordeev
2014-04-16 9:04 ` Anil Gurumurthy
2014-04-16 9:05 ` Anil Gurumurthy
2014-04-14 8:05 ` [PATCH v2 RESEND 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-04-16 9:05 ` Anil Gurumurthy
2014-04-14 8:05 ` [PATCH v2 RESEND 05/23] csiostor: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() " Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 08/23] isci: " Alexander Gordeev
2014-04-16 12:51 ` Artur Paszkiewicz [this message]
2014-04-14 8:05 ` [PATCH v2 RESEND 09/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 10/23] hpsa: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-13 19:27 ` scameron
2014-04-14 8:05 ` [PATCH v2 RESEND 11/23] lpfc: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 14/23] megaraid: " Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() " Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 16/23] mpt3sas: " Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 19/23] pmcraid: Get rid of a redundant assignment Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 20/23] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 21/23] qla2xxx: " Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() " Alexander Gordeev
2014-04-15 12:48 ` Vikas Chaudhary
2014-04-14 8:05 ` [PATCH v2 RESEND 23/23] vmw_pvscsi: " Alexander Gordeev
2014-04-24 17:09 ` [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() " Bjorn Helgaas
2014-04-24 17:51 ` James Bottomley
2014-04-24 18:07 ` Bjorn Helgaas
2014-07-07 18:03 ` Alexander Gordeev
2014-06-16 7:35 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534E7CC7.7050300@intel.com \
--to=artur.paszkiewicz@intel.com \
--cc=agordeev@redhat.com \
--cc=dave.jiang@intel.com \
--cc=intel-linux-scu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lukasz.dorau@intel.com \
--cc=maciej.patelczyk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).