* Coverity CID 712278: c_can_pci_probe() doesn't check pci_enable_msi() return value
@ 2014-04-03 16:53 Bjorn Helgaas
2014-04-17 20:11 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Helgaas @ 2014-04-03 16:53 UTC (permalink / raw)
To: Wolfgang Grandegger, Marc Kleine-Budde
Cc: Alexander Gordeev, linux-can, linux-pci@vger.kernel.org
Coverity complains that c_can_pci_probe() calls pci_enable_msi()
without checking the result:
CID 712278 (#1 of 1): Unchecked return value (CHECKED_RETURN)
3. check_return: Calling pci_enable_msi_block without checking return
value (as is done elsewhere 88 out of 105 times).
88 pci_enable_msi(pdev);
This is CID 712278.
Bjorn
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Coverity CID 712278: c_can_pci_probe() doesn't check pci_enable_msi() return value
2014-04-03 16:53 Coverity CID 712278: c_can_pci_probe() doesn't check pci_enable_msi() return value Bjorn Helgaas
@ 2014-04-17 20:11 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2014-04-17 20:11 UTC (permalink / raw)
To: Bjorn Helgaas, Wolfgang Grandegger
Cc: Alexander Gordeev, linux-can, linux-pci@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On 04/03/2014 06:53 PM, Bjorn Helgaas wrote:
> Coverity complains that c_can_pci_probe() calls pci_enable_msi()
> without checking the result:
>
>
> CID 712278 (#1 of 1): Unchecked return value (CHECKED_RETURN)
> 3. check_return: Calling pci_enable_msi_block without checking return
> value (as is done elsewhere 88 out of 105 times).
> 88 pci_enable_msi(pdev);
>
> This is CID 712278.
Thanks, I've applied Wolfgang's patch ("can: c_can_pci: enable PCI bus
master only for MSI"), which fixes this problem.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-17 20:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-03 16:53 Coverity CID 712278: c_can_pci_probe() doesn't check pci_enable_msi() return value Bjorn Helgaas
2014-04-17 20:11 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).