linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Murali Karicheri <m-karicheri2@ti.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Fwd: [PATCH v7 0/5] Add Keystone PCIe controller driver
Date: Mon, 21 Jul 2014 13:01:19 -0400	[thread overview]
Message-ID: <53CD475F.5010407@ti.com> (raw)
In-Reply-To: <1405961925-27248-1-git-send-email-m-karicheri2@ti.com>

-------- Original Message --------
Subject: [PATCH v7 0/5] Add Keystone PCIe controller driver
Date: Mon, 21 Jul 2014 12:58:40 -0400
From: Murali Karicheri <m-karicheri2@ti.com>
To: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>, 
<linux-arm-kernel@lists.infradead.org>
CC: Murali Karicheri <m-karicheri2@ti.com>, Russell King 
<linux@arm.linux.org.uk>, Grant Likely <grant.likely@linaro.org>, Rob 
Herring <robh+dt@kernel.org>, Mohit Kumar <mohit.kumar@st.com>, Jingoo 
Han <jg1.han@samsung.com>, Bjorn Helgaas <bhelgaas@google.com>, Pratyush 
Anand <pratyush.anand@st.com>, Richard Zhu <r65037@freescale.com>, 
"Kishon Vijay Abraham I" <kishon@ti.com>, Marek Vasut <marex@denx.de>, 
Arnd Bergmann <arnd@arndb.de>, Pawel Moll <pawel.moll@arm.com>, Mark 
Rutland <mark.rutland@arm.com>, Ian Campbell 
<ijc+devicetree@hellion.org.uk>, "Kumar Gala" <galak@codeaurora.org>, 
Randy Dunlap <rdunlap@infradead.org>

This patch series add PCIe controller driver for keystone SoCs. This is
based on v4 of the series posted to the mailing list. Keystone PCI 
controller
is based on version 3.65 of the DW hardware. This driver uses the DW core
functions to implement the PCI controller driver for keystone.

Testing:
=======

Testing of the driver is done on TI's K2HK EVM inserted to a Elma blu!eco
MicroTCA chassis AMC slot with JumpGen SEM-200 AMC SATA Storage and Dual
Ethernet Card Express inserted on another AMC slot. The e1000e driver 
available
on intel's website is patched to the kernel source tree and build. e1000e.ko
is dynamically loaded and executed ping and iperf tests to test the
functionality.

Thanks to all of you who have contributed by reviewing and offering valuable
comments. If you want me to add your "Reviewed-by", please let me know 
so that
I can add it to the commit log and re-send. Patch 1-3 has Acks from 
maintainers
and I believe this can be merged to upstream branch. Patch 4 is waiting for
Ack from DT maintainer. Please provide the same at the earliest.

Thanks

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>

CC: Russell King <linux@arm.linux.org.uk>
CC: Grant Likely <grant.likely@linaro.org>
CC: Rob Herring <robh+dt@kernel.org>
CC: Mohit Kumar <mohit.kumar@st.com>
CC: Jingoo Han <jg1.han@samsung.com>
CC: Bjorn Helgaas <bhelgaas@google.com>
CC: Pratyush Anand <pratyush.anand@st.com>
CC: Richard Zhu <r65037@freescale.com>
CC: Kishon Vijay Abraham I <kishon@ti.com>
CC: Marek Vasut <marex@denx.de>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Pawel Moll <pawel.moll@arm.com>
CC: Mark Rutland <mark.rutland@arm.com>
CC: Ian Campbell <ijc+devicetree@hellion.org.uk>
CC: Kumar Gala <galak@codeaurora.org>
CC: Randy Dunlap <rdunlap@infradead.org>
CC: Grant Likely <grant.likely@linaro.org>

Changelog:

v7
  - Removed ti,enable_linktrain DT property. The driver now check if
    the link is up and then retrain the link if not already up. This
    is as per comment from DT maintainer.
  - Rebased to upstream kernel v3.16-rc6

v6
  - Added Ack from Maintainer for patch 3. Patch 1-3 now have the
    Acks from maintainer and can be merged to upstream branch.
    Patch 4 is waiting ack from DT maintainer.
v5
  - Rebased to upstream kernel v3.16-rc5
  - Reworked Patch 3/6 and 4/6 into a single patch based on
    maintainer comment to use a API callback model to support
    the v3.65 h/w.
v4
  - Addressed comments against 5/5.
  - Added a patch 6/6 for Maintainer information
  - Added couple of Acked-By:
  - Rebased to latest Linux 3.16-rc4
v3
  - DW application register handling code is now part of
    Keystone PCI driver. RFC had this code part of Keystone
    PCI driver, then V1 moved this to a separate file to
    re-use on other platforms that uses this version of the
    DW h/w. Then based on comments against v2, this is moved
    back to Keystone driver.
  - Keystone SerDes phy driver is removed from this series so that
    this can be merged independent of that patch
  - added msi_set_irq()/clear_irq() API's to support Keystone

V2
  - Split the designware pcie enhancement patch to multiple
    patches based on functionality added
  - Remove the quirk code and add a patch to fix mps/mrss
    tuning for ARM. Use kernel command line parameter
    pci=pcie_bus_perf to work with Keystone PCI Controller.
    Following patch addressed this.
      [PATCH v1] ARM: pci: add call to pcie_bus_configure_settings()
  - Add documentation for device tree bindings
  - Add separate interrupt controller nodes for MSI and Legacy
    IRQs and use irq map for legacy IRQ
  - Use compatibility to identify v3.65 version of the DW hardware
    and use it to customize the designware common code.
  - Use reg property for configuration space instead of range
  - Other minor updates based on code inspection.

V1
  - Add an interrupt controller node for Legacy irq chip and use
    interrupt map/map-mask property to map legacy IRQs A/B/C/D
  - Add a Phy driver to replace the original serdes driver
  - Move common application register handling code to a separate
    file to allow re-use across other platforms that use older
    DW PCIe h/w
  - PCI quirk for maximum read request size. Check and override only
    if the maximum is higher than what controller can handle.
  - Converted to a module platform driver.

Murali Karicheri (5):
   PCI: designware: add rd[wr]_other_conf API
   PCI: designware: refactor MSI code to work with v3.65 dw hardware
   PCI: designware: enhance dw_pcie_host_init() to support v3.65 DW
     hardware
   PCI: add PCI controller for keystone PCIe h/w
   PCI: keystone: Update maintainer information

  .../devicetree/bindings/pci/pci-keystone.txt       |   68 +++
  MAINTAINERS                                        |    7 +
  drivers/pci/host/Kconfig                           |    5 +
  drivers/pci/host/Makefile                          |    1 +
  drivers/pci/host/pci-keystone-dw.c                 |  521 
++++++++++++++++++++
  drivers/pci/host/pci-keystone.c                    |  386 +++++++++++++++
  drivers/pci/host/pci-keystone.h                    |   58 +++
  drivers/pci/host/pcie-designware.c                 |  116 +++--
  drivers/pci/host/pcie-designware.h                 |    9 +
  9 files changed, 1135 insertions(+), 36 deletions(-)
  create mode 100644 Documentation/devicetree/bindings/pci/pci-keystone.txt
  create mode 100644 drivers/pci/host/pci-keystone-dw.c
  create mode 100644 drivers/pci/host/pci-keystone.c
  create mode 100644 drivers/pci/host/pci-keystone.h

-- 
1.7.9.5
Rob,

I have removed the DT property as suggested by you and resend the 
series. Please provide your Ack if this looks good.

Murali

  parent reply	other threads:[~2014-07-21 17:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 16:58 [PATCH v7 0/5] Add Keystone PCIe controller driver Murali Karicheri
2014-07-21 16:58 ` [PATCH v7 1/5] PCI: designware: add rd[wr]_other_conf API Murali Karicheri
2014-07-21 16:58 ` [PATCH v7 2/5] PCI: designware: refactor MSI code to work with v3.65 dw hardware Murali Karicheri
2014-07-21 16:58 ` [PATCH v7 3/5] PCI: designware: enhance dw_pcie_host_init() to support v3.65 DW hardware Murali Karicheri
2014-07-23  1:27   ` Jingoo Han
2014-07-21 16:58 ` [PATCH v7 4/5] PCI: add PCI controller for keystone PCIe h/w Murali Karicheri
2014-07-22 22:35   ` Bjorn Helgaas
2014-07-22 22:52     ` Murali Karicheri
2014-07-22 23:52       ` Bjorn Helgaas
2014-07-23 17:42         ` Jason Gunthorpe
2014-07-30 19:34           ` Murali Karicheri
2014-07-30 20:05             ` Jason Gunthorpe
2014-08-06 14:38               ` Murali Karicheri
2014-07-21 16:58 ` [PATCH v7 5/5] PCI: keystone: Update maintainer information Murali Karicheri
2014-07-21 17:01 ` Murali Karicheri [this message]
2014-07-22 22:57 ` [PATCH v7 0/5] Add Keystone PCIe controller driver Bjorn Helgaas
2014-07-23 15:27   ` Murali Karicheri
2014-07-23 16:43     ` Bjorn Helgaas
2014-07-23 16:56       ` Murali Karicheri
2014-08-18 14:58       ` Murali Karicheri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CD475F.5010407@ti.com \
    --to=m-karicheri2@ti.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).