From: Randy Dunlap <rdunlap@infradead.org>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>,
Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/AER: Forward declare struct pci_dev to avoid warning
Date: Mon, 21 Jul 2014 17:00:29 -0700 [thread overview]
Message-ID: <53CDA99D.4090602@infradead.org> (raw)
In-Reply-To: <20140721232732.GA4736@shangw>
On 07/21/2014 04:27 PM, Gavin Shan wrote:
> On Mon, Jul 21, 2014 at 07:30:43PM +0300, Tuomas Tynkkynen wrote:
>
> I guess it's same issue and fix as:
>
> http://patchwork.ozlabs.org/patch/370629/
Yes, and it still needs to be merged.... :(
> Thanks,
> Gavin
>
>> Forward declaring struct pci_dev in aer.h avoids this warning:
>>
>> In file included from include/ras/ras_event.h:11:0,
>> from drivers/ras/ras.c:13:
>> include/linux/aer.h:38:44: warning: 'struct pci_dev’ declared inside parameter list [enabled by default]
>> include/linux/aer.h:38:44: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>>
>> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
>> ---
>> include/linux/aer.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/aer.h b/include/linux/aer.h
>> index 4dbaa70..d9ec8dd 100644
>> --- a/include/linux/aer.h
>> +++ b/include/linux/aer.h
>> @@ -7,6 +7,8 @@
>> #ifndef _AER_H_
>> #define _AER_H_
>>
>> +struct pci_dev;
>> +
>> #define AER_NONFATAL 0
>> #define AER_FATAL 1
>> #define AER_CORRECTABLE 2
>> --
--
~Randy
prev parent reply other threads:[~2014-07-22 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 16:30 [PATCH] PCI/AER: Forward declare struct pci_dev to avoid warning Tuomas Tynkkynen
2014-07-21 23:27 ` Gavin Shan
2014-07-22 0:00 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CDA99D.4090602@infradead.org \
--to=rdunlap@infradead.org \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ttynkkynen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).