From: Tomas Henzl <thenzl@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Gordeev <agordeev@redhat.com>,
linux-kernel@vger.kernel.org, xjtuwjp@gmail.com,
lindar_liu@usish.com, linux-scsi@vger.kernel.org,
linux-pci@vger.kernel.org,
Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Subject: Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed
Date: Tue, 29 Jul 2014 15:48:29 +0200 [thread overview]
Message-ID: <53D7A62D.2090709@redhat.com> (raw)
In-Reply-To: <20140729132020.GA7714@infradead.org>
On 07/29/2014 03:20 PM, Christoph Hellwig wrote:
> On Tue, Jul 29, 2014 at 03:13:06PM +0200, Tomas Henzl wrote:
>> Hi,
>> patch looks good.
>>
>> A correction in pm8001_request_irq might be added too to allow
>> the INT-X path when pm8001_setup_msix fails, but that is not part
>> of this fix.
>
> There's actually an equivalent fix already in through one of the
> previous pm8001 updates, so I skipped this one even if it already had an
> ACK. The following pm8001 applied just fine, though. Take a look, as
> I've already pushed out the updated drivers branch.
I'm a bit confused - you were not commenting my text above I think?
I see in drivers-for-3.17 this patch already applied 5607de7
but not yet the next one (18/23) which also has a review, is there another ack needed?
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-29 13:49 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 18:05 [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 02/23] bfa: Do not call pci_enable_msix() after it failed once Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 03/23] bfa: Cleanup bfad_setup_intr() function Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-08-11 7:39 ` Alexander Gordeev
2014-08-11 11:02 ` Anil Gurumurthy
2014-08-12 10:50 ` Alexander Gordeev
2014-08-14 2:55 ` Anil Gurumurthy
2014-07-16 18:05 ` [PATCH v2 RESEND 05/23] csiostor: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-07-26 8:13 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-11 7:49 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() " Alexander Gordeev
2014-07-26 8:15 ` Alexander Gordeev
2014-07-28 8:08 ` Suma Ramars (sramars)
2014-07-16 18:05 ` [PATCH v2 RESEND 08/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed Alexander Gordeev
2014-07-26 8:16 ` Alexander Gordeev
2014-08-11 7:53 ` Alexander Gordeev
2014-08-13 16:04 ` scameron
2014-08-13 17:05 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 09/23] hpsa: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-15 15:48 ` scameron
2014-07-16 18:05 ` [PATCH v2 RESEND 10/23] isci: Use pci_enable_msix_exact() " Alexander Gordeev
2014-08-11 7:57 ` Alexander Gordeev
[not found] ` <718e4066d6294033a7590659cf0f3c4d@fmsmsx106.amr.corp.intel.com>
2014-08-11 16:55 ` Jiang, Dave
2014-07-16 18:05 ` [PATCH v2 RESEND 11/23] lpfc: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-07-26 8:22 ` Alexander Gordeev
2014-08-11 8:01 ` Alexander Gordeev
2014-08-11 17:14 ` James Smart
2014-08-12 8:11 ` Alexander Gordeev
2014-08-12 8:09 ` [PATCH v3 " Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 14/23] megaraid: " Alexander Gordeev
2014-08-11 8:09 ` Alexander Gordeev
2014-08-11 8:29 ` Kashyap Desai
2014-07-16 18:05 ` [PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() " Alexander Gordeev
2014-07-26 8:26 ` Alexander Gordeev
2014-08-11 13:07 ` Tomas Henzl
2014-07-16 18:05 ` [PATCH v2 RESEND 16/23] mpt3sas: " Alexander Gordeev
2014-08-11 8:13 ` Alexander Gordeev
2014-08-11 13:07 ` Tomas Henzl
2014-07-16 18:05 ` [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed Alexander Gordeev
2014-07-29 13:13 ` Tomas Henzl
2014-07-29 13:20 ` Christoph Hellwig
2014-07-29 13:48 ` Tomas Henzl [this message]
2014-07-29 13:56 ` Christoph Hellwig
2014-07-29 14:15 ` Alexander Gordeev
2014-07-29 14:24 ` Christoph Hellwig
2014-08-11 8:14 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-07-26 8:33 ` Alexander Gordeev
2014-07-27 10:29 ` Jack Wang
2014-07-16 18:05 ` [PATCH v2 RESEND 19/23] pmcraid: Get rid of a redundant assignment Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 20/23] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-07-26 8:37 ` Alexander Gordeev
2014-08-11 7:44 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 21/23] qla2xxx: " Alexander Gordeev
2014-07-26 8:40 ` Alexander Gordeev
2014-08-11 8:57 ` Alexander Gordeev
2014-08-11 18:07 ` Chad Dupuis
2014-07-16 18:05 ` [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() " Alexander Gordeev
2014-07-26 8:41 ` Alexander Gordeev
2014-07-28 11:47 ` Vikas Chaudhary
2014-08-11 8:54 ` Alexander Gordeev
2014-08-11 9:40 ` Christoph Hellwig
2014-07-16 18:05 ` [PATCH v2 RESEND 23/23] vmw_pvscsi: " Alexander Gordeev
2014-07-16 18:23 ` Arvind Kumar
2014-07-17 20:28 ` [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() " Christoph Hellwig
2014-07-29 12:38 ` Christoph Hellwig
[not found] ` <3d2402ebfad625e508bb13257e1560abf92594cd.1405533479.git.agordeev@redhat.com>
[not found] ` <20140726082408.GG21129@agordeev.usersys.redhat.com>
[not found] ` <3b7c554551d306e2f58f5e09dc171db2@mail.gmail.com>
2014-08-11 8:07 ` [PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X re-initialization failed Alexander Gordeev
-- strict thread matches above, loose matches on Subject: below --
2014-04-14 8:05 [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7A62D.2090709@redhat.com \
--to=thenzl@redhat.com \
--cc=Suresh.Thiagarajan@pmcs.com \
--cc=agordeev@redhat.com \
--cc=hch@infradead.org \
--cc=lindar_liu@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).