linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Edward Cree <ecree@solarflare.com>
To: <linux-pci@vger.kernel.org>
Subject: pci_sriov_set_totalvfs again
Date: Wed, 30 Jul 2014 18:23:10 +0100	[thread overview]
Message-ID: <53D929FE.40706@solarflare.com> (raw)

Calling pci_sriov_set_totalvfs(dev, 0) has no effect, because
pci_sriov_get_totalvfs ignores dev->sriov->driver_max_VFs if it's 0, as
that is used as the 'not set' value.
So, three questions:
a) is this a bug?
b) if not, should the comment on pci_sriov_set_totalvfs mention that
passing numvfs=0 will be interpreted as numvfs=dev->sriov->total_VFs?
c) is there a better way of indicating "current configuration doesn't
support VFs" rather than calling set_totalvfs(0)?

Thanks,
-Edward
||
The information contained in this message is confidential and is intended for the addressee(s) only. If you have received this message in error, please notify the sender immediately and delete the message. Unless you are an addressee (or authorized to receive for an addressee), you may not use, copy or disclose to anyone this message or any information contained in this message. The unauthorized use, disclosure, copying or alteration of this message is strictly prohibited.

             reply	other threads:[~2014-07-30 17:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-30 17:23 Edward Cree [this message]
     [not found] <53D9288B.5030302@solarflare.com>
2014-07-30 18:05 ` pci_sriov_set_totalvfs again Don Dutile
2014-07-30 18:24   ` Edward Cree
2014-07-30 21:14     ` Alexander Duyck
2014-07-31 12:07       ` Edward Cree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D929FE.40706@solarflare.com \
    --to=ecree@solarflare.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).