From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:37482 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753849AbaHULKS (ORCPT ); Thu, 21 Aug 2014 07:10:18 -0400 Message-ID: <53F5D397.2020508@redhat.com> Date: Thu, 21 Aug 2014 13:10:15 +0200 From: Tomas Henzl MIME-Version: 1.0 To: Alexander Gordeev , linux-kernel@vger.kernel.org CC: Jayamohan Kallickal , linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v3 08/13] be2iscsi: Use pci_enable_msix_range() References: <1cf2c3d3243067edac8d170cda0450c82bbfc025.1408335523.git.agordeev@redhat.com> In-Reply-To: <1cf2c3d3243067edac8d170cda0450c82bbfc025.1408335523.git.agordeev@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On 08/18/2014 08:01 AM, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() and pci_enable_msix_range() > interfaces. Patch looks good to me. Reviewed-by: Tomas Henzl > Signed-off-by: Alexander Gordeev > Cc: Jayamohan Kallickal > Cc: linux-scsi@vger.kernel.org > Cc: linux-pci@vger.kernel.org > --- > drivers/scsi/be2iscsi/be_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c > index 915c26b..b422659 100644 > --- a/drivers/scsi/be2iscsi/be_main.c > +++ b/drivers/scsi/be2iscsi/be_main.c > @@ -5276,9 +5276,9 @@ static void beiscsi_msix_enable(struct beiscsi_hba *phba) > for (i = 0; i <= phba->num_cpus; i++) > phba->msix_entries[i].entry = i; > > - status = pci_enable_msix(phba->pcidev, phba->msix_entries, > - (phba->num_cpus + 1)); > - if (!status) > + status = pci_enable_msix_range(phba->pcidev, phba->msix_entries, > + phba->num_cpus + 1, phba->num_cpus + 1); > + if (status > 0) > phba->msix_enabled = true; > > return;