From: Tomas Henzl <thenzl@redhat.com>
To: Alexander Gordeev <agordeev@redhat.com>, linux-kernel@vger.kernel.org
Cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>,
linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 12/13] pmcraid: Get rid of a redundant assignment
Date: Thu, 21 Aug 2014 13:33:52 +0200 [thread overview]
Message-ID: <53F5D920.1080800@redhat.com> (raw)
In-Reply-To: <8058dca6525ca29845019ea9922c37f3416c0c7a.1408335523.git.agordeev@redhat.com>
On 08/18/2014 08:01 AM, Alexander Gordeev wrote:
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> ---
> drivers/scsi/pmcraid.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index 6f3275d..6e575ed 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4746,7 +4746,6 @@ pmcraid_isr_legacy:
> pinstance->hrrq_vector[0].drv_inst = pinstance;
> pinstance->hrrq_vector[0].vector = pdev->irq;
> pinstance->num_hrrq = 1;
> - rc = 0;
>
> rc = request_irq(pdev->irq, pmcraid_isr, IRQF_SHARED,
> PMCRAID_DRIVER_NAME, &pinstance->hrrq_vector[0]);
Patch looks good to me.
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
next prev parent reply other threads:[~2014-08-21 11:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 6:01 [PATCH v3 00/13] scsi: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-18 6:01 ` [PATCH v3 01/13] hpsa: Fallback to MSI rather than to INTx if MSI-X failed Alexander Gordeev
2014-08-18 6:01 ` [PATCH v3 02/13] hpsa: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-18 6:01 ` [PATCH v3 03/13] megaraid: Fail resume if MSI-X re-initialization failed Alexander Gordeev
2014-08-18 6:01 ` [PATCH v3 04/13] megaraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-18 6:01 ` [PATCH v3 05/13] mpt2sas: Use pci_enable_msix_exact() " Alexander Gordeev
2014-08-18 6:01 ` [PATCH v3 06/13] mpt3sas: " Alexander Gordeev
2014-08-18 6:01 ` [PATCH v3 07/13] qla2xxx: Use pci_enable_msix_range() " Alexander Gordeev
2014-08-18 6:01 ` [PATCH v3 08/13] be2iscsi: Use pci_enable_msix_range() Alexander Gordeev
2014-08-21 11:10 ` Tomas Henzl
2014-08-22 14:40 ` Jayamohan Kallickal
2014-08-18 6:01 ` [PATCH v3 09/13] csiostor: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-08-21 11:15 ` Tomas Henzl
2014-08-18 6:01 ` [PATCH v3 10/13] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-21 11:15 ` Tomas Henzl
2014-08-18 6:01 ` [PATCH v3 11/13] lpfc: " Alexander Gordeev
2014-08-21 11:32 ` Tomas Henzl
2014-08-21 11:58 ` Tomas Henzl
2014-08-21 16:58 ` Alexander Gordeev
2014-08-21 17:02 ` Christoph Hellwig
2014-09-04 13:29 ` Alexander Gordeev
2014-09-04 15:11 ` Christoph Hellwig
2014-08-18 6:01 ` [PATCH v3 12/13] pmcraid: Get rid of a redundant assignment Alexander Gordeev
2014-08-21 11:33 ` Tomas Henzl [this message]
2014-08-18 6:01 ` [PATCH v3 13/13] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-21 11:35 ` Tomas Henzl
2014-08-19 17:00 ` [PATCH v3 00/13] scsi: " Christoph Hellwig
2014-08-20 19:14 ` Alexander Gordeev
2014-08-20 19:22 ` Christoph Hellwig
2014-08-24 17:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F5D920.1080800@redhat.com \
--to=thenzl@redhat.com \
--cc=agordeev@redhat.com \
--cc=anil_ravindranath@pmc-sierra.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).