From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <545CDA87.2040701@linaro.org> Date: Fri, 07 Nov 2014 15:43:19 +0100 From: Tomasz Nowicki MIME-Version: 1.0 To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org CC: catalin.marinas@arm.com, will.deacon@arm.com, bhelgaas@google.com, Liviu.Dudau@arm.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, rjw@rjwysocki.net, linaro-acpi@lists.linaro.org, linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [RFC PATCH 2/4] x86, acpi, pci: Isolate new PCI mmconfig entry insertion. References: <1415366876-30811-1-git-send-email-tomasz.nowicki@linaro.org> <1415366876-30811-3-git-send-email-tomasz.nowicki@linaro.org> <1927317.6tJuq4S5Om@wuerfel> In-Reply-To: <1927317.6tJuq4S5Om@wuerfel> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-acpi-owner@vger.kernel.org List-ID: On 07.11.2014 15:09, Arnd Bergmann wrote: > On Friday 07 November 2014 14:27:54 Tomasz Nowicki wrote: >> Add special pci_mmcfg_insert_lock mutex since pci_mmcfg_lock was moved >> to common file. No functional changes. >> >> Signed-off-by: Tomasz Nowicki >> > > What is the new lock protecting against? You no longer have a mutual > exclusion with the other code, which looks like it is a functional > change, and also incorrect. > > It also sounds like the code was broken after the first patch and > you need this one to make it compile again. You can't do that, and > instead need to change the locking rules first. Oh, that's right! Sorry I will take a look again. Tomasz