From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] PCI: generic: Add set_msi_parent callback
Date: Tue, 11 Nov 2014 22:33:44 +0700 [thread overview]
Message-ID: <54622C58.1040701@amd.com> (raw)
In-Reply-To: <20141111112424.GB16265@arm.com>
On 11/11/14 18:24, Will Deacon wrote:
>> @@ -313,6 +324,9 @@ static int gen_pci_probe(struct platform_device *pdev)
>> > return err;
>> > }
>> >
>> >+ pci->mchip = of_pci_find_msi_chip_by_node(of_parse_phandle(np,
>> >+ "msi-parent", 0));
> This bit should be in the generic of_pci.c code and not duplicated for
> each host controller.
>
> Will
I forgot to mention and include in the patch that we are also
introducing "msi-parent" binding to the generic host controller. I'll do
that in v2.
Unless this is something that we would like to add to the generic OF
binding for PCI, I think it should be in the pci-host-generic.c.
Thanks,
Suravee
next prev parent reply other threads:[~2014-11-11 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 19:24 [PATCH 0/2] PCI: generic: Assiging msi-controller to PCI hostbridge suravee.suthikulpanit
2014-11-10 19:24 ` [PATCH 1/2] PCI: Add new pci_ops for setting MSI parent for PCI bus suravee.suthikulpanit
2014-11-10 19:24 ` [PATCH 2/2] PCI: generic: Add set_msi_parent callback suravee.suthikulpanit
2014-11-11 11:24 ` Will Deacon
2014-11-11 11:52 ` Liviu Dudau
2014-11-13 15:22 ` Lorenzo Pieralisi
2014-11-13 18:32 ` Liviu Dudau
2014-11-13 23:19 ` Jiang Liu
2014-11-11 15:33 ` Suravee Suthikulpanit [this message]
2014-11-13 15:32 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54622C58.1040701@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).