From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: Srikanth Thokala <sriku.linux@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, <liviu.dudau@arm.com>,
<lorenzo.pieralisi@arm.com>, <will.deacon@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/2] PCI: generic: Add msi_parent DT binding
Date: Wed, 12 Nov 2014 18:36:07 +0700 [thread overview]
Message-ID: <54634627.60502@amd.com> (raw)
In-Reply-To: <CA+mB=1LEEtPCixB9Ej74L03yPPH7D6YvfpkZyJgsHCm97-GvKg@mail.gmail.com>
On 11/12/14 13:56, Srikanth Thokala wrote:
>> @@ -122,9 +123,19 @@ static int gen_pci_config_write(struct pci_bus *bus, unsigned int devfn,
>> > return PCIBIOS_SUCCESSFUL;
>> > }
>> >
>> >+static int gen_pci_set_msi_parent(struct pci_bus *bus)
>> >+{
>> >+ struct gen_pci *pci = bus_to_gen_pci(bus);
>> >+
>> >+ bus->msi = pci->mchip;
>> >+
>> >+ return PCIBIOS_SUCCESSFUL;
>> >+}
>> >+
>> > static struct pci_ops gen_pci_ops = {
>> > .read = gen_pci_config_read,
>> > .write = gen_pci_config_write,
>> >+ .set_msi_parent = gen_pci_set_msi_parent,
> We assign the msi chip through add_bus() call, do we still need this?
Certain architecture (i.e arm64) doesn't implement struct hw_pci.
Therefore, there is no add_bus(). However, this new API should allow
non-arch dependent implementation.
Suravee
next prev parent reply other threads:[~2014-11-12 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 19:17 [PATCH V2 0/2] PCI: generic: Assiging msi-controller to PCI hostbridge suravee.suthikulpanit
2014-11-11 19:17 ` [PATCH V2 1/2] PCI: Add new pci_ops for setting MSI parent for PCI bus suravee.suthikulpanit
2014-11-11 19:17 ` [PATCH V2 2/2] PCI: generic: Add msi_parent DT binding suravee.suthikulpanit
2014-11-12 6:56 ` Srikanth Thokala
2014-11-12 7:09 ` Srikanth Thokala
2014-11-12 11:37 ` Suravee Suthikulpanit
2014-11-12 11:36 ` Suravee Suthikulpanit [this message]
2014-11-13 18:09 ` [PATCH V2 0/2] PCI: generic: Assiging msi-controller to PCI hostbridge Bjorn Helgaas
2014-11-14 1:19 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54634627.60502@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=sriku.linux@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).