From: Murali Karicheri <m-karicheri2@ti.com>
To: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: How to fix CHECK warning: testing a 'safe expression' ?
Date: Wed, 17 Dec 2014 11:18:46 -0500 [thread overview]
Message-ID: <5491ACE6.4070108@ti.com> (raw)
In-Reply-To: <54907884.2040502@ti.com>
I am trying to address CHECK warnings in my driver and wondering how to
resolve 'warning: testing a 'safe expression' which appears when using
IS_ERR_OR_NULL(foo)
where foo is defined as
struct foo_type *foo;
The foo get assigned only NULL or ERR_PTR(error code). So I believe the
usage is correct. But then how do I make the CHECK happy of its usage?
I have tried a grep to check on the current usage of IS_ERR_OR_NULL()
and found 276 of them causes this warning in the v3.18 version of the
kernel that I am using
$ grep -r "warning: testing a 'safe expression" * | wc -l
276
Can someone help me undestand what this means and how to fix the same?
I run folling for CHECK
make C=2 CF="-D__CHECK_ENDIAN__" CHECK=sparse
Thanks in advance for your suggestions.
--
Murali Karicheri
Linux Kernel, Texas Instruments
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next parent reply other threads:[~2014-12-17 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54907884.2040502@ti.com>
2014-12-17 16:18 ` Murali Karicheri [this message]
2014-12-17 18:49 ` How to fix CHECK warning: testing a 'safe expression' ? Bjorn Helgaas
2014-12-17 22:35 ` Murali Karicheri
2014-12-17 22:37 ` Murali Karicheri
2014-12-18 2:39 ` Christopher Li
2014-12-18 17:45 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5491ACE6.4070108@ti.com \
--to=m-karicheri2@ti.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).