From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f174.google.com ([209.85.217.174]:40931 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbbAQQju (ORCPT ); Sat, 17 Jan 2015 11:39:50 -0500 Received: by mail-lb0-f174.google.com with SMTP id 10so22681074lbg.5 for ; Sat, 17 Jan 2015 08:39:49 -0800 (PST) Message-ID: <54BA9052.9080904@cogentembedded.com> Date: Sat, 17 Jan 2015 19:39:46 +0300 From: Sergei Shtylyov MIME-Version: 1.0 To: Yijing Wang , Bjorn Helgaas CC: Liviu Dudau , Tony Luck , Russell King , Arnd Bergmann , Marc Zyngier , linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , linux-m68k@lists.linux-m68k.org, Geert Uytterhoeven , linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, Thomas Gleixner , Guan Xuetao , Yinghai Lu , Jiang Liu , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity References: <1421372666-12288-1-git-send-email-wangyijing@huawei.com> <1421372666-12288-24-git-send-email-wangyijing@huawei.com> In-Reply-To: <1421372666-12288-24-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: Hello. On 1/16/2015 4:44 AM, Yijing Wang wrote: > Use pci_scan_root_bus() instead of pci_create_root_bus() + > pci_scan_child_bus() for simplicity. > Signed-off-by: Yijing Wang > --- > drivers/pci/host/pcie-designware.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index eef3111..d37fe27 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys) > struct pcie_port *pp = sys_to_pcie(sys); > > pp->root_bus_nr = sys->busnr; > - bus = pci_create_root_bus(pp->dev, sys->busnr, > + bus = pci_scan_root_bus(pp->dev, sys->busnr, > &dw_pcie_ops, sys, &sys->resources); Please realign this line, so that it still starts under 'pp'. WBR, Sergei