From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <54BF0C71.5080508@linux.intel.com> Date: Wed, 21 Jan 2015 10:18:25 +0800 From: Jiang Liu MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: Thomas Gleixner , Bjorn Helgaas , Yinghai Lu , Borislav Petkov , Len Brown , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [RFC Patch 12/19] ACPI: Enforce stricter checks for address space descriptors References: <1420684386-5975-1-git-send-email-jiang.liu@linux.intel.com> <1420684386-5975-13-git-send-email-jiang.liu@linux.intel.com> <12267175.FvlCJYWCa5@vostro.rjw.lan> In-Reply-To: <12267175.FvlCJYWCa5@vostro.rjw.lan> Content-Type: text/plain; charset=utf-8 Sender: linux-acpi-owner@vger.kernel.org List-ID: On 2015/1/21 8:45, Rafael J. Wysocki wrote: > On Thursday, January 08, 2015 10:32:59 AM Jiang Liu wrote: >> Enforce stricter checks for address space descriptors according to >> ACPI spec. > > So is the spec the only reason for doing this? If so, I'd say don't. Hi Rafael, Yes, it's just for spec. I will drop this patch to avoid regressions. Regards! Gerry > >> Signed-off-by: Jiang Liu >> --- >> drivers/acpi/resource.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c >> index 26b47f1da523..e82149e44347 100644 >> --- a/drivers/acpi/resource.c >> +++ b/drivers/acpi/resource.c >> @@ -192,6 +192,14 @@ static bool acpi_decode_space(struct resource *res, >> bool wp = base->info.mem.write_protect; >> u64 len = addr->address_length; >> >> + /* >> + * Filter out invalid descriptor according to ACPI Spec 5.0, section >> + * 6.4.3.5 Address Space Resource Descriptors. >> + */ >> + if ((base->min_address_fixed != base->max_address_fixed && len) || >> + (base->min_address_fixed && base->max_address_fixed && !len)) >> + return false; >> + >> res->start = addr->minimum; >> res->end = addr->maximum; >> >> >