From: Jiang Liu <jiang.liu@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Yinghai Lu <yinghai@kernel.org>, Borislav Petkov <bp@alien8.de>,
Len Brown <lenb@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Vivek Goyal <vgoyal@redhat.com>,
Thierry Reding <treding@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Travis <travis@sgi.com>, Tony Luck <tony.luck@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: Re: [RFC Patch 17/19] resources: Move struct resource_list_entry from ACPI into resource core
Date: Wed, 21 Jan 2015 20:32:06 +0800 [thread overview]
Message-ID: <54BF9C46.8060302@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1501211043170.5526@nanos>
On 2015/1/21 17:43, Thomas Gleixner wrote:
> On Wed, 21 Jan 2015, Jiang Liu wrote:
>> On 2015/1/21 9:10, Rafael J. Wysocki wrote:
>>>> +
>>>> +void resource_list_insert(struct list_head *head,
>>>> + struct resource_list_entry *entry, bool tail)
>>>
>>> I would call this resource_list_add() if anything.
>>>
>>> Also it may be better to have two helpers, one for "add" and one for "add_tail"
>>> (and perhaps define them as static inline?).
>> We can't use inline functions here because that needs pulling list.h
>> into ioport.h, then causing building issues to header inclusion order.
>
> Create a new header file to avoid the circular dependencies then.
Great, create include/linux/resource_list.h for it so we could
inline those simple functions.
Regards,
Gerry
>
> Thanks,
>
> tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2015-01-21 12:32 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 2:32 [RFC Patch 00/19] Improve ACPI resource parsing interfaces and data structures Jiang Liu
2015-01-08 2:32 ` [RFC Patch 01/19] ACPI: Remove redundant check in function acpi_dev_resource_address_space() Jiang Liu
2015-01-08 2:32 ` [RFC Patch 02/19] ACPI: Implement proper length checks for mem resources Jiang Liu
2015-01-08 2:32 ` [RFC Patch 03/19] ACPI: Use the length check for io resources as well Jiang Liu
2015-01-08 2:32 ` [RFC Patch 04/19] ACPI: Let the parser return false for disabled resources Jiang Liu
2015-01-08 2:32 ` [RFC Patch 05/19] ACPI: Provide union for address_space64 and ext_address_space64 Jiang Liu
2015-01-21 0:32 ` Rafael J. Wysocki
2015-01-22 2:32 ` Zheng, Lv
2015-01-22 2:57 ` Jiang Liu
2015-01-22 3:24 ` Zheng, Lv
2015-01-22 10:38 ` Thomas Gleixner
2015-01-08 2:32 ` [RFC Patch 06/19] ACPI: Unify the parsing of address_space and ext_address_space Jiang Liu
2015-01-08 2:32 ` [RFC Patch 07/19] ACPI: Move the window flag logic to the combined parser Jiang Liu
2015-01-08 2:32 ` [RFC Patch 08/19] ACPI: Add prefetch decoding to the address space parser Jiang Liu
2015-01-21 0:35 ` Rafael J. Wysocki
2015-01-21 5:26 ` Jiang Liu
2015-01-21 14:48 ` Rafael J. Wysocki
2015-01-08 2:32 ` [RFC Patch 09/19] ACPI: Fix a bug in parsing ACPI Memroy24 resource Jiang Liu
2015-01-21 0:42 ` Rafael J. Wysocki
2015-01-21 2:15 ` Jiang Liu
2015-01-21 2:59 ` Rafael J. Wysocki
2015-01-21 2:48 ` Jiang Liu
2015-01-08 2:32 ` [RFC Patch 10/19] ACPI: Normalize return value of resource parser functions Jiang Liu
2015-01-08 2:32 ` [RFC Patch 11/19] ACPI: Set flag IORESOURCE_UNSET for unassigned resources Jiang Liu
2015-01-08 2:32 ` [RFC Patch 12/19] ACPI: Enforce stricter checks for address space descriptors Jiang Liu
2015-01-21 0:45 ` Rafael J. Wysocki
2015-01-21 2:18 ` Jiang Liu
2015-01-21 3:01 ` Rafael J. Wysocki
2015-01-08 2:33 ` [RFC Patch 13/19] ACPI: Return translation offset when parsing ACPI address space resources Jiang Liu
2015-01-08 2:33 ` [RFC Patch 14/19] ACPI: Translate resource into master side address for bridge window resources Jiang Liu
2015-01-21 0:50 ` Rafael J. Wysocki
2015-01-21 5:36 ` Jiang Liu
2015-01-21 14:48 ` Rafael J. Wysocki
2015-01-08 2:33 ` [RFC Patch 15/19] ACPI: Add field offset to struct resource_list_entry Jiang Liu
2015-01-21 0:53 ` Rafael J. Wysocki
2015-01-21 5:37 ` Jiang Liu
2015-01-21 14:47 ` Rafael J. Wysocki
2015-01-21 15:01 ` Jiang Liu
2015-01-08 2:33 ` [RFC Patch 16/19] ACPI: Introduce helper function acpi_dev_filter_resource_type() Jiang Liu
2015-01-15 21:30 ` Thomas Gleixner
2015-01-16 0:58 ` Jiang Liu
2015-01-08 2:33 ` [RFC Patch 17/19] resources: Move struct resource_list_entry from ACPI into resource core Jiang Liu
2015-01-21 1:10 ` Rafael J. Wysocki
2015-01-21 6:37 ` Jiang Liu
2015-01-21 9:43 ` Thomas Gleixner
2015-01-21 12:32 ` Jiang Liu [this message]
2015-01-08 2:33 ` [RFC Patch 18/19] PCI: Use common resource list management code instead of private implementation Jiang Liu
2015-01-08 2:33 ` [RFC Patch 19/19] x86/PCI/ACPI: Use common ACPI resource interfaces to simplify implementation Jiang Liu
2015-01-11 22:38 ` [RFC Patch 00/19] Improve ACPI resource parsing interfaces and data structures Rafael J. Wysocki
2015-01-19 14:26 ` Jiang Liu
2015-01-19 15:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BF9C46.8060302@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=travis@sgi.com \
--cc=treding@nvidia.com \
--cc=vgoyal@redhat.com \
--cc=vinod.koul@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).