From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
David Vrabel <david.vrabel@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [Xen-devel] [PATCH v2] PCI: Add guard to avoid mapping a invalid msix base address
Date: Thu, 29 Jan 2015 09:30:13 +0800 [thread overview]
Message-ID: <54C98D25.1090004@huawei.com> (raw)
In-Reply-To: <CAErSpo6+VHMx-CrTUFMbkBUWG-u+ueRaUJHHT=0P4OUNvrudRg@mail.gmail.com>
>>
>> Right, I think it does.
>>
>> One question: do we need to check flags for IORESOURCE_DISABLED as well?
>> Currently IORESOURCE_DISABLED and IORESOURCE_UNSET are set together for PCI
>> so it probably doesn't matter right now but if this changes we won't want to
>> use BAR that's disabled, will we?
>
> That's a good question. My intent was to use IORESOURCE_DISABLED for
> cases where we don't want to even try to assign resources to a BAR,
> e.g., for BARs that want more than 4GB of space when the kernel isn't
> compiled with support for 64-bit BARs. In that case, I intended to
> set IORESOURCE_UNSET as well.
>
> So I think we're OK with only testing IORESOURCE_UNSET.
>
> Yijing, do you want to expand this patch to fix
> xen_initdom_setup_msi_irqs() as well?
I'm willing to do.
Thanks!
Yijing.
>
> Bjorn
>
> .
>
--
Thanks!
Yijing
prev parent reply other threads:[~2015-01-29 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 1:52 [PATCH v2] PCI: Add guard to avoid mapping a invalid msix base address Yijing Wang
2015-01-28 18:13 ` Bjorn Helgaas
2015-01-28 21:05 ` [Xen-devel] " Boris Ostrovsky
2015-01-28 22:05 ` Bjorn Helgaas
2015-01-29 1:30 ` Yijing Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C98D25.1090004@huawei.com \
--to=wangyijing@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=kvm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).