From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
mst@redhat.com
Subject: Re: [RFC PATCH] PCI: Disable MSI/MSI-X only if device is shutdown
Date: Fri, 13 Mar 2015 14:03:01 +0100 [thread overview]
Message-ID: <5502E005.7000406@redhat.com> (raw)
In-Reply-To: <20150312232104.GA32054@ad.nay.redhat.com>
On 13/03/2015 00:21, Fam Zheng wrote:
>> I think the bug here is also that virtio-pci
>> is not defining a .shutdown callback. It should define one and call
>> free_irq (for INTX) and pci_disable_msix.
>
> It's not enough. The device has to know we disabled msix, otherwise it will
> send us IRQ, which is wrong.
You can use pci_intx to disable INTX too. So I think this is a
virtio-pci bug.
Paolo
next prev parent reply other threads:[~2015-03-13 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 5:21 [RFC PATCH] PCI: Disable MSI/MSI-X only if device is shutdown Fam Zheng
2015-03-12 16:21 ` Paolo Bonzini
2015-03-12 23:21 ` Fam Zheng
2015-03-13 13:03 ` Paolo Bonzini [this message]
2015-03-12 23:56 ` Bandan Das
2015-03-13 2:09 ` Fam Zheng
2015-03-13 3:09 ` Bandan Das
2015-03-13 3:17 ` Fam Zheng
2015-03-13 3:35 ` Bandan Das
2015-03-13 4:13 ` Alex Williamson
2015-03-13 4:53 ` Fam Zheng
2015-03-16 12:14 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5502E005.7000406@redhat.com \
--to=pbonzini@redhat.com \
--cc=bhelgaas@google.com \
--cc=famz@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).