linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: [PATCH update] PCI / ACPI: PCI delay optimization from ACPI
Date: Mon, 23 Mar 2015 17:15:28 +0800	[thread overview]
Message-ID: <550FD9B0.7070803@intel.com> (raw)
In-Reply-To: <550FA607.8080805@intel.com>

On 03/23/2015 01:35 PM, Aaron Lu wrote:
> On 03/21/2015 05:03 AM, Bjorn Helgaas wrote:
>> I think you need something in pci_root.c that evaluates _DSM function 8 for
>> the host bridge, and then some mechanism for all the devices under that
>> bridge to inherit the result.
> 
> Thanks for the suggestion, will try to do this in the next revision.

Turned out I can decide if a PCI bridge is the host bridge or not by
checking: pdev->bus->bridge->parent pointer, so I did something like
this instead:

+       /* Function 8 is only applicable to host bridge */
+       if (pdev->bus->bridge->parent)
+               return;

Looks good?

And I also renamed the UUID and moved the common definitions to pci.h,
so the following two patches do these things:
patch 1: rename the PCI UUID and move the definitions to pci.h;
patch 2: add check for host bridge in pci_acpi_delay_optimize, re-order
         elements[0] and elements[3] check and use macros for _DSM
	 function 8 and 9.

Thanks,
Aaron

  reply	other threads:[~2015-03-23  9:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09  7:46 [PATCH] PCI / ACPI: PCI delay optimization from ACPI Aaron Lu
2015-03-09 14:33 ` Rafael J. Wysocki
2015-03-10  6:47   ` Aaron Lu
2015-03-10  6:48   ` [PATCH update] " Aaron Lu
2015-03-20  6:14     ` Aaron Lu
2015-03-20 12:39       ` Rafael J. Wysocki
2015-03-20 21:03     ` Bjorn Helgaas
2015-03-23  5:35       ` Aaron Lu
2015-03-23  9:15         ` Aaron Lu [this message]
2015-03-23  9:16       ` [PATCH 1/2] PCI: rename dsm uuid for PCI Aaron Lu
2015-03-24  0:24         ` Rafael J. Wysocki
2015-03-24  0:35           ` Aaron Lu
2015-03-24  1:03             ` Rafael J. Wysocki
2015-03-24  9:04               ` [PATCH v2 1/2] PCI: rename _DSM UUID array Aaron Lu
2015-03-24 21:57                 ` Rafael J. Wysocki
2015-03-23  9:17       ` [PATCH 2/2] PCI / ACPI: PCI delay optimization from ACPI Aaron Lu
2015-03-23 15:09         ` Bjorn Helgaas
2015-03-24  9:04           ` [PATCH v2 " Aaron Lu
2015-03-24 14:08             ` Bjorn Helgaas
2015-03-24 15:16               ` Aaron Lu
2015-03-24 22:09                 ` Bjorn Helgaas
2015-03-24 15:37               ` Aaron Lu
2015-03-24 22:10                 ` Bjorn Helgaas
2015-03-25  6:30 ` [PATCH v3 0/3] " Aaron Lu
2015-03-25  6:31   ` [PATCH v3 1/3] PCI: rename _DSM UUID array Aaron Lu
2015-03-25  6:32   ` [PATCH v3 2/3] PCI: rename find_pci_host_bridge and export it Aaron Lu
2015-03-25  6:37   ` [PATCH v3 3/3] PCI / ACPI: PCI delay optimization from ACPI Aaron Lu
2015-03-29 14:17   ` [PATCH v3 0/3] " Aaron Lu
2015-04-08 21:32   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550FD9B0.7070803@intel.com \
    --to=aaron.lu@intel.com \
    --cc=bhelgaas@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).