* [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?
@ 2015-03-23 18:08 kbuild test robot
2015-03-23 18:08 ` [PATCH pci] PCI: pci_find_host_bridge() can be static kbuild test robot
2015-03-23 18:18 ` [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? Bjorn Helgaas
0 siblings, 2 replies; 6+ messages in thread
From: kbuild test robot @ 2015-03-23 18:08 UTC (permalink / raw)
To: Yijing Wang; +Cc: kbuild-all, Bjorn Helgaas, linux-pci, linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/enumeration-yw7
head: 2681a1f3d2011d4cbb888d3e974a13bda85d225c
commit: 2577ed41b6a6db3117713069e49b72091b60c867 [32/35] PCI: rename to pci_find_host_bridge()
reproduce:
# apt-get install sparse
git checkout 2577ed41b6a6db3117713069e49b72091b60c867
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH pci] PCI: pci_find_host_bridge() can be static 2015-03-23 18:08 [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? kbuild test robot @ 2015-03-23 18:08 ` kbuild test robot 2015-03-23 18:18 ` [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? Bjorn Helgaas 1 sibling, 0 replies; 6+ messages in thread From: kbuild test robot @ 2015-03-23 18:08 UTC (permalink / raw) To: Yijing Wang; +Cc: kbuild-all, Bjorn Helgaas, linux-pci, linux-kernel Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- host-bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c index 8efb3a7..61171c4 100644 --- a/drivers/pci/host-bridge.c +++ b/drivers/pci/host-bridge.c @@ -144,7 +144,7 @@ static struct pci_bus *find_pci_root_bus(struct pci_bus *bus) return bus; } -struct pci_host_bridge *pci_find_host_bridge(struct pci_bus *bus) +static struct pci_host_bridge *pci_find_host_bridge(struct pci_bus *bus) { struct pci_bus *root_bus = find_pci_root_bus(bus); ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? 2015-03-23 18:08 [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? kbuild test robot 2015-03-23 18:08 ` [PATCH pci] PCI: pci_find_host_bridge() can be static kbuild test robot @ 2015-03-23 18:18 ` Bjorn Helgaas 2015-03-24 1:15 ` Yijing Wang 1 sibling, 1 reply; 6+ messages in thread From: Bjorn Helgaas @ 2015-03-23 18:18 UTC (permalink / raw) To: kbuild test robot Cc: Yijing Wang, kbuild-all@01.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Hi Yijing, On Mon, Mar 23, 2015 at 1:08 PM, kbuild test robot <fengguang.wu@intel.com> wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/enumeration-yw7 > head: 2681a1f3d2011d4cbb888d3e974a13bda85d225c > commit: 2577ed41b6a6db3117713069e49b72091b60c867 [32/35] PCI: rename to pci_find_host_bridge() > reproduce: > # apt-get install sparse > git checkout 2577ed41b6a6db3117713069e49b72091b60c867 > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > sparse warnings: (new ones prefixed by >>) > >>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? > > Please review and possibly fold the followup patch. It does look like pci_find_host_bridge() is only used inside drivers/pci/host-bridge.c and could be static. Given that it's only used there, it doesn't even need to be renamed, so maybe you could even just drop the rename patch, too. Bjorn ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? 2015-03-23 18:18 ` [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? Bjorn Helgaas @ 2015-03-24 1:15 ` Yijing Wang 2015-03-24 2:29 ` Bjorn Helgaas 0 siblings, 1 reply; 6+ messages in thread From: Yijing Wang @ 2015-03-24 1:15 UTC (permalink / raw) To: Bjorn Helgaas, kbuild test robot Cc: kbuild-all@01.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org >> sparse warnings: (new ones prefixed by >>) >> >>>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? >> >> Please review and possibly fold the followup patch. > > It does look like pci_find_host_bridge() is only used inside > drivers/pci/host-bridge.c and could be static. Given that it's only > used there, it doesn't even need to be renamed, so maybe you could > even just drop the rename patch, too. OK. Hi Bjorn, because this series involved lots platforms and host bridge chips, and this version takes a lot of changes. So I didn't take lot of time to cross build this series in all the platforms in my local. I hope you could see the changes first, and I will refresh and fix the details soon. Thanks! Yijing. > > Bjorn > > -- Thanks! Yijing ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? 2015-03-24 1:15 ` Yijing Wang @ 2015-03-24 2:29 ` Bjorn Helgaas 2015-03-24 3:41 ` Yijing Wang 0 siblings, 1 reply; 6+ messages in thread From: Bjorn Helgaas @ 2015-03-24 2:29 UTC (permalink / raw) To: Yijing Wang Cc: kbuild test robot, kbuild-all@01.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Mar 23, 2015 at 8:15 PM, Yijing Wang <wangyijing@huawei.com> wrote: >>> sparse warnings: (new ones prefixed by >>) >>> >>>>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? >>> >>> Please review and possibly fold the followup patch. >> >> It does look like pci_find_host_bridge() is only used inside >> drivers/pci/host-bridge.c and could be static. Given that it's only >> used there, it doesn't even need to be renamed, so maybe you could >> even just drop the rename patch, too. > > OK. > > Hi Bjorn, because this series involved lots platforms and host bridge chips, and this version takes a lot of changes. > So I didn't take lot of time to cross build this series in all the platforms in my local. I hope you could see the changes > first, and I will refresh and fix the details soon. I just put them on a branch for build testing. I will review them more closely when the build problems are resolved. FYI, I'll be on vacation from Mar 25 - Apr 2, so I won't be able to do much then. Bjorn ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? 2015-03-24 2:29 ` Bjorn Helgaas @ 2015-03-24 3:41 ` Yijing Wang 0 siblings, 0 replies; 6+ messages in thread From: Yijing Wang @ 2015-03-24 3:41 UTC (permalink / raw) To: Bjorn Helgaas Cc: kbuild test robot, kbuild-all@01.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org On 2015/3/24 10:29, Bjorn Helgaas wrote: > On Mon, Mar 23, 2015 at 8:15 PM, Yijing Wang <wangyijing@huawei.com> wrote: >>>> sparse warnings: (new ones prefixed by >>) >>>> >>>>>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? >>>> >>>> Please review and possibly fold the followup patch. >>> >>> It does look like pci_find_host_bridge() is only used inside >>> drivers/pci/host-bridge.c and could be static. Given that it's only >>> used there, it doesn't even need to be renamed, so maybe you could >>> even just drop the rename patch, too. >> >> OK. >> >> Hi Bjorn, because this series involved lots platforms and host bridge chips, and this version takes a lot of changes. >> So I didn't take lot of time to cross build this series in all the platforms in my local. I hope you could see the changes >> first, and I will refresh and fix the details soon. > > I just put them on a branch for build testing. I will review them > more closely when the build problems are resolved. > > FYI, I'll be on vacation from Mar 25 - Apr 2, so I won't be able to do > much then. OK, I post out the new v8 version which fixed the build problems and drop the unnecessary patch. Happy vacation! Thanks! Yijing. > > Bjorn > > -- Thanks! Yijing ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-24 3:41 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-23 18:08 [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? kbuild test robot 2015-03-23 18:08 ` [PATCH pci] PCI: pci_find_host_bridge() can be static kbuild test robot 2015-03-23 18:18 ` [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static? Bjorn Helgaas 2015-03-24 1:15 ` Yijing Wang 2015-03-24 2:29 ` Bjorn Helgaas 2015-03-24 3:41 ` Yijing Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).