Re: [PATCH v7 2/2] add new platform driver for PCI RC

Arnd Bergmann
2016-02-04T13:13:29Z

On Thursday 04 February 2016 11:10:55 Joao Pinto wrote:
> > The "synopsys" can go away, it's already in the vendor field of the
> > string. "ipk" is still a bit unspecific, I was hoping to see a specific
> > chip and/or version of the PCIe part. Something like
> >
> > compatible = "snps,ipk2040-pcie", "snps,ipk-pcie", "snps,dw-pcie-1.23", "snps,dw-pcie";
> >
> > which would indicate that there is a chip called "ipk2040" in a family called "ipk",
> > and this includes the designware pcie implementation in version 1.23.
> >
>
> "snps,dw-pcie" seems a good idea!
>

Just to clarify: I really meant you should put all four of the strings
into the compatible property.

Arnd