From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <555B4B67.40203@redhat.com> Date: Tue, 19 May 2015 10:40:39 -0400 From: Jarod Wilson MIME-Version: 1.0 To: "Rafael J. Wysocki" , Bjorn Helgaas CC: linux-kernel@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [Update][PATCH] PCIe / hotplug: Drop pointless ACPI-based "slot detection" check References: <1431632038-39917-1-git-send-email-jarod@redhat.com> <2168334.DgvA03CWPi@vostro.rjw.lan> <6257210.QKy3yrBgEf@vostro.rjw.lan> <1573807.HQlNd2BFYP@vostro.rjw.lan> In-Reply-To: <1573807.HQlNd2BFYP@vostro.rjw.lan> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: On 5/19/2015 9:27 AM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Jarod Wilson reports that the expresscard hotplug setup doesn't work > on HP ZBook G2. The problem turns out to be the ACPI-based "slot > detection" code called from pciehp_probe() which tries to use some > questionable heuristics based on what ACPI objects are present for > the PCIe port device at hand to figure out whether or not to register > a hotplug slot for that port. > > That code is used if there is at least one PCIe port having an ACPI > device configuration object related to hotplug (such as _EJ0 or _RMV) > and the Thunderbolt port on the affected machine has _RMV. Of course, > Thunderbolt and PCIe native hotplug need not be mutually exclusive > (as they aren't on the machine in question), so that rule is simply > incorrect. > > Moreover, the ACPI-based "slot detection" check does not add any > value if pciehp_probe() is called at all and the service type of the > device object it has been called for is PCIE_PORT_SERVICE_HP, because > PCIe hotplug services are only registered if the _OSC handshake in > acpi_pci_root_add() allows the kernel to control the PCIe native > hotplug feature. No more checks need to be carried out to decide > whether or not to register a native PCIe hotlug slot in that case. > > For the above reasons, make pciehp_probe() check if it has been > called for the right service type and drop the pointless ACPI-based > "slot detection" check from it. Also remove the entire code whose > only user is that check (the entire pciehp_acpi.c file goes away > as a result) and drop function headers related to it from the > internal PCIeHP header file. > > Link: http://marc.info/?t=143163219300002&r=1&w=2 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=98581 > Reported-by: Jarod Wilson > Signed-off-by: Rafael J. Wysocki > --- > > Changes in Makefile were missing from the previous version. > > Bjorn, that's -stable material I think. It should be applicable at least > since commit 5ba113f7c4fb (PCI: acpiphp: Handle PCIe ports without native > hotplug capability) that was shipped in 3.10. > > Thanks! Changes all look good to me, and they work perfectly here with the previously problematic ZBook 17. Reviewed-by: Jarod Wilson Tested-by: Jarod Wilson -- Jarod Wilson jarod@redhat.com