From: Michal Simek <monstr@monstr.eu>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] microblaze/PCI: Remove unused declarations
Date: Fri, 05 Jun 2015 08:42:23 +0200 [thread overview]
Message-ID: <557144CF.50500@monstr.eu> (raw)
In-Reply-To: <20150604195706.17951.85004.stgit@bhelgaas-glaptop2.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 2133 bytes --]
Hi Bjorn,
On 06/04/2015 09:57 PM, Bjorn Helgaas wrote:
> The following declarations were copied from powerpc but are unused on
> microblaze:
>
> struct pci_controller *init_phb_dynamic(struct device_node *dn)
> int remove_phb_dynamic(struct pci_controller *phb)
> struct pci_dev *of_create_pci_dev(struct device_node *node, ...)
> void of_scan_pci_bridge(struct device_node *node, ...)
> void of_scan_bus(struct device_node *node, struct pci_bus *bus)
> void of_rescan_bus(struct device_node *node, struct pci_bus *bus)
>
> Remove them.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> arch/microblaze/include/asm/pci.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/arch/microblaze/include/asm/pci.h b/arch/microblaze/include/asm/pci.h
> index 468aca8..b6b5b3c 100644
> --- a/arch/microblaze/include/asm/pci.h
> +++ b/arch/microblaze/include/asm/pci.h
> @@ -102,18 +102,6 @@ extern void pcibios_finish_adding_to_bus(struct pci_bus *bus);
>
> extern void pcibios_resource_survey(void);
>
> -extern struct pci_controller *init_phb_dynamic(struct device_node *dn);
> -extern int remove_phb_dynamic(struct pci_controller *phb);
> -
> -extern struct pci_dev *of_create_pci_dev(struct device_node *node,
> - struct pci_bus *bus, int devfn);
> -
> -extern void of_scan_pci_bridge(struct device_node *node,
> - struct pci_dev *dev);
> -
> -extern void of_scan_bus(struct device_node *node, struct pci_bus *bus);
> -extern void of_rescan_bus(struct device_node *node, struct pci_bus *bus);
> -
> extern int pci_bus_find_capability(struct pci_bus *bus,
> unsigned int devfn, int cap);
>
>
I think I should ignore this because you have sent another series where
this patch is included.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-06-05 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 19:57 [PATCH] microblaze/PCI: Remove unused declarations Bjorn Helgaas
2015-06-05 6:42 ` Michal Simek [this message]
2015-06-05 15:07 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557144CF.50500@monstr.eu \
--to=monstr@monstr.eu \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).