linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ray Jui <rjui@broadcom.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com"
	<bcm-kernel-feedback-list@broadcom.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Jon Mason <jonmason@broadcom.com>
Subject: Re: [PATCH v2 4/4] arm64: dts: Add Broadcom North Star 2 support
Date: Wed, 15 Jul 2015 10:30:56 -0700	[thread overview]
Message-ID: <55A698D0.3070203@broadcom.com> (raw)
In-Reply-To: <20150715092101.GB9627@leverpostej>



On 7/15/2015 2:21 AM, Mark Rutland wrote:
> Hi,
> 
>> +	chosen {
>> +		stdout-path = "serial0:115200n8";
>> +		bootargs = "earlycon=uart8250,mmio32,0x66130000";
>> +	};
> 
> You shouldn't need those earlycon arguments if your driver has
> of_earlycon support. If that's currently missing, could you add that
> instead?
> 
> Thanks,
> Mark.
> 

I can look into this and add the of_earlycon support for
8250_dw. It looks like it may be only a matter of hooking it up to the
setup function in 8250_early.c, which is quite straightforward.

So does it make more sense for me to do the following?
1) Drop the earlycon bootargs from ns2-svk.dts and continue the Broadcom
iProc arm64 upstreaming process with the current patch series
2) Start a separate, new patch series with OF_EARLYCON support to 8250
DW driver

Thanks,

Ray

      reply	other threads:[~2015-07-15 17:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  4:42 [PATCH v2 0/4] Add Broadcom North Star 2 support Ray Jui
2015-07-15  4:42 ` [PATCH v2 1/4] PCI: iproc: enable arm64 support for iProc PCIe Ray Jui
2015-07-15 21:52   ` Hauke Mehrtens
2015-07-15 21:57     ` Ray Jui
2015-07-15  4:42 ` [PATCH v2 2/4] PCI: iproc: Fix ARM64 dependency in Kconfig Ray Jui
2015-07-15  4:42 ` [PATCH v2 3/4] arm64: Add Broadcom iProc family support Ray Jui
2015-07-15 21:53   ` Hauke Mehrtens
2015-07-15 22:03     ` Ray Jui
2015-07-15 22:11       ` Florian Fainelli
2015-07-15  4:42 ` [PATCH v2 4/4] arm64: dts: Add Broadcom North Star 2 support Ray Jui
2015-07-15  9:21   ` Mark Rutland
2015-07-15 17:30     ` Ray Jui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A698D0.3070203@broadcom.com \
    --to=rjui@broadcom.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=hauke@hauke-m.de \
    --cc=jonmason@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).