* [PATCH] PCI / ACPI: Fix pci_acpi_optimize_delay() comment
@ 2015-07-15 9:29 Srinidhi Kasagar
2015-07-15 20:14 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Srinidhi Kasagar @ 2015-07-15 9:29 UTC (permalink / raw)
To: bhelgaas; +Cc: linux-pci
The function takes ACPI handle, not the device itself. Fix the
comment
Signed-off-by: Srinidhi Kasagar <srinidhi.kasagar@intel.com>
---
Add this as part of your trivial commenting fixes patch series
drivers/pci/pci-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index 6f6f175f51f7..d2e2bf4ef0a4 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -594,7 +594,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev)
/**
* pci_acpi_optimize_delay - optimize PCI D3 and D3cold delay from ACPI
* @pdev: the PCI device whose delay is to be updated
- * @adev: the companion ACPI device of this PCI device
+ * @handle: ACPI handle of this device
*
* Update the d3_delay and d3cold_delay of a PCI device from the ACPI _DSM
* control method of either the device itself or the PCI host bridge.
--
1.7.9.5
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI / ACPI: Fix pci_acpi_optimize_delay() comment
2015-07-15 9:29 [PATCH] PCI / ACPI: Fix pci_acpi_optimize_delay() comment Srinidhi Kasagar
@ 2015-07-15 20:14 ` Bjorn Helgaas
2015-07-16 1:24 ` Aaron Lu
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2015-07-15 20:14 UTC (permalink / raw)
To: Srinidhi Kasagar; +Cc: linux-pci, Aaron Lu
[+cc Aaron]
On Wed, Jul 15, 2015 at 02:59:46PM +0530, Srinidhi Kasagar wrote:
> The function takes ACPI handle, not the device itself. Fix the
> comment
>
> Signed-off-by: Srinidhi Kasagar <srinidhi.kasagar@intel.com>
Applied to pci/misc for v4.3, thanks!
> ---
> Add this as part of your trivial commenting fixes patch series
>
> drivers/pci/pci-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index 6f6f175f51f7..d2e2bf4ef0a4 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -594,7 +594,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev)
> /**
> * pci_acpi_optimize_delay - optimize PCI D3 and D3cold delay from ACPI
> * @pdev: the PCI device whose delay is to be updated
> - * @adev: the companion ACPI device of this PCI device
> + * @handle: ACPI handle of this device
> *
> * Update the d3_delay and d3cold_delay of a PCI device from the ACPI _DSM
> * control method of either the device itself or the PCI host bridge.
> --
> 1.7.9.5
>
>
> --
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI / ACPI: Fix pci_acpi_optimize_delay() comment
2015-07-15 20:14 ` Bjorn Helgaas
@ 2015-07-16 1:24 ` Aaron Lu
0 siblings, 0 replies; 3+ messages in thread
From: Aaron Lu @ 2015-07-16 1:24 UTC (permalink / raw)
To: Bjorn Helgaas, Srinidhi Kasagar; +Cc: linux-pci
On 07/16/2015 04:14 AM, Bjorn Helgaas wrote:
> [+cc Aaron]
>
> On Wed, Jul 15, 2015 at 02:59:46PM +0530, Srinidhi Kasagar wrote:
>> The function takes ACPI handle, not the device itself. Fix the
>> comment
I must have overlooked the comment while changing the function
prototype, thanks for the fix!
Regards,
Aaron
>>
>> Signed-off-by: Srinidhi Kasagar <srinidhi.kasagar@intel.com>
>
> Applied to pci/misc for v4.3, thanks!
>
>> ---
>> Add this as part of your trivial commenting fixes patch series
>>
>> drivers/pci/pci-acpi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
>> index 6f6f175f51f7..d2e2bf4ef0a4 100644
>> --- a/drivers/pci/pci-acpi.c
>> +++ b/drivers/pci/pci-acpi.c
>> @@ -594,7 +594,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev)
>> /**
>> * pci_acpi_optimize_delay - optimize PCI D3 and D3cold delay from ACPI
>> * @pdev: the PCI device whose delay is to be updated
>> - * @adev: the companion ACPI device of this PCI device
>> + * @handle: ACPI handle of this device
>> *
>> * Update the d3_delay and d3cold_delay of a PCI device from the ACPI _DSM
>> * control method of either the device itself or the PCI host bridge.
>> --
>> 1.7.9.5
>>
>>
>> --
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-16 1:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-15 9:29 [PATCH] PCI / ACPI: Fix pci_acpi_optimize_delay() comment Srinidhi Kasagar
2015-07-15 20:14 ` Bjorn Helgaas
2015-07-16 1:24 ` Aaron Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).