From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bh-25.webhostbox.net ([208.91.199.152]:57126 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752622AbbG2UC2 (ORCPT ); Wed, 29 Jul 2015 16:02:28 -0400 Message-ID: <55B93151.8040608@roeck-us.net> Date: Wed, 29 Jul 2015 13:02:25 -0700 From: Guenter Roeck MIME-Version: 1.0 To: Yinghai Lu CC: Bjorn Helgaas , "linux-pci@vger.kernel.org" , Lorenzo Pieralisi Subject: Re: [RFC PATCH v2] PCI: Only enable IO window if supported References: <1436292680-25111-1-git-send-email-linux@roeck-us.net> <20150729160903.GD31170@google.com> <55B92DA5.4030409@roeck-us.net> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 07/29/2015 12:53 PM, Yinghai Lu wrote: > On Wed, Jul 29, 2015 at 12:46 PM, Guenter Roeck wrote: >> On 07/29/2015 12:30 PM, Yinghai Lu wrote: >> >>> >>> so PCI_BUS_FLAGS_SUPPORTS_IO will never get set. >>> >> >> excellent catch. Unfortunately, I don't know how to make it >> work with the reversed flag. The idea here was that the flag >> propagates from parent to child. This makes sense for an >> "it doesn't work" flag to be inherited from the child, >> but not for an "it works" flag. >> > > also would be better if we can add has_ioport in hostbridge instead. > like has_mem64 in https://patchwork.ozlabs.org/patch/500926/ > and use > > to_pci_host_bridge(bus->bridge)->has_ioport > > to replace pci_root_has_io_resource() > Sure, that would make sense. Bjorn, how do you want to handle the flag problem ? Do you have an idea on how to make it work with the reversed definition ? Thanks, Guenter