Re: next-20150806 build: 2 failures 52 warnings (next-20150806)

Re: next-20150806 build: 2 failures 52 warnings (next-20150806)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

On Thu, Aug 06, 2015 at 12:00:47PM +0100, Build bot for Mark Brown wrote:

Today's linux-next fails to build an ARM allmodconfig due to:

> ../drivers/pci/host/pcie-xilinx.c:235:3: error: implicit declaration of function 'msi_desc_to_pci_sys_data' [-Werror=implicit-function-declaration]

msi_desc_to_pci_sys_data doesn't appear to exist anywhere else in
current -next, the usage was introduced by e39758e0ea769e632e (PCI: Use
helper functions to access fields in struct msi_desc) at which time it
looks like it did exist but I can't immediately see where it was removed.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: next-20150806 build: 2 failures 52 warnings (next-20150806)

[Stephen Rothwell]

Hi Mark,

On Thu, 6 Aug 2015 18:53:22 +0100 Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Aug 06, 2015 at 12:00:47PM +0100, Build bot for Mark Brown wrote:
> 
> Today's linux-next fails to build an ARM allmodconfig due to:
> 
> > ../drivers/pci/host/pcie-xilinx.c:235:3: error: implicit declaration of function 'msi_desc_to_pci_sys_data' [-Werror=implicit-function-declaration]
> 
> msi_desc_to_pci_sys_data doesn't appear to exist anywhere else in
> current -next, the usage was introduced by e39758e0ea769e632e (PCI: Use
> helper functions to access fields in struct msi_desc) at which time it
> looks like it did exist but I can't immediately see where it was removed.

Actually, it is a typo ... all other uses are spelt msi_desc_to_pci_sysdata.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: next-20150806 build: 2 failures 52 warnings (next-20150806)

[Jiang Liu]

On 2015/8/7 5:39, Stephen Rothwell wrote:
> Hi Mark,
> 
> On Thu, 6 Aug 2015 18:53:22 +0100 Mark Brown <broonie@kernel.org> wrote:
>>
>> On Thu, Aug 06, 2015 at 12:00:47PM +0100, Build bot for Mark Brown wrote:
>>
>> Today's linux-next fails to build an ARM allmodconfig due to:
>>
>>> ../drivers/pci/host/pcie-xilinx.c:235:3: error: implicit declaration of function 'msi_desc_to_pci_sys_data' [-Werror=implicit-function-declaration]
>>
>> msi_desc_to_pci_sys_data doesn't appear to exist anywhere else in
>> current -next, the usage was introduced by e39758e0ea769e632e (PCI: Use
>> helper functions to access fields in struct msi_desc) at which time it
>> looks like it did exist but I can't immediately see where it was removed.
> 
> Actually, it is a typo ... all other uses are spelt msi_desc_to_pci_sysdata.
Hi Mark and Stephen,
	Sorry for this, it's a typo. Should I send a patch to fix this
issue or is there some other quick ways to get this fixed?
Thanks!
Gerry

Re: next-20150806 build: 2 failures 52 warnings (next-20150806)

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

On Fri, Aug 07, 2015 at 07:39:54AM +1000, Stephen Rothwell wrote:
> On Thu, 6 Aug 2015 18:53:22 +0100 Mark Brown <broonie@kernel.org> wrote:

> > msi_desc_to_pci_sys_data doesn't appear to exist anywhere else in
> > current -next, the usage was introduced by e39758e0ea769e632e (PCI: Use
> > helper functions to access fields in struct msi_desc) at which time it
> > looks like it did exist but I can't immediately see where it was removed.

> Actually, it is a typo ... all other uses are spelt msi_desc_to_pci_sysdata.

Oh, that explains why it was so difficult to see where it was broken.
All the spinlock breakage for the past week masked other things so it
looked like it'd been added then later broken :/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: next-20150806 build: 2 failures 52 warnings (next-20150806)

[Bjorn Helgaas]

On Fri, Aug 7, 2015 at 4:49 AM, Mark Brown <broonie@kernel.org> wrote:
> On Fri, Aug 07, 2015 at 07:39:54AM +1000, Stephen Rothwell wrote:
>> On Thu, 6 Aug 2015 18:53:22 +0100 Mark Brown <broonie@kernel.org> wrote:
>
>> > msi_desc_to_pci_sys_data doesn't appear to exist anywhere else in
>> > current -next, the usage was introduced by e39758e0ea769e632e (PCI: Use
>> > helper functions to access fields in struct msi_desc) at which time it
>> > looks like it did exist but I can't immediately see where it was removed.
>
>> Actually, it is a typo ... all other uses are spelt msi_desc_to_pci_sysdata.

c179c9b978b9 ("PCI: Add helper function msi_desc_to_pci_sysdata()")
added msi_desc_to_pci_sysdata().

e39758e0ea76 ("PCI: Use helper functions to access fields in struct
msi_desc") added calls to msi_desc_to_pci_sysdata() in
pci-keystone-dw.c and pcie-designware.c, but to
msi_desc_to_pci_sys_data() (note extra "_") in pcie-xilinx.c.

These were both merged by Thomas, so I assume he and Jiang will sort this out.

Bjorn

Re: next-20150806 build: 2 failures 52 warnings (next-20150806)

[Jiang Liu]

On 2015/8/11 2:31, Bjorn Helgaas wrote:
> On Fri, Aug 7, 2015 at 4:49 AM, Mark Brown <broonie@kernel.org> wrote:
>> On Fri, Aug 07, 2015 at 07:39:54AM +1000, Stephen Rothwell wrote:
>>> On Thu, 6 Aug 2015 18:53:22 +0100 Mark Brown <broonie@kernel.org> wrote:
>>
>>>> msi_desc_to_pci_sys_data doesn't appear to exist anywhere else in
>>>> current -next, the usage was introduced by e39758e0ea769e632e (PCI: Use
>>>> helper functions to access fields in struct msi_desc) at which time it
>>>> looks like it did exist but I can't immediately see where it was removed.
>>
>>> Actually, it is a typo ... all other uses are spelt msi_desc_to_pci_sysdata.
> 
> c179c9b978b9 ("PCI: Add helper function msi_desc_to_pci_sysdata()")
> added msi_desc_to_pci_sysdata().
> 
> e39758e0ea76 ("PCI: Use helper functions to access fields in struct
> msi_desc") added calls to msi_desc_to_pci_sysdata() in
> pci-keystone-dw.c and pcie-designware.c, but to
> msi_desc_to_pci_sys_data() (note extra "_") in pcie-xilinx.c.
> 
> These were both merged by Thomas, so I assume he and Jiang will sort this out.
Hi Bjorn and Mark,
	Thomas is on vocation this two weeks, so I will send him a
patch to fix this issue once Thomas is back.
Thanks!
Gerry

Re: next-20150806 build: 2 failures 52 warnings (next-20150806)

[Thomas Gleixner]

On Wed, 12 Aug 2015, Jiang Liu wrote:
> On 2015/8/11 2:31, Bjorn Helgaas wrote:
> > On Fri, Aug 7, 2015 at 4:49 AM, Mark Brown <broonie@kernel.org> wrote:
> >> On Fri, Aug 07, 2015 at 07:39:54AM +1000, Stephen Rothwell wrote:
> >>> On Thu, 6 Aug 2015 18:53:22 +0100 Mark Brown <broonie@kernel.org> wrote:
> >>
> >>>> msi_desc_to_pci_sys_data doesn't appear to exist anywhere else in
> >>>> current -next, the usage was introduced by e39758e0ea769e632e (PCI: Use
> >>>> helper functions to access fields in struct msi_desc) at which time it
> >>>> looks like it did exist but I can't immediately see where it was removed.
> >>
> >>> Actually, it is a typo ... all other uses are spelt msi_desc_to_pci_sysdata.
> > 
> > c179c9b978b9 ("PCI: Add helper function msi_desc_to_pci_sysdata()")
> > added msi_desc_to_pci_sysdata().
> > 
> > e39758e0ea76 ("PCI: Use helper functions to access fields in struct
> > msi_desc") added calls to msi_desc_to_pci_sysdata() in
> > pci-keystone-dw.c and pcie-designware.c, but to
> > msi_desc_to_pci_sys_data() (note extra "_") in pcie-xilinx.c.
> > 
> > These were both merged by Thomas, so I assume he and Jiang will sort this out.
> Hi Bjorn and Mark,
> 	Thomas is on vocation this two weeks, so I will send him a
> patch to fix this issue once Thomas is back.

I'm back :)

[Bugfix] PCI: Fix a typo in file pcie-xilinx.c caused by commit e39758e0ea76

[Jiang Liu]

There's a typo in commit e39758e0ea76 ("PCI: Use helper functions to access
fields in struct msi_desc") in linux-next, which incorrectly spells
"msi_desc_to_pci_sysdata()" as "msi_desc_to_pci_sys_data()" and causes
buidling failure:
> ../drivers/pci/host/pcie-xilinx.c:235:3: error: implicit declaration of function 'msi_desc_to_pci_sys_data' [-Werror=implicit-function-declaration]

Links: https://lkml.org/lkml/2015/7/9/100

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
 drivers/pci/host/pcie-xilinx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
index 64454f416639..be494e46bbd1 100644
--- a/drivers/pci/host/pcie-xilinx.c
+++ b/drivers/pci/host/pcie-xilinx.c
@@ -232,7 +232,7 @@ static void xilinx_pcie_destroy_msi(unsigned int irq)
 
 	if (!test_bit(irq, msi_irq_in_use)) {
 		msi = irq_get_msi_desc(irq);
-		port = sys_to_pcie(msi_desc_to_pci_sys_data(msi));
+		port = sys_to_pcie(msi_desc_to_pci_sysdata(msi));
 		dev_err(port->dev, "Trying to free unused MSI#%d\n", irq);
 	} else {
 		clear_bit(irq, msi_irq_in_use);
-- 
1.7.10.4