* Re: linux-next: Tree for Aug 12 (include/linux/pci.h)
[not found] <20150812233914.451d1fcf@canb.auug.org.au>
@ 2015-08-12 18:05 ` Randy Dunlap
2015-08-12 21:53 ` Stephen Rothwell
0 siblings, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2015-08-12 18:05 UTC (permalink / raw)
To: Stephen Rothwell, linux-next; +Cc: linux-kernel, linux-pci
On 08/12/15 06:39, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20150810:
>
on i386 or x86_64:
Many (repeated) errors like this one:
../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’
when CONFIG_PCI_ATS is not enabled.
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Aug 12 (include/linux/pci.h)
2015-08-12 18:05 ` linux-next: Tree for Aug 12 (include/linux/pci.h) Randy Dunlap
@ 2015-08-12 21:53 ` Stephen Rothwell
2015-08-12 22:58 ` Tadeusz Struk
2015-08-12 23:22 ` Randy Dunlap
0 siblings, 2 replies; 8+ messages in thread
From: Stephen Rothwell @ 2015-08-12 21:53 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-next, linux-kernel, linux-pci, Tadeusz Struk, Herbert Xu,
Michal Marek
Hi Randy,
On Wed, 12 Aug 2015 11:05:36 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> on i386 or x86_64:
>
> Many (repeated) errors like this one:
>
> ../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’
>
> when CONFIG_PCI_ATS is not enabled.
Maybe caused by commit
dd0f368398ea ("crypto: qat - Add qat dh895xcc VF driver")
from the crypto tree Which adds a
select PCI_IOV
to drivers/crypto/qat/Kconfig without the necessary
select PCI
but PCI_IOV selects PCI_ATS, so I am not sure what happened here. I am
assuming that your config has PCI_IOV enabled? What about PCI?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Aug 12 (include/linux/pci.h)
2015-08-12 21:53 ` Stephen Rothwell
@ 2015-08-12 22:58 ` Tadeusz Struk
2015-08-13 0:16 ` Randy Dunlap
2015-08-20 6:16 ` Bjorn Helgaas
2015-08-12 23:22 ` Randy Dunlap
1 sibling, 2 replies; 8+ messages in thread
From: Tadeusz Struk @ 2015-08-12 22:58 UTC (permalink / raw)
To: Stephen Rothwell, Randy Dunlap
Cc: linux-next, linux-kernel, linux-pci, Herbert Xu, Michal Marek
Hi,
On 08/12/2015 02:53 PM, Stephen Rothwell wrote:
> On Wed, 12 Aug 2015 11:05:36 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>> >
>> > on i386 or x86_64:
>> >
>> > Many (repeated) errors like this one:
>> >
>> > ../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’
>> >
>> > when CONFIG_PCI_ATS is not enabled.
> Maybe caused by commit
>
> dd0f368398ea ("crypto: qat - Add qat dh895xcc VF driver")
>
> from the crypto tree Which adds a
>
> select PCI_IOV
>
> to drivers/crypto/qat/Kconfig without the necessary
>
> select PCI
>
> but PCI_IOV selects PCI_ATS, so I am not sure what happened here. I am
> assuming that your config has PCI_IOV enabled? What about PCI?
There is a patch submitted, but not yet applied
https://patchwork.kernel.org/patch/6994171/
maybe it will help?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Aug 12 (include/linux/pci.h)
2015-08-12 21:53 ` Stephen Rothwell
2015-08-12 22:58 ` Tadeusz Struk
@ 2015-08-12 23:22 ` Randy Dunlap
1 sibling, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2015-08-12 23:22 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, linux-pci, Tadeusz Struk, Herbert Xu,
Michal Marek
On 08/12/15 14:53, Stephen Rothwell wrote:
> Hi Randy,
>
> On Wed, 12 Aug 2015 11:05:36 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> on i386 or x86_64:
>>
>> Many (repeated) errors like this one:
>>
>> ../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’
>>
>> when CONFIG_PCI_ATS is not enabled.
>
> Maybe caused by commit
>
> dd0f368398ea ("crypto: qat - Add qat dh895xcc VF driver")
>
> from the crypto tree Which adds a
>
> select PCI_IOV
>
> to drivers/crypto/qat/Kconfig without the necessary
>
> select PCI
>
> but PCI_IOV selects PCI_ATS, so I am not sure what happened here. I am
> assuming that your config has PCI_IOV enabled? What about PCI?
>
CONFIG_PCI is not enabled in my failing configs.
Testing the patch now.
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Aug 12 (include/linux/pci.h)
2015-08-12 22:58 ` Tadeusz Struk
@ 2015-08-13 0:16 ` Randy Dunlap
2015-08-13 0:49 ` Stephen Rothwell
2015-08-20 6:16 ` Bjorn Helgaas
1 sibling, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2015-08-13 0:16 UTC (permalink / raw)
To: Tadeusz Struk, Stephen Rothwell
Cc: linux-next, linux-kernel, linux-pci, Herbert Xu, Michal Marek
On 08/12/15 15:58, Tadeusz Struk wrote:
> Hi,
> On 08/12/2015 02:53 PM, Stephen Rothwell wrote:
>> On Wed, 12 Aug 2015 11:05:36 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>>>>
>>>> on i386 or x86_64:
>>>>
>>>> Many (repeated) errors like this one:
>>>>
>>>> ../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’
>>>>
>>>> when CONFIG_PCI_ATS is not enabled.
>> Maybe caused by commit
>>
>> dd0f368398ea ("crypto: qat - Add qat dh895xcc VF driver")
>>
>> from the crypto tree Which adds a
>>
>> select PCI_IOV
>>
>> to drivers/crypto/qat/Kconfig without the necessary
>>
>> select PCI
>>
>> but PCI_IOV selects PCI_ATS, so I am not sure what happened here. I am
>> assuming that your config has PCI_IOV enabled? What about PCI?
>
> There is a patch submitted, but not yet applied
> https://patchwork.kernel.org/patch/6994171/
> maybe it will help?
Yes, that works for me. Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Aug 12 (include/linux/pci.h)
2015-08-13 0:16 ` Randy Dunlap
@ 2015-08-13 0:49 ` Stephen Rothwell
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2015-08-13 0:49 UTC (permalink / raw)
To: Randy Dunlap
Cc: Tadeusz Struk, linux-next, linux-kernel, linux-pci, Herbert Xu,
Michal Marek
Hi Randy,
On Wed, 12 Aug 2015 17:16:39 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 08/12/15 15:58, Tadeusz Struk wrote:
> > Hi,
> > On 08/12/2015 02:53 PM, Stephen Rothwell wrote:
> >> On Wed, 12 Aug 2015 11:05:36 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> >>>>
> >>>> on i386 or x86_64:
> >>>>
> >>>> Many (repeated) errors like this one:
> >>>>
> >>>> ../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’
> >>>>
> >>>> when CONFIG_PCI_ATS is not enabled.
> >> Maybe caused by commit
> >>
> >> dd0f368398ea ("crypto: qat - Add qat dh895xcc VF driver")
> >>
> >> from the crypto tree Which adds a
> >>
> >> select PCI_IOV
> >>
> >> to drivers/crypto/qat/Kconfig without the necessary
> >>
> >> select PCI
> >>
> >> but PCI_IOV selects PCI_ATS, so I am not sure what happened here. I am
> >> assuming that your config has PCI_IOV enabled? What about PCI?
> >
> > There is a patch submitted, but not yet applied
> > https://patchwork.kernel.org/patch/6994171/
> > maybe it will help?
>
> Yes, that works for me. Thanks.
Thanks for doing that.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Aug 12 (include/linux/pci.h)
2015-08-12 22:58 ` Tadeusz Struk
2015-08-13 0:16 ` Randy Dunlap
@ 2015-08-20 6:16 ` Bjorn Helgaas
2015-08-20 6:18 ` Stephen Rothwell
1 sibling, 1 reply; 8+ messages in thread
From: Bjorn Helgaas @ 2015-08-20 6:16 UTC (permalink / raw)
To: Tadeusz Struk
Cc: Stephen Rothwell, Randy Dunlap, linux-next list,
linux-kernel@vger.kernel.org, linux-pci, Herbert Xu, Michal Marek,
Yann E. MORIN, linux-kbuild
[+cc Yann, linux-kbuild]
On Wed, Aug 12, 2015 at 3:58 PM, Tadeusz Struk <tadeusz.struk@intel.com> wrote:
> On 08/12/2015 02:53 PM, Stephen Rothwell wrote:
>> On Wed, 12 Aug 2015 11:05:36 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>>> >
>>> > on i386 or x86_64:
>>> >
>>> > Many (repeated) errors like this one:
>>> >
>>> > ../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’
>>> >
>>> > when CONFIG_PCI_ATS is not enabled.
>> Maybe caused by commit
>>
>> dd0f368398ea ("crypto: qat - Add qat dh895xcc VF driver")
>>
>> from the crypto tree Which adds a
>>
>> select PCI_IOV
>>
>> to drivers/crypto/qat/Kconfig without the necessary
>>
>> select PCI
>>
>> but PCI_IOV selects PCI_ATS, so I am not sure what happened here. I am
>> assuming that your config has PCI_IOV enabled? What about PCI?
>
> There is a patch submitted, but not yet applied
> https://patchwork.kernel.org/patch/6994171/
> maybe it will help?
I don't understand this. In drivers/pci/Kconfig, we have:
config PCI_IOV
depends on PCI
and in drivers/crypto/qat/Kconfig, dd0f368398ea adds:
config CRYPTO_DEV_QAT_DH895xCCVF
select PCI_IOV
And apparently it's possible to end up with a .config with
CONFIG_PCI_IOV=y but CONFIG_PCI is not set? That seems wrong, since
we declared that PCI_IOV depends on PCI. Does select ignore that
dependency somehow?
Bjorn
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: linux-next: Tree for Aug 12 (include/linux/pci.h)
2015-08-20 6:16 ` Bjorn Helgaas
@ 2015-08-20 6:18 ` Stephen Rothwell
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2015-08-20 6:18 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Tadeusz Struk, Randy Dunlap, linux-next list,
linux-kernel@vger.kernel.org, linux-pci, Herbert Xu, Michal Marek,
Yann E. MORIN, linux-kbuild
Hi Bjorn,
On Wed, 19 Aug 2015 23:16:06 -0700 Bjorn Helgaas <bhelgaas@google.com> wrote:
>
> [+cc Yann, linux-kbuild]
>
> On Wed, Aug 12, 2015 at 3:58 PM, Tadeusz Struk <tadeusz.struk@intel.com> wrote:
> > On 08/12/2015 02:53 PM, Stephen Rothwell wrote:
> >> On Wed, 12 Aug 2015 11:05:36 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> >>> >
> >>> > on i386 or x86_64:
> >>> >
> >>> > Many (repeated) errors like this one:
> >>> >
> >>> > ../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’
> >>> >
> >>> > when CONFIG_PCI_ATS is not enabled.
> >> Maybe caused by commit
> >>
> >> dd0f368398ea ("crypto: qat - Add qat dh895xcc VF driver")
> >>
> >> from the crypto tree Which adds a
> >>
> >> select PCI_IOV
> >>
> >> to drivers/crypto/qat/Kconfig without the necessary
> >>
> >> select PCI
> >>
> >> but PCI_IOV selects PCI_ATS, so I am not sure what happened here. I am
> >> assuming that your config has PCI_IOV enabled? What about PCI?
> >
> > There is a patch submitted, but not yet applied
> > https://patchwork.kernel.org/patch/6994171/
> > maybe it will help?
>
> I don't understand this. In drivers/pci/Kconfig, we have:
>
> config PCI_IOV
> depends on PCI
>
> and in drivers/crypto/qat/Kconfig, dd0f368398ea adds:
>
> config CRYPTO_DEV_QAT_DH895xCCVF
> select PCI_IOV
>
> And apparently it's possible to end up with a .config with
> CONFIG_PCI_IOV=y but CONFIG_PCI is not set? That seems wrong, since
> we declared that PCI_IOV depends on PCI. Does select ignore that
> dependency somehow?
Yeah, unfortunately that is how select works. If a symbol you select
depends on anything, then you need to also select all the dependencies.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-08-20 6:18 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150812233914.451d1fcf@canb.auug.org.au>
2015-08-12 18:05 ` linux-next: Tree for Aug 12 (include/linux/pci.h) Randy Dunlap
2015-08-12 21:53 ` Stephen Rothwell
2015-08-12 22:58 ` Tadeusz Struk
2015-08-13 0:16 ` Randy Dunlap
2015-08-13 0:49 ` Stephen Rothwell
2015-08-20 6:16 ` Bjorn Helgaas
2015-08-20 6:18 ` Stephen Rothwell
2015-08-12 23:22 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).