From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e24smtp04.br.ibm.com ([32.104.18.25]:54077 "EHLO e24smtp04.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbbIGXIG (ORCPT ); Mon, 7 Sep 2015 19:08:06 -0400 Received: from /spool/local by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Sep 2015 20:08:03 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 8FEED352008C for ; Mon, 7 Sep 2015 19:06:53 -0400 (EDT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay02.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t87N6CQt23658774 for ; Mon, 7 Sep 2015 20:06:13 -0300 Received: from d24av05.br.ibm.com (localhost [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t87N7w7Q024508 for ; Mon, 7 Sep 2015 19:08:00 -0400 Subject: Re: [PATCH v2 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case To: Michael Ellerman , Bjorn Helgaas References: <1439932430-13375-3-git-send-email-gpiccoli@linux.vnet.ibm.com> <1439932077-11427-3-git-send-email-gpiccoli@linux.vnet.ibm.com> <1440010450-4549-1-git-send-email-gpiccoli@linux.vnet.ibm.com> <20150903175624.GI829@google.com> <1441595403.12945.3.camel@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, gwshan@linux.vnet.ibm.com, benh@kernel.crashing.org, paulus@samba.org, mst@redhat.com, Fam Zheng , Yinghai Lu , Yijing Wang , "Eric W. Biederman" , "David S. Miller" From: "Guilherme G. Piccoli" Message-ID: <55EE18CD.1060803@linux.vnet.ibm.com> Date: Mon, 7 Sep 2015 20:07:57 -0300 MIME-Version: 1.0 In-Reply-To: <1441595403.12945.3.camel@ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 09/07/2015 12:10 AM, Michael Ellerman wrote: >> But we later removed pci_msi_off() completely, so I think we probably >> *could* call pci_msi_setup_pci_dev() from pci_init_capabilities(). >> >> That would be much nicer because it makes more sense there, and it >> would do the right thing for powerpc and sparc because they both >> already use that path. > > Sounds reasonable to me. > > Guilherme can you please try this and let us know. Sure Michael. I tested in pSeries and PowerNV and both worked. Couldn't test on SPARC. Cheers