From: Murali Karicheri <m-karicheri2@ti.com>
To: <jingoohan1@gmail.com>, <pratyush.anand@gmail.com>,
<bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space
Date: Wed, 23 Sep 2015 17:00:39 -0400 [thread overview]
Message-ID: <560312F7.3000001@ti.com> (raw)
In-Reply-To: <55BA47E0.9030003@ti.com>
On 07/30/2015 11:50 AM, Murali Karicheri wrote:
> On 07/21/2015 05:54 PM, Murali Karicheri wrote:
>> Currently on Keystone SoCs, boot up log shows an unnecessary boot
>> noise as follows:-
>>
>> [ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space
>>
>> Keystone uses older version of designware h/w that doesn't have ATU
>> support. So va_cfg0_base and va_cfg1_base are already set up in
>> ks_dw_pcie_host_init() before calling dw_pcie_host_init() and
>> they point to the remote config space address va (both same for
>> Keystone).
>> So add a check to avoid this boot noise on Keystone.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>> - Resend with "PCI: designware" prefix in subject
>> drivers/pci/host/pcie-designware.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/host/pcie-designware.c
>> b/drivers/pci/host/pcie-designware.c
>> index 69486be..b48b8a2 100644
>> --- a/drivers/pci/host/pcie-designware.c
>> +++ b/drivers/pci/host/pcie-designware.c
>> @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
>> addrp = of_get_address(np, index, NULL, NULL);
>> pp->cfg0_mod_base = of_read_number(addrp, ns);
>> pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size;
>> - } else {
>> + } else if (!pp->va_cfg0_base) {
>> dev_err(pp->dev, "missing *config* reg space\n");
>> }
>>
>>
> A gentle ping to review and apply this to pci next.
>
Bjorn,
Not sure why this is not picked for merge. Can you pick this up please!
--
Murali Karicheri
Linux Kernel, Keystone
next prev parent reply other threads:[~2015-09-23 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 21:54 [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space Murali Karicheri
2015-07-30 15:50 ` Murali Karicheri
2015-09-23 21:00 ` Murali Karicheri [this message]
2015-07-31 8:18 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560312F7.3000001@ti.com \
--to=m-karicheri2@ti.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pratyush.anand@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).