* [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space
@ 2015-07-21 21:54 Murali Karicheri
2015-07-30 15:50 ` Murali Karicheri
2015-07-31 8:18 ` Jingoo Han
0 siblings, 2 replies; 4+ messages in thread
From: Murali Karicheri @ 2015-07-21 21:54 UTC (permalink / raw)
To: jingoohan1, pratyush.anand, bhelgaas, linux-pci, linux-kernel
Currently on Keystone SoCs, boot up log shows an unnecessary boot
noise as follows:-
[ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space
Keystone uses older version of designware h/w that doesn't have ATU
support. So va_cfg0_base and va_cfg1_base are already set up in
ks_dw_pcie_host_init() before calling dw_pcie_host_init() and
they point to the remote config space address va (both same for Keystone).
So add a check to avoid this boot noise on Keystone.
Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
- Resend with "PCI: designware" prefix in subject
drivers/pci/host/pcie-designware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 69486be..b48b8a2 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
addrp = of_get_address(np, index, NULL, NULL);
pp->cfg0_mod_base = of_read_number(addrp, ns);
pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size;
- } else {
+ } else if (!pp->va_cfg0_base) {
dev_err(pp->dev, "missing *config* reg space\n");
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space
2015-07-21 21:54 [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space Murali Karicheri
@ 2015-07-30 15:50 ` Murali Karicheri
2015-09-23 21:00 ` Murali Karicheri
2015-07-31 8:18 ` Jingoo Han
1 sibling, 1 reply; 4+ messages in thread
From: Murali Karicheri @ 2015-07-30 15:50 UTC (permalink / raw)
To: jingoohan1, pratyush.anand, bhelgaas, linux-pci, linux-kernel
On 07/21/2015 05:54 PM, Murali Karicheri wrote:
> Currently on Keystone SoCs, boot up log shows an unnecessary boot
> noise as follows:-
>
> [ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space
>
> Keystone uses older version of designware h/w that doesn't have ATU
> support. So va_cfg0_base and va_cfg1_base are already set up in
> ks_dw_pcie_host_init() before calling dw_pcie_host_init() and
> they point to the remote config space address va (both same for Keystone).
> So add a check to avoid this boot noise on Keystone.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> ---
> - Resend with "PCI: designware" prefix in subject
> drivers/pci/host/pcie-designware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 69486be..b48b8a2 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
> addrp = of_get_address(np, index, NULL, NULL);
> pp->cfg0_mod_base = of_read_number(addrp, ns);
> pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size;
> - } else {
> + } else if (!pp->va_cfg0_base) {
> dev_err(pp->dev, "missing *config* reg space\n");
> }
>
>
A gentle ping to review and apply this to pci next.
--
Murali Karicheri
Linux Kernel, Keystone
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space
2015-07-21 21:54 [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space Murali Karicheri
2015-07-30 15:50 ` Murali Karicheri
@ 2015-07-31 8:18 ` Jingoo Han
1 sibling, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2015-07-31 8:18 UTC (permalink / raw)
To: Murali Karicheri
Cc: <pratyush.anand@gmail.com>, <bhelgaas@google.com>,
<linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, jingoohan1
On 2015. 7. 22., at AM 6:54, Murali Karicheri <m-karicheri2@ti.com> wrote:
>
> Currently on Keystone SoCs, boot up log shows an unnecessary boot
> noise as follows:-
>
> [ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space
>
> Keystone uses older version of designware h/w that doesn't have ATU
> support. So va_cfg0_base and va_cfg1_base are already set up in
> ks_dw_pcie_host_init() before calling dw_pcie_host_init() and
> they point to the remote config space address va (both same for Keystone).
> So add a check to avoid this boot noise on Keystone.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
> ---
> - Resend with "PCI: designware" prefix in subject
> drivers/pci/host/pcie-designware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 69486be..b48b8a2 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
> addrp = of_get_address(np, index, NULL, NULL);
> pp->cfg0_mod_base = of_read_number(addrp, ns);
> pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size;
> - } else {
> + } else if (!pp->va_cfg0_base) {
> dev_err(pp->dev, "missing *config* reg space\n");
> }
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space
2015-07-30 15:50 ` Murali Karicheri
@ 2015-09-23 21:00 ` Murali Karicheri
0 siblings, 0 replies; 4+ messages in thread
From: Murali Karicheri @ 2015-09-23 21:00 UTC (permalink / raw)
To: jingoohan1, pratyush.anand, bhelgaas, linux-pci, linux-kernel
On 07/30/2015 11:50 AM, Murali Karicheri wrote:
> On 07/21/2015 05:54 PM, Murali Karicheri wrote:
>> Currently on Keystone SoCs, boot up log shows an unnecessary boot
>> noise as follows:-
>>
>> [ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space
>>
>> Keystone uses older version of designware h/w that doesn't have ATU
>> support. So va_cfg0_base and va_cfg1_base are already set up in
>> ks_dw_pcie_host_init() before calling dw_pcie_host_init() and
>> they point to the remote config space address va (both same for
>> Keystone).
>> So add a check to avoid this boot noise on Keystone.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>> - Resend with "PCI: designware" prefix in subject
>> drivers/pci/host/pcie-designware.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/host/pcie-designware.c
>> b/drivers/pci/host/pcie-designware.c
>> index 69486be..b48b8a2 100644
>> --- a/drivers/pci/host/pcie-designware.c
>> +++ b/drivers/pci/host/pcie-designware.c
>> @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
>> addrp = of_get_address(np, index, NULL, NULL);
>> pp->cfg0_mod_base = of_read_number(addrp, ns);
>> pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size;
>> - } else {
>> + } else if (!pp->va_cfg0_base) {
>> dev_err(pp->dev, "missing *config* reg space\n");
>> }
>>
>>
> A gentle ping to review and apply this to pci next.
>
Bjorn,
Not sure why this is not picked for merge. Can you pick this up please!
--
Murali Karicheri
Linux Kernel, Keystone
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-23 21:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-21 21:54 [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space Murali Karicheri
2015-07-30 15:50 ` Murali Karicheri
2015-09-23 21:00 ` Murali Karicheri
2015-07-31 8:18 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).