From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.11.231]:55758 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbaKDRFn convert rfc822-to-8bit (ORCPT ); Tue, 4 Nov 2014 12:05:43 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH] PCI: add missing DT binding for linux,pci-domain property From: Kumar Gala In-Reply-To: <1415101660-26450-1-git-send-email-l.stach@pengutronix.de> Date: Tue, 4 Nov 2014 11:05:39 -0600 Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , devicetree@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Liviu Dudau Message-Id: <560410DB-26D4-4921-BFEA-176A05DA06CB@codeaurora.org> References: <1415101660-26450-1-git-send-email-l.stach@pengutronix.de> To: Lucas Stach Sender: linux-pci-owner@vger.kernel.org List-ID: On Nov 4, 2014, at 5:47 AM, Lucas Stach wrote: > This property was added by 41e5c0f81d3e > (of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr()) > without the required binding documentation. As this property > will be supported by a number of host bridge drivers going forward, > add it to the common PCI binding doc. > > Signed-off-by: Lucas Stach > --- > This is a non-critical fix, but may still qualify for 3.18-rc as > the property was added in this release cycle. > --- > Documentation/devicetree/bindings/pci/pci.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt > index 41aeed38926d..b754f786ed5e 100644 > --- a/Documentation/devicetree/bindings/pci/pci.txt > +++ b/Documentation/devicetree/bindings/pci/pci.txt > @@ -7,3 +7,13 @@ And for the interrupt mapping part: > > Open Firmware Recommended Practice: Interrupt Mapping > http://www.openfirmware.org/1275/practice/imap/imap0_9d.pdf > + > +Additionally to the properties specified in the above standards a host bridge > +driver implementation may support the following properties: > + > +- linux,pci-domain: > + If present this property assigns a fixed PCI domain number to a host bridge, > + otherwise an unstable (across boots) unique number will be assigned. > + It is recommended to either not set this property at all or set it for all > + host bridges in the system, otherwise potentially conflicting domain numbers > + may be assigned to root buses behind different host bridges. Probably should add something about domain numbers being unique across all host bridgse. - k -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project