* [PATCH] ARM: keystone: dts: add PCI serdes driver bindings
@ 2015-10-21 12:57 WingMan Kwok
2015-10-21 15:14 ` Kwok, WingMan
2015-10-21 16:44 ` santosh.shilimkar
0 siblings, 2 replies; 7+ messages in thread
From: WingMan Kwok @ 2015-10-21 12:57 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, kishon,
rogerq, m-karicheri2, bhelgaas, ssantosh, linux, devicetree,
linux-kernel, linux-pci, linux-arm-kernel
Cc: WingMan Kwok
This patch adds the serdes phy driver dts bindings
for the keystone PCIe host driver.
Signed-off-by: WingMan Kwok <w-kwok2@ti.com>
---
arch/arm/boot/dts/k2e.dtsi | 10 ++++++++++
arch/arm/boot/dts/keystone.dtsi | 10 ++++++++++
2 files changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/k2e.dtsi b/arch/arm/boot/dts/k2e.dtsi
index 675fb8e..5f7cc0a 100644
--- a/arch/arm/boot/dts/k2e.dtsi
+++ b/arch/arm/boot/dts/k2e.dtsi
@@ -86,6 +86,15 @@
gpio,syscon-dev = <&devctrl 0x240>;
};
+ pcie1_phy: phy@2326000 {
+ #phy-cells = <0>;
+ compatible = "ti,keystone-serdes-pcie";
+ reg = <0x02326000 0x4000>;
+ link-rate-kbps = <5000000>;
+ num-lanes = <2>;
+ status = "disabled";
+ };
+
pcie1: pcie@21020000 {
compatible = "ti,keystone-pcie","snps,dw-pcie";
clocks = <&clkpcie1>;
@@ -99,6 +108,7 @@
status = "disabled";
device_type = "pci";
num-lanes = <2>;
+ phys = <&pcie1_phy>;
#interrupt-cells = <1>;
interrupt-map-mask = <0 0 0 7>;
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 72816d6..5c7c58a 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -275,6 +275,15 @@
ti,syscon-dev = <&devctrl 0x2a0>;
};
+ pcie0_phy: phy@2320000 {
+ #phy-cells = <0>;
+ compatible = "ti,keystone-serdes-pcie";
+ reg = <0x02320000 0x4000>;
+ link-rate-kbps = <5000000>;
+ num-lanes = <2>;
+ status = "disabled";
+ };
+
pcie0: pcie@21800000 {
compatible = "ti,keystone-pcie", "snps,dw-pcie";
clocks = <&clkpcie>;
@@ -288,6 +297,7 @@
status = "disabled";
device_type = "pci";
num-lanes = <2>;
+ phys = <&pcie0_phy>;
#interrupt-cells = <1>;
interrupt-map-mask = <0 0 0 7>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* RE: [PATCH] ARM: keystone: dts: add PCI serdes driver bindings
2015-10-21 12:57 [PATCH] ARM: keystone: dts: add PCI serdes driver bindings WingMan Kwok
@ 2015-10-21 15:14 ` Kwok, WingMan
2015-10-21 16:44 ` santosh.shilimkar
1 sibling, 0 replies; 7+ messages in thread
From: Kwok, WingMan @ 2015-10-21 15:14 UTC (permalink / raw)
To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
KISHON VIJAY ABRAHAM, Quadros, Roger, Karicheri, Muralidharan,
bhelgaas@google.com, ssantosh@kernel.org, linux@arm.linux.org.uk,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Kwok, WingMan
SGksDQoNClBsZWFzZSBpZ25vcmUgdGhlIHN1YmplY3QgcGF0Y2ggd2hpY2ggaXMgZXhhY3RseQ0K
dGhlIHNhbWUgYXMgdGhlIG9uZQ0KDQpbUEFUQ0ggdjFdIEFSTToga2V5c3RvbmU6IGR0czogYWRk
IFBDSSBzZXJkZXMgZHJpdmVyIGJpbmRpbmdzDQoNCnN1Ym1pdHRlZCBlYXJsaWVyLg0KDQpUaGFu
a3MsDQpXaW5nTWFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogS3dv
aywgV2luZ01hbg0KPiBTZW50OiBXZWRuZXNkYXksIE9jdG9iZXIgMjEsIDIwMTUgODo1NyBBTQ0K
PiBUbzogcm9iaCtkdEBrZXJuZWwub3JnOyBwYXdlbC5tb2xsQGFybS5jb207IG1hcmsucnV0bGFu
ZEBhcm0uY29tOw0KPiBpamMrZGV2aWNldHJlZUBoZWxsaW9uLm9yZy51azsgZ2FsYWtAY29kZWF1
cm9yYS5vcmc7IEtJU0hPTiBWSUpBWSBBQlJBSEFNOw0KPiBRdWFkcm9zLCBSb2dlcjsgS2FyaWNo
ZXJpLCBNdXJhbGlkaGFyYW47IGJoZWxnYWFzQGdvb2dsZS5jb207DQo+IHNzYW50b3NoQGtlcm5l
bC5vcmc7IGxpbnV4QGFybS5saW51eC5vcmcudWs7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3Jn
Ow0KPiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1wY2lAdmdlci5rZXJuZWwu
b3JnOyBsaW51eC1hcm0tDQo+IGtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnDQo+IENjOiBLd29r
LCBXaW5nTWFuDQo+IFN1YmplY3Q6IFtQQVRDSF0gQVJNOiBrZXlzdG9uZTogZHRzOiBhZGQgUENJ
IHNlcmRlcyBkcml2ZXIgYmluZGluZ3MNCj4gDQo+IFRoaXMgcGF0Y2ggYWRkcyB0aGUgc2VyZGVz
IHBoeSBkcml2ZXIgZHRzIGJpbmRpbmdzDQo+IGZvciB0aGUga2V5c3RvbmUgUENJZSBob3N0IGRy
aXZlci4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFdpbmdNYW4gS3dvayA8dy1rd29rMkB0aS5jb20+
DQo+IC0tLQ0KPiAgYXJjaC9hcm0vYm9vdC9kdHMvazJlLmR0c2kgICAgICB8ICAgMTAgKysrKysr
KysrKw0KPiAgYXJjaC9hcm0vYm9vdC9kdHMva2V5c3RvbmUuZHRzaSB8ICAgMTAgKysrKysrKysr
Kw0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspDQo+IA0KPiBkaWZmIC0tZ2l0
IGEvYXJjaC9hcm0vYm9vdC9kdHMvazJlLmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9rMmUuZHRz
aQ0KPiBpbmRleCA2NzVmYjhlLi41ZjdjYzBhIDEwMDY0NA0KPiAtLS0gYS9hcmNoL2FybS9ib290
L2R0cy9rMmUuZHRzaQ0KPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9rMmUuZHRzaQ0KPiBAQCAt
ODYsNiArODYsMTUgQEANCj4gIAkJCWdwaW8sc3lzY29uLWRldiA9IDwmZGV2Y3RybCAweDI0MD47
DQo+ICAJCX07DQo+IA0KPiArCQlwY2llMV9waHk6IHBoeUAyMzI2MDAwIHsNCj4gKwkJCSNwaHkt
Y2VsbHMgPSA8MD47DQo+ICsJCQljb21wYXRpYmxlID0gInRpLGtleXN0b25lLXNlcmRlcy1wY2ll
IjsNCj4gKwkJCXJlZyA9IDwweDAyMzI2MDAwIDB4NDAwMD47DQo+ICsJCQlsaW5rLXJhdGUta2Jw
cyA9IDw1MDAwMDAwPjsNCj4gKwkJCW51bS1sYW5lcyA9IDwyPjsNCj4gKwkJCXN0YXR1cyA9ICJk
aXNhYmxlZCI7DQo+ICsJCX07DQo+ICsNCj4gIAkJcGNpZTE6IHBjaWVAMjEwMjAwMDAgew0KPiAg
CQkJY29tcGF0aWJsZSA9ICJ0aSxrZXlzdG9uZS1wY2llIiwic25wcyxkdy1wY2llIjsNCj4gIAkJ
CWNsb2NrcyA9IDwmY2xrcGNpZTE+Ow0KPiBAQCAtOTksNiArMTA4LDcgQEANCj4gIAkJCXN0YXR1
cyA9ICJkaXNhYmxlZCI7DQo+ICAJCQlkZXZpY2VfdHlwZSA9ICJwY2kiOw0KPiAgCQkJbnVtLWxh
bmVzID0gPDI+Ow0KPiArCQkJcGh5cyA9IDwmcGNpZTFfcGh5PjsNCj4gDQo+ICAJCQkjaW50ZXJy
dXB0LWNlbGxzID0gPDE+Ow0KPiAgCQkJaW50ZXJydXB0LW1hcC1tYXNrID0gPDAgMCAwIDc+Ow0K
PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMva2V5c3RvbmUuZHRzaQ0KPiBiL2FyY2gv
YXJtL2Jvb3QvZHRzL2tleXN0b25lLmR0c2kNCj4gaW5kZXggNzI4MTZkNi4uNWM3YzU4YSAxMDA2
NDQNCj4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMva2V5c3RvbmUuZHRzaQ0KPiArKysgYi9hcmNo
L2FybS9ib290L2R0cy9rZXlzdG9uZS5kdHNpDQo+IEBAIC0yNzUsNiArMjc1LDE1IEBADQo+ICAJ
CQl0aSxzeXNjb24tZGV2ID0gPCZkZXZjdHJsIDB4MmEwPjsNCj4gIAkJfTsNCj4gDQo+ICsJCXBj
aWUwX3BoeTogcGh5QDIzMjAwMDAgew0KPiArCQkJI3BoeS1jZWxscyA9IDwwPjsNCj4gKwkJCWNv
bXBhdGlibGUgPSAidGksa2V5c3RvbmUtc2VyZGVzLXBjaWUiOw0KPiArCQkJcmVnID0gPDB4MDIz
MjAwMDAgMHg0MDAwPjsNCj4gKwkJCWxpbmstcmF0ZS1rYnBzID0gPDUwMDAwMDA+Ow0KPiArCQkJ
bnVtLWxhbmVzID0gPDI+Ow0KPiArCQkJc3RhdHVzID0gImRpc2FibGVkIjsNCj4gKwkJfTsNCj4g
Kw0KPiAgCQlwY2llMDogcGNpZUAyMTgwMDAwMCB7DQo+ICAJCQljb21wYXRpYmxlID0gInRpLGtl
eXN0b25lLXBjaWUiLCAic25wcyxkdy1wY2llIjsNCj4gIAkJCWNsb2NrcyA9IDwmY2xrcGNpZT47
DQo+IEBAIC0yODgsNiArMjk3LDcgQEANCj4gIAkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7DQo+ICAJ
CQlkZXZpY2VfdHlwZSA9ICJwY2kiOw0KPiAgCQkJbnVtLWxhbmVzID0gPDI+Ow0KPiArCQkJcGh5
cyA9IDwmcGNpZTBfcGh5PjsNCj4gDQo+ICAJCQkjaW50ZXJydXB0LWNlbGxzID0gPDE+Ow0KPiAg
CQkJaW50ZXJydXB0LW1hcC1tYXNrID0gPDAgMCAwIDc+Ow0KPiAtLQ0KPiAxLjcuOS41DQoNCg==
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: keystone: dts: add PCI serdes driver bindings
2015-10-21 12:57 [PATCH] ARM: keystone: dts: add PCI serdes driver bindings WingMan Kwok
2015-10-21 15:14 ` Kwok, WingMan
@ 2015-10-21 16:44 ` santosh.shilimkar
1 sibling, 0 replies; 7+ messages in thread
From: santosh.shilimkar @ 2015-10-21 16:44 UTC (permalink / raw)
To: WingMan Kwok, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, kishon, rogerq, m-karicheri2, bhelgaas, ssantosh, linux,
devicetree, linux-kernel, linux-pci, linux-arm-kernel
On 10/21/15 5:57 AM, WingMan Kwok wrote:
> This patch adds the serdes phy driver dts bindings
> for the keystone PCIe host driver.
>
> Signed-off-by: WingMan Kwok <w-kwok2@ti.com>
> ---
Keep me posted when driver gets merged. I will then
pick this up.
Regards,
Santosh
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: keystone: dts: add PCI serdes driver bindings
@ 2015-10-15 14:27 WingMan Kwok
2015-10-16 7:55 ` Roger Quadros
2015-11-24 23:43 ` Bjorn Helgaas
0 siblings, 2 replies; 7+ messages in thread
From: WingMan Kwok @ 2015-10-15 14:27 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, kishon,
rogerq, m-karicheri2, bhelgaas, ssantosh, linux, devicetree,
linux-kernel, linux-pci, linux-arm-kernel
Cc: WingMan Kwok
This patch adds the required PCI serdes bindings whcih can then be
enabled by setting the corresponding statuses to "ok" in order to
configure and start the PCI serdes.
This patch depends on the updates to the Keystone PCIe host driver
and common serdes driver patch series that is submitted separately.
Signed-off-by: WingMan Kwok <w-kwok2@ti.com>
---
arch/arm/boot/dts/k2e.dtsi | 21 +++++++++++++++++++++
arch/arm/boot/dts/keystone.dtsi | 21 +++++++++++++++++++++
2 files changed, 42 insertions(+)
diff --git a/arch/arm/boot/dts/k2e.dtsi b/arch/arm/boot/dts/k2e.dtsi
index 675fb8e..3b36575 100644
--- a/arch/arm/boot/dts/k2e.dtsi
+++ b/arch/arm/boot/dts/k2e.dtsi
@@ -86,6 +86,16 @@
gpio,syscon-dev = <&devctrl 0x240>;
};
+ pcie1_phy: pciephy@2326000 {
+ #phy-cells = <0>;
+ compatible = "ti,keystone-serdes-pcie";
+ reg = <0x02326000 0x4000>;
+ reg-names = "serdes";
+ link-rate-kbps = <5000000>;
+ num-lanes = <2>;
+ status = "disabled";
+ };
+
pcie1: pcie@21020000 {
compatible = "ti,keystone-pcie","snps,dw-pcie";
clocks = <&clkpcie1>;
@@ -130,6 +140,17 @@
<GIC_SPI 375 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 376 IRQ_TYPE_EDGE_RISING>;
};
+
+ /* PCIE phy */
+ serdeses {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ serdes@0 {
+ reg = <0>;
+ phys = <&pcie1_phy>;
+ };
+ };
+
};
mdio: mdio@24200f00 {
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index 72816d6..6566cc4 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -275,6 +275,16 @@
ti,syscon-dev = <&devctrl 0x2a0>;
};
+ pcie0_phy: pciephy@2320000 {
+ #phy-cells = <0>;
+ compatible = "ti,keystone-serdes-pcie";
+ reg = <0x02320000 0x4000>;
+ reg-names = "serdes";
+ link-rate-kbps = <5000000>;
+ num-lanes = <2>;
+ status = "disabled";
+ };
+
pcie0: pcie@21800000 {
compatible = "ti,keystone-pcie", "snps,dw-pcie";
clocks = <&clkpcie>;
@@ -319,6 +329,17 @@
<GIC_SPI 28 IRQ_TYPE_EDGE_RISING>,
<GIC_SPI 29 IRQ_TYPE_EDGE_RISING>;
};
+
+ /* PCIE phy */
+ serdeses {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ serdes@0 {
+ reg = <0>;
+ phys = <&pcie0_phy>;
+ };
+ };
+
};
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: keystone: dts: add PCI serdes driver bindings
2015-10-15 14:27 WingMan Kwok
@ 2015-10-16 7:55 ` Roger Quadros
2015-10-19 11:10 ` Kwok, WingMan
2015-11-24 23:43 ` Bjorn Helgaas
1 sibling, 1 reply; 7+ messages in thread
From: Roger Quadros @ 2015-10-16 7:55 UTC (permalink / raw)
To: WingMan Kwok, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, kishon, m-karicheri2, bhelgaas, ssantosh, linux,
devicetree, linux-kernel, linux-pci, linux-arm-kernel
WingMan,
On 15/10/15 17:27, WingMan Kwok wrote:
> This patch adds the required PCI serdes bindings whcih can then be
> enabled by setting the corresponding statuses to "ok" in order to
> configure and start the PCI serdes.
>
> This patch depends on the updates to the Keystone PCIe host driver
> and common serdes driver patch series that is submitted separately.
>
> Signed-off-by: WingMan Kwok <w-kwok2@ti.com>
> ---
> arch/arm/boot/dts/k2e.dtsi | 21 +++++++++++++++++++++
> arch/arm/boot/dts/keystone.dtsi | 21 +++++++++++++++++++++
> 2 files changed, 42 insertions(+)
>
> diff --git a/arch/arm/boot/dts/k2e.dtsi b/arch/arm/boot/dts/k2e.dtsi
> index 675fb8e..3b36575 100644
> --- a/arch/arm/boot/dts/k2e.dtsi
> +++ b/arch/arm/boot/dts/k2e.dtsi
> @@ -86,6 +86,16 @@
> gpio,syscon-dev = <&devctrl 0x240>;
> };
>
> + pcie1_phy: pciephy@2326000 {
Should be
pcie1_phy: phy@2326000 {
> + #phy-cells = <0>;
> + compatible = "ti,keystone-serdes-pcie";
> + reg = <0x02326000 0x4000>;
> + reg-names = "serdes";
> + link-rate-kbps = <5000000>;
> + num-lanes = <2>;
> + status = "disabled";
> + };
> +
> pcie1: pcie@21020000 {
> compatible = "ti,keystone-pcie","snps,dw-pcie";
> clocks = <&clkpcie1>;
> @@ -130,6 +140,17 @@
> <GIC_SPI 375 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 376 IRQ_TYPE_EDGE_RISING>;
> };
> +
> + /* PCIE phy */
> + serdeses {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + serdes@0 {
> + reg = <0>;
> + phys = <&pcie1_phy>;
> + };
> + };
> +
> };
>
> mdio: mdio@24200f00 {
> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
> index 72816d6..6566cc4 100644
> --- a/arch/arm/boot/dts/keystone.dtsi
> +++ b/arch/arm/boot/dts/keystone.dtsi
> @@ -275,6 +275,16 @@
> ti,syscon-dev = <&devctrl 0x2a0>;
> };
>
> + pcie0_phy: pciephy@2320000 {
ditto.
> + #phy-cells = <0>;
> + compatible = "ti,keystone-serdes-pcie";
> + reg = <0x02320000 0x4000>;
> + reg-names = "serdes";
> + link-rate-kbps = <5000000>;
> + num-lanes = <2>;
> + status = "disabled";
> + };
> +
> pcie0: pcie@21800000 {
> compatible = "ti,keystone-pcie", "snps,dw-pcie";
> clocks = <&clkpcie>;
> @@ -319,6 +329,17 @@
> <GIC_SPI 28 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 29 IRQ_TYPE_EDGE_RISING>;
> };
> +
> + /* PCIE phy */
> + serdeses {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + serdes@0 {
> + reg = <0>;
> + phys = <&pcie0_phy>;
> + };
> + };
> +
> };
> };
> };
>
--
cheers,
-roger
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH] ARM: keystone: dts: add PCI serdes driver bindings
2015-10-16 7:55 ` Roger Quadros
@ 2015-10-19 11:10 ` Kwok, WingMan
0 siblings, 0 replies; 7+ messages in thread
From: Kwok, WingMan @ 2015-10-19 11:10 UTC (permalink / raw)
To: Quadros, Roger, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, KISHON VIJAY ABRAHAM,
Karicheri, Muralidharan, bhelgaas@google.com, ssantosh@kernel.org,
linux@arm.linux.org.uk, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Um9nZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUXVhZHJvcywg
Um9nZXINCj4gU2VudDogRnJpZGF5LCBPY3RvYmVyIDE2LCAyMDE1IDM6NTYgQU0NCj4gVG86IEt3
b2ssIFdpbmdNYW47IHJvYmgrZHRAa2VybmVsLm9yZzsgcGF3ZWwubW9sbEBhcm0uY29tOw0KPiBt
YXJrLnJ1dGxhbmRAYXJtLmNvbTsgaWpjK2RldmljZXRyZWVAaGVsbGlvbi5vcmcudWs7IGdhbGFr
QGNvZGVhdXJvcmEub3JnOw0KPiBLSVNIT04gVklKQVkgQUJSQUhBTTsgS2FyaWNoZXJpLCBNdXJh
bGlkaGFyYW47IGJoZWxnYWFzQGdvb2dsZS5jb207DQo+IHNzYW50b3NoQGtlcm5lbC5vcmc7IGxp
bnV4QGFybS5saW51eC5vcmcudWs7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOw0KPiBsaW51
eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1wY2lAdmdlci5rZXJuZWwub3JnOyBsaW51
eC1hcm0tDQo+IGtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU
Q0hdIEFSTToga2V5c3RvbmU6IGR0czogYWRkIFBDSSBzZXJkZXMgZHJpdmVyIGJpbmRpbmdzDQo+
IA0KPiBXaW5nTWFuLA0KPiANCj4gT24gMTUvMTAvMTUgMTc6MjcsIFdpbmdNYW4gS3dvayB3cm90
ZToNCj4gPiBUaGlzIHBhdGNoIGFkZHMgdGhlIHJlcXVpcmVkIFBDSSBzZXJkZXMgYmluZGluZ3Mg
d2hjaWggY2FuIHRoZW4gYmUNCj4gPiBlbmFibGVkIGJ5IHNldHRpbmcgdGhlIGNvcnJlc3BvbmRp
bmcgc3RhdHVzZXMgdG8gIm9rIiBpbiBvcmRlciB0bw0KPiA+IGNvbmZpZ3VyZSBhbmQgc3RhcnQg
dGhlIFBDSSBzZXJkZXMuDQo+ID4NCj4gPiBUaGlzIHBhdGNoIGRlcGVuZHMgb24gdGhlIHVwZGF0
ZXMgdG8gdGhlIEtleXN0b25lIFBDSWUgaG9zdCBkcml2ZXINCj4gPiBhbmQgY29tbW9uIHNlcmRl
cyBkcml2ZXIgcGF0Y2ggc2VyaWVzIHRoYXQgaXMgc3VibWl0dGVkIHNlcGFyYXRlbHkuDQo+ID4N
Cj4gPiBTaWduZWQtb2ZmLWJ5OiBXaW5nTWFuIEt3b2sgPHcta3dvazJAdGkuY29tPg0KPiA+IC0t
LQ0KPiA+ICBhcmNoL2FybS9ib290L2R0cy9rMmUuZHRzaSAgICAgIHwgICAyMSArKysrKysrKysr
KysrKysrKysrKysNCj4gPiAgYXJjaC9hcm0vYm9vdC9kdHMva2V5c3RvbmUuZHRzaSB8ICAgMjEg
KysrKysrKysrKysrKysrKysrKysrDQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0aW9u
cygrKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2syZS5kdHNpIGIv
YXJjaC9hcm0vYm9vdC9kdHMvazJlLmR0c2kNCj4gPiBpbmRleCA2NzVmYjhlLi4zYjM2NTc1IDEw
MDY0NA0KPiA+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2syZS5kdHNpDQo+ID4gKysrIGIvYXJj
aC9hcm0vYm9vdC9kdHMvazJlLmR0c2kNCj4gPiBAQCAtODYsNiArODYsMTYgQEANCj4gPiAgCQkJ
Z3BpbyxzeXNjb24tZGV2ID0gPCZkZXZjdHJsIDB4MjQwPjsNCj4gPiAgCQl9Ow0KPiA+DQo+ID4g
KwkJcGNpZTFfcGh5OiBwY2llcGh5QDIzMjYwMDAgew0KPiANCj4gU2hvdWxkIGJlDQo+IAkJcGNp
ZTFfcGh5OiBwaHlAMjMyNjAwMCB7DQo+IA0KDQp3aWxsIGNoYW5nZSBpbiBuZXh0IHZlcnNpb24u
DQoNCj4gPiArCQkJI3BoeS1jZWxscyA9IDwwPjsNCj4gPiArCQkJY29tcGF0aWJsZSA9ICJ0aSxr
ZXlzdG9uZS1zZXJkZXMtcGNpZSI7DQo+ID4gKwkJCXJlZyA9IDwweDAyMzI2MDAwIDB4NDAwMD47
DQo+ID4gKwkJCXJlZy1uYW1lcyA9ICJzZXJkZXMiOw0KPiA+ICsJCQlsaW5rLXJhdGUta2JwcyA9
IDw1MDAwMDAwPjsNCj4gPiArCQkJbnVtLWxhbmVzID0gPDI+Ow0KPiA+ICsJCQlzdGF0dXMgPSAi
ZGlzYWJsZWQiOw0KPiA+ICsJCX07DQo+ID4gKw0KPiA+ICAJCXBjaWUxOiBwY2llQDIxMDIwMDAw
IHsNCj4gPiAgCQkJY29tcGF0aWJsZSA9ICJ0aSxrZXlzdG9uZS1wY2llIiwic25wcyxkdy1wY2ll
IjsNCj4gPiAgCQkJY2xvY2tzID0gPCZjbGtwY2llMT47DQo+ID4gQEAgLTEzMCw2ICsxNDAsMTcg
QEANCj4gPiAgCQkJCQk8R0lDX1NQSSAzNzUgSVJRX1RZUEVfRURHRV9SSVNJTkc+LA0KPiA+ICAJ
CQkJCTxHSUNfU1BJIDM3NiBJUlFfVFlQRV9FREdFX1JJU0lORz47DQo+ID4gIAkJCX07DQo+ID4g
Kw0KPiA+ICsJCQkvKiBQQ0lFIHBoeSAqLw0KPiA+ICsJCQlzZXJkZXNlcyB7DQo+ID4gKwkJCQkj
YWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gPiArCQkJCSNzaXplLWNlbGxzID0gPDA+Ow0KPiA+ICsJ
CQkJc2VyZGVzQDAgew0KPiA+ICsJCQkJCXJlZyA9IDwwPjsNCj4gPiArCQkJCQlwaHlzID0gPCZw
Y2llMV9waHk+Ow0KPiA+ICsJCQkJfTsNCj4gPiArCQkJfTsNCj4gPiArDQo+ID4gIAkJfTsNCj4g
Pg0KPiA+ICAJCW1kaW86IG1kaW9AMjQyMDBmMDAgew0KPiA+IGRpZmYgLS1naXQgYS9hcmNoL2Fy
bS9ib290L2R0cy9rZXlzdG9uZS5kdHNpDQo+IGIvYXJjaC9hcm0vYm9vdC9kdHMva2V5c3RvbmUu
ZHRzaQ0KPiA+IGluZGV4IDcyODE2ZDYuLjY1NjZjYzQgMTAwNjQ0DQo+ID4gLS0tIGEvYXJjaC9h
cm0vYm9vdC9kdHMva2V5c3RvbmUuZHRzaQ0KPiA+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL2tl
eXN0b25lLmR0c2kNCj4gPiBAQCAtMjc1LDYgKzI3NSwxNiBAQA0KPiA+ICAJCQl0aSxzeXNjb24t
ZGV2ID0gPCZkZXZjdHJsIDB4MmEwPjsNCj4gPiAgCQl9Ow0KPiA+DQo+ID4gKwkJcGNpZTBfcGh5
OiBwY2llcGh5QDIzMjAwMDAgew0KPiANCj4gZGl0dG8uDQo+IA0KDQp3aWxsIGNoYW5nZSBpbiBu
ZXh0IHZlcnNpb24uDQoNCj4gPiArCQkJI3BoeS1jZWxscyA9IDwwPjsNCj4gPiArCQkJY29tcGF0
aWJsZSA9ICJ0aSxrZXlzdG9uZS1zZXJkZXMtcGNpZSI7DQo+ID4gKwkJCXJlZyA9IDwweDAyMzIw
MDAwIDB4NDAwMD47DQo+ID4gKwkJCXJlZy1uYW1lcyA9ICJzZXJkZXMiOw0KPiA+ICsJCQlsaW5r
LXJhdGUta2JwcyA9IDw1MDAwMDAwPjsNCj4gPiArCQkJbnVtLWxhbmVzID0gPDI+Ow0KPiA+ICsJ
CQlzdGF0dXMgPSAiZGlzYWJsZWQiOw0KPiA+ICsJCX07DQo+ID4gKw0KPiA+ICAJCXBjaWUwOiBw
Y2llQDIxODAwMDAwIHsNCj4gPiAgCQkJY29tcGF0aWJsZSA9ICJ0aSxrZXlzdG9uZS1wY2llIiwg
InNucHMsZHctcGNpZSI7DQo+ID4gIAkJCWNsb2NrcyA9IDwmY2xrcGNpZT47DQo+ID4gQEAgLTMx
OSw2ICszMjksMTcgQEANCj4gPiAgCQkJCQk8R0lDX1NQSSAyOCBJUlFfVFlQRV9FREdFX1JJU0lO
Rz4sDQo+ID4gIAkJCQkJPEdJQ19TUEkgMjkgSVJRX1RZUEVfRURHRV9SSVNJTkc+Ow0KPiA+ICAJ
CQl9Ow0KPiA+ICsNCj4gPiArCQkJLyogUENJRSBwaHkgKi8NCj4gPiArCQkJc2VyZGVzZXMgew0K
PiA+ICsJCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47DQo+ID4gKwkJCQkjc2l6ZS1jZWxscyA9IDww
PjsNCj4gPiArCQkJCXNlcmRlc0AwIHsNCj4gPiArCQkJCQlyZWcgPSA8MD47DQo+ID4gKwkJCQkJ
cGh5cyA9IDwmcGNpZTBfcGh5PjsNCj4gPiArCQkJCX07DQo+ID4gKwkJCX07DQo+ID4gKw0KPiA+
ICAJCX07DQo+ID4gIAl9Ow0KPiA+ICB9Ow0KPiA+DQo+IA0KPiAtLQ0KPiBjaGVlcnMsDQo+IC1y
b2dlcg0KDQpUaGFua3MsDQpXaW5nTWFuDQo=
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: keystone: dts: add PCI serdes driver bindings
2015-10-15 14:27 WingMan Kwok
2015-10-16 7:55 ` Roger Quadros
@ 2015-11-24 23:43 ` Bjorn Helgaas
1 sibling, 0 replies; 7+ messages in thread
From: Bjorn Helgaas @ 2015-11-24 23:43 UTC (permalink / raw)
To: WingMan Kwok
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, kishon,
rogerq, m-karicheri2, bhelgaas, ssantosh, linux, devicetree,
linux-kernel, linux-pci, linux-arm-kernel
Hi WingMan,
On Thu, Oct 15, 2015 at 10:27:10AM -0400, WingMan Kwok wrote:
> This patch adds the required PCI serdes bindings whcih can then be
> enabled by setting the corresponding statuses to "ok" in order to
> configure and start the PCI serdes.
>
> This patch depends on the updates to the Keystone PCIe host driver
> and common serdes driver patch series that is submitted separately.
>
> Signed-off-by: WingMan Kwok <w-kwok2@ti.com>
Is there a reason to separate the binding update from the PCIe host
driver update? It would make sense to me to have them in the same
patch to make it easier to keep them consistent.
Bjorn
> ---
> arch/arm/boot/dts/k2e.dtsi | 21 +++++++++++++++++++++
> arch/arm/boot/dts/keystone.dtsi | 21 +++++++++++++++++++++
> 2 files changed, 42 insertions(+)
>
> diff --git a/arch/arm/boot/dts/k2e.dtsi b/arch/arm/boot/dts/k2e.dtsi
> index 675fb8e..3b36575 100644
> --- a/arch/arm/boot/dts/k2e.dtsi
> +++ b/arch/arm/boot/dts/k2e.dtsi
> @@ -86,6 +86,16 @@
> gpio,syscon-dev = <&devctrl 0x240>;
> };
>
> + pcie1_phy: pciephy@2326000 {
> + #phy-cells = <0>;
> + compatible = "ti,keystone-serdes-pcie";
> + reg = <0x02326000 0x4000>;
> + reg-names = "serdes";
> + link-rate-kbps = <5000000>;
> + num-lanes = <2>;
> + status = "disabled";
> + };
> +
> pcie1: pcie@21020000 {
> compatible = "ti,keystone-pcie","snps,dw-pcie";
> clocks = <&clkpcie1>;
> @@ -130,6 +140,17 @@
> <GIC_SPI 375 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 376 IRQ_TYPE_EDGE_RISING>;
> };
> +
> + /* PCIE phy */
> + serdeses {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + serdes@0 {
> + reg = <0>;
> + phys = <&pcie1_phy>;
> + };
> + };
> +
> };
>
> mdio: mdio@24200f00 {
> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
> index 72816d6..6566cc4 100644
> --- a/arch/arm/boot/dts/keystone.dtsi
> +++ b/arch/arm/boot/dts/keystone.dtsi
> @@ -275,6 +275,16 @@
> ti,syscon-dev = <&devctrl 0x2a0>;
> };
>
> + pcie0_phy: pciephy@2320000 {
> + #phy-cells = <0>;
> + compatible = "ti,keystone-serdes-pcie";
> + reg = <0x02320000 0x4000>;
> + reg-names = "serdes";
> + link-rate-kbps = <5000000>;
> + num-lanes = <2>;
> + status = "disabled";
> + };
> +
> pcie0: pcie@21800000 {
> compatible = "ti,keystone-pcie", "snps,dw-pcie";
> clocks = <&clkpcie>;
> @@ -319,6 +329,17 @@
> <GIC_SPI 28 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 29 IRQ_TYPE_EDGE_RISING>;
> };
> +
> + /* PCIE phy */
> + serdeses {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + serdes@0 {
> + reg = <0>;
> + phys = <&pcie0_phy>;
> + };
> + };
> +
> };
> };
> };
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-11-24 23:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-21 12:57 [PATCH] ARM: keystone: dts: add PCI serdes driver bindings WingMan Kwok
2015-10-21 15:14 ` Kwok, WingMan
2015-10-21 16:44 ` santosh.shilimkar
-- strict thread matches above, loose matches on Subject: below --
2015-10-15 14:27 WingMan Kwok
2015-10-16 7:55 ` Roger Quadros
2015-10-19 11:10 ` Kwok, WingMan
2015-11-24 23:43 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).