From: Prarit Bhargava <prarit@redhat.com>
To: Mathias Krause <minipli@googlemail.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH] PCI: Prevent out of bounds access in numa_node override - part 2
Date: Sun, 08 Nov 2015 18:28:38 -0500 [thread overview]
Message-ID: <563FDAA6.1010305@redhat.com> (raw)
In-Reply-To: <1447003444-27108-1-git-send-email-minipli@googlemail.com>
On 11/08/2015 12:24 PM, Mathias Krause wrote:
> Commit 1266963170f5 ("PCI: Prevent out of bounds access in numa_node
> override") missed that the user provided node could also be negative.
> Handle this case as well to really avoid out-of-bounds accesses to
> the node_states[] array.
No, this is incorrect. More often than not, numa_node is -1 for NUMA_NO_NODE
which is often interpreted in the kernel as "any numa node".
[root@intel-brickland-04 pci0000:ff]# find ./ -name *numa_node* | xargs egrep ^
| egrep "\-1" | wc -l
92
Can you point to the code that does node_states[pci_dev->numa_node] without
doing a bounds check? IMO that's the code that is broken.
FWIW: I think the idea of your patch is still correct. Checking for -1 to
MAX_NUMNODES is not a bad idea.
P.
next prev parent reply other threads:[~2015-11-08 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 17:24 [PATCH] PCI: Prevent out of bounds access in numa_node override - part 2 Mathias Krause
2015-11-08 23:28 ` Prarit Bhargava [this message]
2015-11-09 6:56 ` Mathias Krause
2015-11-09 11:13 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563FDAA6.1010305@redhat.com \
--to=prarit@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).