linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Linton <jeremy.linton@arm.com>
To: Gabriele Paoloni <gabriele.paoloni@huawei.com>,
	bhelgaas@google.com, arnd@arndb.de, will.deacon@arm.com,
	catalin.marinas@arm.com, hanjun.guo@linaro.org,
	Lorenzo.Pieralisi@arm.com, Liviu.Dudau@arm.com, tn@semihalf.com
Cc: linaro-acpi@lists.linaro.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, xuwei5@hisilicon.com,
	linux-acpi@vger.kernel.org, wangzhou1@hisilicon.com,
	liudongdong3@huawei.com, wangyijing@huawei.com,
	tglx@linutronix.de, liguozhu@hisilicon.com,
	jiang.liu@linux.intel.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/2] PCI/ACPI: Add ACPI support for non ECAM Host Bridge Controllers
Date: Fri, 4 Dec 2015 14:38:53 -0600	[thread overview]
Message-ID: <5661F9DD.7060303@arm.com> (raw)
In-Reply-To: <1449155999-220955-2-git-send-email-gabriele.paoloni@huawei.com>

On 12/03/2015 09:19 AM, Gabriele Paoloni wrote:
> This patch modifies the ARM64 architecure specific PCI framework to
> support Host Bridge specific quirks. these quirks are need for
> host bridge controllers that are not fully ECAM compliant.
> The quirks array allows each vendor to define his own
> acpi_scan_handler where its own pci_ops can be defined
> and the global pointer "vendor_specific_ops" should be
> set to them accordingly.

I have a similar set of changes working for a APM based platform. That 
platform has the same problem, that the default config space access 
methods don't work.

The one comment I have is that I've tried hard to set it up as a generic 
quirk system for which the ACPI/PCI subsystem makes the decision about 
which hardware quirk is being enabled. But its hard because the platform 
in question claims PNP0A08 too, which IMHO is completely wrong if your 
not actually compliant. OTOH, I don't want to base it off the DMI data 
because I don't want it to be tied to a particular implementation.

Lucky, the host bridge VID/PID _CAN_ be read with the default ECAM 
accessor. The only gocha is that the rescan needs to be restarted once 
the ops are replaced.

So my question, is does that work for this device as well?






  parent reply	other threads:[~2015-12-04 20:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 15:19 [RFC PATCH 0/2] PCI/ACPI: HiSi: Add ACPI support for Hip05 PCIe Host Bridge Controller Gabriele Paoloni
2015-12-03 15:19 ` [RFC PATCH 1/2] PCI/ACPI: Add ACPI support for non ECAM Host Bridge Controllers Gabriele Paoloni
2015-12-03 17:58   ` Lorenzo Pieralisi
2015-12-03 20:58     ` Arnd Bergmann
2015-12-04 12:04       ` Lorenzo Pieralisi
2015-12-04 13:57         ` Arnd Bergmann
2015-12-04 16:22           ` Gabriele Paoloni
2015-12-11 14:17             ` Tomasz Nowicki
2015-12-04 20:46       ` Jeremy Linton
2015-12-04 21:34         ` Arnd Bergmann
2015-12-04 22:48           ` Jeremy Linton
2015-12-04 12:47     ` Gabriele Paoloni
2015-12-04 20:38   ` Jeremy Linton [this message]
2015-12-03 15:19 ` [RFC PATCH 2/2] PCI/ACPI: HiSi: Add ACPI support for HiSi PCIe Host Bridge Gabriele Paoloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5661F9DD.7060303@arm.com \
    --to=jeremy.linton@arm.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=gabriele.paoloni@huawei.com \
    --cc=hanjun.guo@linaro.org \
    --cc=jiang.liu@linux.intel.com \
    --cc=liguozhu@hisilicon.com \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=liudongdong3@huawei.com \
    --cc=tglx@linutronix.de \
    --cc=tn@semihalf.com \
    --cc=wangyijing@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=will.deacon@arm.com \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).