From: Xavier Gnata <xavier.gnata@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
Ashwini Pahuja <ashwini.linux@gmail.com>,
Felipe Balbi <balbi@ti.com>
Subject: Re: ID conflict between bdc_pci and "720p FaceTime HD Camera"
Date: Wed, 20 Jan 2016 00:50:33 +0100 [thread overview]
Message-ID: <569ECBC9.9090800@gmail.com> (raw)
In-Reply-To: <20160119225806.GA1841@localhost>
On 19/01/2016 23:58, Bjorn Helgaas wrote:
> [+cc Ashwini, Felipe]
>
> On Sun, Jan 17, 2016 at 04:35:30PM +0100, Xavier Gnata wrote:
>> Hello,
>>
>> The development of a driver for
>> 02:00.0 Multimedia controller [0480]: Broadcom Corporation 720p
>> FaceTime HD Camera [14e4:1570]
>> has started. It is still in an early stage but it's progressing and
>> it already streams.
>> https://github.com/patjak/bcwc_pcie
>>
>> However, as you can see, this webcam shares the exact same ID as
>> bdc_pci 0x1570 .
>>
>> Could we use e.g. PCI_CLASS in bdc_pci to avoid grabbing the webcam
>> incorrectly?
>> The FaceTime HD Camera has PCI_CLASS 0x048000
>> I hope that bdc_pci has another PCI_CLASS.
>> Or maybe there is a better way to distinguish bdc_pci from FaceTime
>> HD Camera. What do you think?
>
> This is what the PCI Vendor/Device IDs are for. It's a shame that
> Broadcom apparently screwed up and used the same IDs in two different
> devices.
>
> At least, I *assume* they're different. I can't really tell what the
> bdc_pci driver does, so it's conceivable that it's using the same
> device in a different way than you are.
>
> If they really are different devices, using the class code sounds like
> a reasonable way to differentiate them.
>
> Bjorn
>
bdc is "Broadcom's USB3.0 device controller IP" in the SOC world which
is connected through PCIe on FPGA-PCIe based platform.
Nothing to do with the Facetime HD webcam of a macbook air.
Broadcom screwed up.
The issue is that I don't have access to such a BDC.
I also don't find it in
http://pcidatabase.com/vendor_details.php?id=767
which lists 0x1570 as being the webcam.
Where can we find the PCI class of this "Broadcom's USB3.0 device
controller IP" ? Ashwini?
Xavier
prev parent reply other threads:[~2016-01-19 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 15:35 ID conflict between bdc_pci and "720p FaceTime HD Camera" Xavier Gnata
2016-01-19 22:58 ` Bjorn Helgaas
2016-01-19 23:50 ` Xavier Gnata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569ECBC9.9090800@gmail.com \
--to=xavier.gnata@gmail.com \
--cc=ashwini.linux@gmail.com \
--cc=balbi@ti.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).