* [PATCH] PCI: layerscape: add ls2085a compatible @ 2016-01-27 17:32 Yang Shi 2016-01-27 18:05 ` Shi, Yang 2016-02-05 20:38 ` Bjorn Helgaas 0 siblings, 2 replies; 13+ messages in thread From: Yang Shi @ 2016-01-27 17:32 UTC (permalink / raw) To: Mingkai.Hu, Minghuan.Lian, bhelgaas Cc: linux-pci, linux-kernel, linux-arm-kernel, linaro-kernel, yang.shi The layerscape PCI host driver needs recognize ls2085a compatible when using firmware with ls2085a compatible property, otherwise the PCI bus won't be detected even though ls2085a compatible is included by the dts. Signed-off-by: Yang Shi <yang.shi@linaro.org> --- drivers/pci/host/pci-layerscape.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 3923bed..c40d8b2 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, { }, }; MODULE_DEVICE_TABLE(of, ls_pcie_of_match); -- 2.0.2 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] PCI: layerscape: add ls2085a compatible 2016-01-27 17:32 [PATCH] PCI: layerscape: add ls2085a compatible Yang Shi @ 2016-01-27 18:05 ` Shi, Yang 2016-02-04 22:37 ` Bjorn Helgaas 2016-02-05 20:38 ` Bjorn Helgaas 1 sibling, 1 reply; 13+ messages in thread From: Shi, Yang @ 2016-01-27 18:05 UTC (permalink / raw) To: Mingkai.Hu, Minghuan Lian, bhelgaas Cc: linux-pci, linux-kernel, linux-arm-kernel, linaro-kernel Correct FSL folks email address to nxp.com, sorry for the inconvenience. Regards, Yang On 1/27/2016 9:32 AM, Yang Shi wrote: > The layerscape PCI host driver needs recognize ls2085a compatible when using > firmware with ls2085a compatible property, otherwise the PCI bus won't be > detected even though ls2085a compatible is included by the dts. > > Signed-off-by: Yang Shi <yang.shi@linaro.org> > --- > drivers/pci/host/pci-layerscape.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c > index 3923bed..c40d8b2 100644 > --- a/drivers/pci/host/pci-layerscape.c > +++ b/drivers/pci/host/pci-layerscape.c > @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, > + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, > { }, > }; > MODULE_DEVICE_TABLE(of, ls_pcie_of_match); > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] PCI: layerscape: add ls2085a compatible 2016-01-27 18:05 ` Shi, Yang @ 2016-02-04 22:37 ` Bjorn Helgaas 2016-02-04 23:49 ` Shi, Yang 0 siblings, 1 reply; 13+ messages in thread From: Bjorn Helgaas @ 2016-02-04 22:37 UTC (permalink / raw) To: Shi, Yang Cc: Mingkai.Hu, Minghuan Lian, bhelgaas, linux-pci, linux-kernel, linux-arm-kernel, linaro-kernel On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote: > Correct FSL folks email address to nxp.com, sorry for the inconvenience. Do we need some MAINTAINERS updates in addition to the ack for this patch? I see a bunch of @freescale.com addresses in MAINTAINERS. > On 1/27/2016 9:32 AM, Yang Shi wrote: > >The layerscape PCI host driver needs recognize ls2085a compatible when using > >firmware with ls2085a compatible property, otherwise the PCI bus won't be > >detected even though ls2085a compatible is included by the dts. > > > >Signed-off-by: Yang Shi <yang.shi@linaro.org> > >--- > > drivers/pci/host/pci-layerscape.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c > >index 3923bed..c40d8b2 100644 > >--- a/drivers/pci/host/pci-layerscape.c > >+++ b/drivers/pci/host/pci-layerscape.c > >@@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { > > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, > > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, > > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, > >+ { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, > > { }, > > }; > > MODULE_DEVICE_TABLE(of, ls_pcie_of_match); > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] PCI: layerscape: add ls2085a compatible 2016-02-04 22:37 ` Bjorn Helgaas @ 2016-02-04 23:49 ` Shi, Yang 2016-02-05 5:36 ` Bhupesh Sharma 0 siblings, 1 reply; 13+ messages in thread From: Shi, Yang @ 2016-02-04 23:49 UTC (permalink / raw) To: Bjorn Helgaas Cc: Mingkai.Hu, Minghuan Lian, bhelgaas, linux-pci, linux-kernel, linux-arm-kernel, linaro-kernel On 2/4/2016 2:37 PM, Bjorn Helgaas wrote: > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote: >> Correct FSL folks email address to nxp.com, sorry for the inconvenience. > > Do we need some MAINTAINERS updates in addition to the ack for this patch? > I see a bunch of @freescale.com addresses in MAINTAINERS. I guess so if the @freescale.com address is not valid anymore. Thanks, Yang > >> On 1/27/2016 9:32 AM, Yang Shi wrote: >>> The layerscape PCI host driver needs recognize ls2085a compatible when using >>> firmware with ls2085a compatible property, otherwise the PCI bus won't be >>> detected even though ls2085a compatible is included by the dts. >>> >>> Signed-off-by: Yang Shi <yang.shi@linaro.org> >>> --- >>> drivers/pci/host/pci-layerscape.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c >>> index 3923bed..c40d8b2 100644 >>> --- a/drivers/pci/host/pci-layerscape.c >>> +++ b/drivers/pci/host/pci-layerscape.c >>> @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { >>> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, >>> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, >>> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, >>> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, >>> { }, >>> }; >>> MODULE_DEVICE_TABLE(of, ls_pcie_of_match); >>> >> ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] PCI: layerscape: add ls2085a compatible 2016-02-04 23:49 ` Shi, Yang @ 2016-02-05 5:36 ` Bhupesh Sharma 2016-02-05 6:07 ` Minghuan Lian 2016-02-14 2:10 ` Shawn Guo 0 siblings, 2 replies; 13+ messages in thread From: Bhupesh Sharma @ 2016-02-05 5:36 UTC (permalink / raw) To: Shi, Yang, Bjorn Helgaas, Yang-Leo Li, shawn.guo@linaro.org Cc: Mingkai Hu, Minghuan Lian, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org > From: Shi, Yang > Sent: Friday, February 05, 2016 5:19 AM > > On 2/4/2016 2:37 PM, Bjorn Helgaas wrote: > > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote: > >> Correct FSL folks email address to nxp.com, sorry for the > inconvenience. > > > > Do we need some MAINTAINERS updates in addition to the ack for this > patch? > > I see a bunch of @freescale.com addresses in MAINTAINERS. > > I guess so if the @freescale.com address is not valid anymore. All @freescale.com address have shifted to @nxp.com. Leo, Minghuan - can you kindly review this patch. Shawn - can you take this through your tree, once Leo and Minghuan have reviewed the code. Regards, Bhupesh > > > > >> On 1/27/2016 9:32 AM, Yang Shi wrote: > >>> The layerscape PCI host driver needs recognize ls2085a compatible > >>> when using firmware with ls2085a compatible property, otherwise the > >>> PCI bus won't be detected even though ls2085a compatible is included > by the dts. > >>> > >>> Signed-off-by: Yang Shi <yang.shi@linaro.org> > >>> --- > >>> drivers/pci/host/pci-layerscape.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/pci/host/pci-layerscape.c > >>> b/drivers/pci/host/pci-layerscape.c > >>> index 3923bed..c40d8b2 100644 > >>> --- a/drivers/pci/host/pci-layerscape.c > >>> +++ b/drivers/pci/host/pci-layerscape.c > >>> @@ -203,6 +203,7 @@ static const struct of_device_id > ls_pcie_of_match[] = { > >>> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata > }, > >>> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata > }, > >>> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata > }, > >>> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, > >>> { }, > >>> }; > >>> MODULE_DEVICE_TABLE(of, ls_pcie_of_match); > >>> > >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] PCI: layerscape: add ls2085a compatible 2016-02-05 5:36 ` Bhupesh Sharma @ 2016-02-05 6:07 ` Minghuan Lian 2016-02-05 15:54 ` Bjorn Helgaas 2016-02-14 2:10 ` Shawn Guo 1 sibling, 1 reply; 13+ messages in thread From: Minghuan Lian @ 2016-02-05 6:07 UTC (permalink / raw) To: Bhupesh Sharma, Shi, Yang, Bjorn Helgaas, Yang-Leo Li, shawn.guo@linaro.org Cc: Mingkai Hu, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org VGhlIHBhdGNoIGlzIG9rIHRvIG1lLg0KDQpUaGFua3MsDQpNaW5naHVhbg0KDQo+IC0tLS0tT3Jp Z2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEJodXBlc2ggU2hhcm1hDQo+IFNlbnQ6IEZyaWRh eSwgRmVicnVhcnkgMDUsIDIwMTYgMTozNiBQTQ0KPiBUbzogU2hpLCBZYW5nIDx5YW5nLnNoaUBs aW5hcm8ub3JnPjsgQmpvcm4gSGVsZ2FhcyA8aGVsZ2Fhc0BrZXJuZWwub3JnPjsNCj4gWWFuZy1M ZW8gTGkgPGxlb3lhbmcubGlAbnhwLmNvbT47IHNoYXduLmd1b0BsaW5hcm8ub3JnDQo+IENjOiBN aW5na2FpIEh1IDxtaW5na2FpLmh1QG54cC5jb20+OyBNaW5naHVhbiBMaWFuDQo+IDxtaW5naHVh bi5saWFuQG54cC5jb20+OyBiaGVsZ2Fhc0Bnb29nbGUuY29tOyBsaW51eC1wY2lAdmdlci5rZXJu ZWwub3JnOw0KPiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmc7DQo+IGxpbmFyby1rZXJuZWxAbGlzdHMubGluYXJvLm9yZw0K PiBTdWJqZWN0OiBSRTogW1BBVENIXSBQQ0k6IGxheWVyc2NhcGU6IGFkZCBsczIwODVhIGNvbXBh dGlibGUNCj4gDQo+ID4gRnJvbTogU2hpLCBZYW5nDQo+ID4gU2VudDogRnJpZGF5LCBGZWJydWFy eSAwNSwgMjAxNiA1OjE5IEFNDQo+ID4NCj4gPiBPbiAyLzQvMjAxNiAyOjM3IFBNLCBCam9ybiBI ZWxnYWFzIHdyb3RlOg0KPiA+ID4gT24gV2VkLCBKYW4gMjcsIDIwMTYgYXQgMTA6MDU6NDBBTSAt MDgwMCwgU2hpLCBZYW5nIHdyb3RlOg0KPiA+ID4+IENvcnJlY3QgRlNMIGZvbGtzIGVtYWlsIGFk ZHJlc3MgdG8gbnhwLmNvbSwgc29ycnkgZm9yIHRoZQ0KPiA+IGluY29udmVuaWVuY2UuDQo+ID4g Pg0KPiA+ID4gRG8gd2UgbmVlZCBzb21lIE1BSU5UQUlORVJTIHVwZGF0ZXMgaW4gYWRkaXRpb24g dG8gdGhlIGFjayBmb3IgdGhpcw0KPiA+IHBhdGNoPw0KPiA+ID4gSSBzZWUgYSBidW5jaCBvZiBA ZnJlZXNjYWxlLmNvbSBhZGRyZXNzZXMgaW4gTUFJTlRBSU5FUlMuDQo+ID4NCj4gPiBJIGd1ZXNz IHNvIGlmIHRoZSBAZnJlZXNjYWxlLmNvbSBhZGRyZXNzIGlzIG5vdCB2YWxpZCBhbnltb3JlLg0K PiANCj4gQWxsIEBmcmVlc2NhbGUuY29tIGFkZHJlc3MgaGF2ZSBzaGlmdGVkIHRvIEBueHAuY29t Lg0KPiANCj4gTGVvLCBNaW5naHVhbiAtIGNhbiB5b3Uga2luZGx5IHJldmlldyB0aGlzIHBhdGNo Lg0KPiANCj4gU2hhd24gLSBjYW4geW91IHRha2UgdGhpcyB0aHJvdWdoIHlvdXIgdHJlZSwgb25j ZSBMZW8gYW5kIE1pbmdodWFuIGhhdmUNCj4gcmV2aWV3ZWQgdGhlIGNvZGUuDQo+IA0KPiBSZWdh cmRzLA0KPiBCaHVwZXNoDQo+IA0KPiA+DQo+ID4gPg0KPiA+ID4+IE9uIDEvMjcvMjAxNiA5OjMy IEFNLCBZYW5nIFNoaSB3cm90ZToNCj4gPiA+Pj4gVGhlIGxheWVyc2NhcGUgUENJIGhvc3QgZHJp dmVyIG5lZWRzIHJlY29nbml6ZSBsczIwODVhIGNvbXBhdGlibGUNCj4gPiA+Pj4gd2hlbiB1c2lu ZyBmaXJtd2FyZSB3aXRoIGxzMjA4NWEgY29tcGF0aWJsZSBwcm9wZXJ0eSwgb3RoZXJ3aXNlDQo+ ID4gPj4+IHRoZSBQQ0kgYnVzIHdvbid0IGJlIGRldGVjdGVkIGV2ZW4gdGhvdWdoIGxzMjA4NWEg Y29tcGF0aWJsZSBpcw0KPiA+ID4+PiBpbmNsdWRlZA0KPiA+IGJ5IHRoZSBkdHMuDQo+ID4gPj4+ DQo+ID4gPj4+IFNpZ25lZC1vZmYtYnk6IFlhbmcgU2hpIDx5YW5nLnNoaUBsaW5hcm8ub3JnPg0K PiA+ID4+PiAtLS0NCj4gPiA+Pj4gICBkcml2ZXJzL3BjaS9ob3N0L3BjaS1sYXllcnNjYXBlLmMg fCAxICsNCj4gPiA+Pj4gICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCj4gPiA+Pj4N Cj4gPiA+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2hvc3QvcGNpLWxheWVyc2NhcGUuYw0K PiA+ID4+PiBiL2RyaXZlcnMvcGNpL2hvc3QvcGNpLWxheWVyc2NhcGUuYw0KPiA+ID4+PiBpbmRl eCAzOTIzYmVkLi5jNDBkOGIyIDEwMDY0NA0KPiA+ID4+PiAtLS0gYS9kcml2ZXJzL3BjaS9ob3N0 L3BjaS1sYXllcnNjYXBlLmMNCj4gPiA+Pj4gKysrIGIvZHJpdmVycy9wY2kvaG9zdC9wY2ktbGF5 ZXJzY2FwZS5jDQo+ID4gPj4+IEBAIC0yMDMsNiArMjAzLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVj dCBvZl9kZXZpY2VfaWQNCj4gPiBsc19wY2llX29mX21hdGNoW10gPSB7DQo+ID4gPj4+ICAgCXsg LmNvbXBhdGlibGUgPSAiZnNsLGxzMTAyMWEtcGNpZSIsIC5kYXRhID0gJmxzMTAyMV9kcnZkYXRh DQo+ID4gfSwNCj4gPiA+Pj4gICAJeyAuY29tcGF0aWJsZSA9ICJmc2wsbHMxMDQzYS1wY2llIiwg LmRhdGEgPSAmbHMxMDQzX2RydmRhdGENCj4gPiB9LA0KPiA+ID4+PiAgIAl7IC5jb21wYXRpYmxl ID0gImZzbCxsczIwODBhLXBjaWUiLCAuZGF0YSA9ICZsczIwODBfZHJ2ZGF0YQ0KPiA+IH0sDQo+ ID4gPj4+ICsJeyAuY29tcGF0aWJsZSA9ICJmc2wsbHMyMDg1YS1wY2llIiwgLmRhdGEgPSAmbHMy MDgwX2RydmRhdGEgfSwNCj4gPiA+Pj4gICAJeyB9LA0KPiA+ID4+PiAgIH07DQo+ID4gPj4+ICAg TU9EVUxFX0RFVklDRV9UQUJMRShvZiwgbHNfcGNpZV9vZl9tYXRjaCk7DQo+ID4gPj4+DQo+ID4g Pj4NCj4gPg0KPiA+IC0tDQo+ID4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQg dGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXBjaSINCj4gPiBpbiB0aGUgYm9keSBvZiBhIG1l c3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZyBNb3JlIG1ham9yZG9tbw0KPiA+IGlu Zm8gYXQgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sDQo= ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] PCI: layerscape: add ls2085a compatible 2016-02-05 6:07 ` Minghuan Lian @ 2016-02-05 15:54 ` Bjorn Helgaas 2016-02-05 19:36 ` Yang-Leo Li 0 siblings, 1 reply; 13+ messages in thread From: Bjorn Helgaas @ 2016-02-05 15:54 UTC (permalink / raw) To: Minghuan Lian Cc: Bhupesh Sharma, Shi, Yang, Yang-Leo Li, shawn.guo@linaro.org, Mingkai Hu, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org On Fri, Feb 05, 2016 at 06:07:10AM +0000, Minghuan Lian wrote: > The patch is ok to me. Thanks, I'll transform that into an ack. Who's going to post a patch to update MAINTAINERS to fix the @freescale.com addresses? If we can get that in for v4.5, it will save some hassle. > > -----Original Message----- > > From: Bhupesh Sharma > > Sent: Friday, February 05, 2016 1:36 PM > > To: Shi, Yang <yang.shi@linaro.org>; Bjorn Helgaas <helgaas@kernel.org>; > > Yang-Leo Li <leoyang.li@nxp.com>; shawn.guo@linaro.org > > Cc: Mingkai Hu <mingkai.hu@nxp.com>; Minghuan Lian > > <minghuan.lian@nxp.com>; bhelgaas@google.com; linux-pci@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linaro-kernel@lists.linaro.org > > Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible > > > > > From: Shi, Yang > > > Sent: Friday, February 05, 2016 5:19 AM > > > > > > On 2/4/2016 2:37 PM, Bjorn Helgaas wrote: > > > > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote: > > > >> Correct FSL folks email address to nxp.com, sorry for the > > > inconvenience. > > > > > > > > Do we need some MAINTAINERS updates in addition to the ack for this > > > patch? > > > > I see a bunch of @freescale.com addresses in MAINTAINERS. > > > > > > I guess so if the @freescale.com address is not valid anymore. > > > > All @freescale.com address have shifted to @nxp.com. > > > > Leo, Minghuan - can you kindly review this patch. > > > > Shawn - can you take this through your tree, once Leo and Minghuan have > > reviewed the code. > > > > Regards, > > Bhupesh > > > > > > > > > > > > >> On 1/27/2016 9:32 AM, Yang Shi wrote: > > > >>> The layerscape PCI host driver needs recognize ls2085a compatible > > > >>> when using firmware with ls2085a compatible property, otherwise > > > >>> the PCI bus won't be detected even though ls2085a compatible is > > > >>> included > > > by the dts. > > > >>> > > > >>> Signed-off-by: Yang Shi <yang.shi@linaro.org> > > > >>> --- > > > >>> drivers/pci/host/pci-layerscape.c | 1 + > > > >>> 1 file changed, 1 insertion(+) > > > >>> > > > >>> diff --git a/drivers/pci/host/pci-layerscape.c > > > >>> b/drivers/pci/host/pci-layerscape.c > > > >>> index 3923bed..c40d8b2 100644 > > > >>> --- a/drivers/pci/host/pci-layerscape.c > > > >>> +++ b/drivers/pci/host/pci-layerscape.c > > > >>> @@ -203,6 +203,7 @@ static const struct of_device_id > > > ls_pcie_of_match[] = { > > > >>> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata > > > }, > > > >>> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata > > > }, > > > >>> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata > > > }, > > > >>> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, > > > >>> { }, > > > >>> }; > > > >>> MODULE_DEVICE_TABLE(of, ls_pcie_of_match); > > > >>> > > > >> > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-pci" > > > in the body of a message to majordomo@vger.kernel.org More majordomo > > > info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] PCI: layerscape: add ls2085a compatible 2016-02-05 15:54 ` Bjorn Helgaas @ 2016-02-05 19:36 ` Yang-Leo Li 0 siblings, 0 replies; 13+ messages in thread From: Yang-Leo Li @ 2016-02-05 19:36 UTC (permalink / raw) To: Bjorn Helgaas, Minghuan Lian Cc: Bhupesh Sharma, Shi, Yang, shawn.guo@linaro.org, Mingkai Hu, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org > On Fri, Feb 05, 2016 at 06:07:10AM +0000, Minghuan Lian wrote: > > The patch is ok to me. > > Thanks, I'll transform that into an ack. Also Acked-by: Li Yang <leoyang.li@nxp.com> > > Who's going to post a patch to update MAINTAINERS to fix the @freescale.com > addresses? If we can get that in for v4.5, it will save some hassle. The @freescale.com address can still reach us for some time(not sure how long though). I don't know if all the people want to change to an NXP company email address in MAINTAINERS or just update to a personal email address as some already did. Regards, Leo > > > > -----Original Message----- > > > From: Bhupesh Sharma > > > Sent: Friday, February 05, 2016 1:36 PM > > > To: Shi, Yang <yang.shi@linaro.org>; Bjorn Helgaas > > > <helgaas@kernel.org>; Yang-Leo Li <leoyang.li@nxp.com>; > > > shawn.guo@linaro.org > > > Cc: Mingkai Hu <mingkai.hu@nxp.com>; Minghuan Lian > > > <minghuan.lian@nxp.com>; bhelgaas@google.com; > > > linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; > > > linux-arm-kernel@lists.infradead.org; > > > linaro-kernel@lists.linaro.org > > > Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible > > > > > > > From: Shi, Yang > > > > Sent: Friday, February 05, 2016 5:19 AM > > > > > > > > On 2/4/2016 2:37 PM, Bjorn Helgaas wrote: > > > > > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote: > > > > >> Correct FSL folks email address to nxp.com, sorry for the > > > > inconvenience. > > > > > > > > > > Do we need some MAINTAINERS updates in addition to the ack for > > > > > this > > > > patch? > > > > > I see a bunch of @freescale.com addresses in MAINTAINERS. > > > > > > > > I guess so if the @freescale.com address is not valid anymore. > > > > > > All @freescale.com address have shifted to @nxp.com. > > > > > > Leo, Minghuan - can you kindly review this patch. > > > > > > Shawn - can you take this through your tree, once Leo and Minghuan > > > have reviewed the code. > > > > > > Regards, > > > Bhupesh > > > > > > > > > > > > > > > > >> On 1/27/2016 9:32 AM, Yang Shi wrote: > > > > >>> The layerscape PCI host driver needs recognize ls2085a > > > > >>> compatible when using firmware with ls2085a compatible > > > > >>> property, otherwise the PCI bus won't be detected even though > > > > >>> ls2085a compatible is included > > > > by the dts. > > > > >>> > > > > >>> Signed-off-by: Yang Shi <yang.shi@linaro.org> > > > > >>> --- > > > > >>> drivers/pci/host/pci-layerscape.c | 1 + > > > > >>> 1 file changed, 1 insertion(+) > > > > >>> > > > > >>> diff --git a/drivers/pci/host/pci-layerscape.c > > > > >>> b/drivers/pci/host/pci-layerscape.c > > > > >>> index 3923bed..c40d8b2 100644 > > > > >>> --- a/drivers/pci/host/pci-layerscape.c > > > > >>> +++ b/drivers/pci/host/pci-layerscape.c > > > > >>> @@ -203,6 +203,7 @@ static const struct of_device_id > > > > ls_pcie_of_match[] = { > > > > >>> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata > > > > }, > > > > >>> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata > > > > }, > > > > >>> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata > > > > }, > > > > >>> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata > > > > >>> +}, > > > > >>> { }, > > > > >>> }; > > > > >>> MODULE_DEVICE_TABLE(of, ls_pcie_of_match); > > > > >>> > > > > >> > > > > > > > > -- > > > > To unsubscribe from this list: send the line "unsubscribe linux-pci" > > > > in the body of a message to majordomo@vger.kernel.org More > > > > majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] PCI: layerscape: add ls2085a compatible 2016-02-05 5:36 ` Bhupesh Sharma 2016-02-05 6:07 ` Minghuan Lian @ 2016-02-14 2:10 ` Shawn Guo 1 sibling, 0 replies; 13+ messages in thread From: Shawn Guo @ 2016-02-14 2:10 UTC (permalink / raw) To: Bhupesh Sharma Cc: Shi, Yang, Bjorn Helgaas, Yang-Leo Li, shawn.guo@linaro.org, linaro-kernel@lists.linaro.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Minghuan Lian, Mingkai Hu, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org On Fri, Feb 05, 2016 at 05:36:28AM +0000, Bhupesh Sharma wrote: > > From: Shi, Yang > > Sent: Friday, February 05, 2016 5:19 AM > > > > On 2/4/2016 2:37 PM, Bjorn Helgaas wrote: > > > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote: > > >> Correct FSL folks email address to nxp.com, sorry for the > > inconvenience. > > > > > > Do we need some MAINTAINERS updates in addition to the ack for this > > patch? > > > I see a bunch of @freescale.com addresses in MAINTAINERS. > > > > I guess so if the @freescale.com address is not valid anymore. > > All @freescale.com address have shifted to @nxp.com. > > Leo, Minghuan - can you kindly review this patch. > > Shawn - can you take this through your tree, once Leo and Minghuan have reviewed the code. This is a patch that should go through PCI subsystem tree. Shawn > > >> On 1/27/2016 9:32 AM, Yang Shi wrote: > > >>> The layerscape PCI host driver needs recognize ls2085a compatible > > >>> when using firmware with ls2085a compatible property, otherwise the > > >>> PCI bus won't be detected even though ls2085a compatible is included > > by the dts. > > >>> > > >>> Signed-off-by: Yang Shi <yang.shi@linaro.org> > > >>> --- > > >>> drivers/pci/host/pci-layerscape.c | 1 + > > >>> 1 file changed, 1 insertion(+) > > >>> > > >>> diff --git a/drivers/pci/host/pci-layerscape.c > > >>> b/drivers/pci/host/pci-layerscape.c > > >>> index 3923bed..c40d8b2 100644 > > >>> --- a/drivers/pci/host/pci-layerscape.c > > >>> +++ b/drivers/pci/host/pci-layerscape.c > > >>> @@ -203,6 +203,7 @@ static const struct of_device_id > > ls_pcie_of_match[] = { > > >>> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata > > }, > > >>> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata > > }, > > >>> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata > > }, > > >>> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, > > >>> { }, > > >>> }; > > >>> MODULE_DEVICE_TABLE(of, ls_pcie_of_match); > > >>> > > >> > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > > the body of a message to majordomo@vger.kernel.org More majordomo info at > > http://vger.kernel.org/majordomo-info.html > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] PCI: layerscape: add ls2085a compatible 2016-01-27 17:32 [PATCH] PCI: layerscape: add ls2085a compatible Yang Shi 2016-01-27 18:05 ` Shi, Yang @ 2016-02-05 20:38 ` Bjorn Helgaas 2016-02-05 20:45 ` Shi, Yang 1 sibling, 1 reply; 13+ messages in thread From: Bjorn Helgaas @ 2016-02-05 20:38 UTC (permalink / raw) To: Yang Shi Cc: Mingkai.Hu, Minghuan.Lian, bhelgaas, linux-pci, linux-kernel, linux-arm-kernel, linaro-kernel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree [+cc Rob, et al] On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote: > The layerscape PCI host driver needs recognize ls2085a compatible when using > firmware with ls2085a compatible property, otherwise the PCI bus won't be > detected even though ls2085a compatible is included by the dts. > > Signed-off-by: Yang Shi <yang.shi@linaro.org> > --- > drivers/pci/host/pci-layerscape.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c > index 3923bed..c40d8b2 100644 > --- a/drivers/pci/host/pci-layerscape.c > +++ b/drivers/pci/host/pci-layerscape.c > @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, > + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, Hmm, "fsl,ls2085a-pcie" doesn't appear in Documentation/devicetree/bindings/pci/. Aren't we supposed to add these strings to the bindings before or at the same time we add them to drivers? checkpatch doesn't complain though, so maybe I'm wrong about this. > { }, > }; > MODULE_DEVICE_TABLE(of, ls_pcie_of_match); > -- > 2.0.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] PCI: layerscape: add ls2085a compatible 2016-02-05 20:38 ` Bjorn Helgaas @ 2016-02-05 20:45 ` Shi, Yang 2016-02-05 22:25 ` Bjorn Helgaas 0 siblings, 1 reply; 13+ messages in thread From: Shi, Yang @ 2016-02-05 20:45 UTC (permalink / raw) To: Bjorn Helgaas Cc: Mingkai.Hu, Minghuan.Lian, bhelgaas, linux-pci, linux-kernel, linux-arm-kernel, linaro-kernel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree On 2/5/2016 12:38 PM, Bjorn Helgaas wrote: > [+cc Rob, et al] > > On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote: >> The layerscape PCI host driver needs recognize ls2085a compatible when using >> firmware with ls2085a compatible property, otherwise the PCI bus won't be >> detected even though ls2085a compatible is included by the dts. >> >> Signed-off-by: Yang Shi <yang.shi@linaro.org> >> --- >> drivers/pci/host/pci-layerscape.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c >> index 3923bed..c40d8b2 100644 >> --- a/drivers/pci/host/pci-layerscape.c >> +++ b/drivers/pci/host/pci-layerscape.c >> @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { >> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, >> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, >> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, >> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, > > Hmm, "fsl,ls2085a-pcie" doesn't appear in > Documentation/devicetree/bindings/pci/. > > Aren't we supposed to add these strings to the bindings before or at > the same time we add them to drivers? The below patch will add it into dts and binding doc. I should mentioned this in the commit log. https://patchwork.kernel.org/patch/7767061/ Thanks, Yang > > checkpatch doesn't complain though, so maybe I'm wrong about this. > >> { }, >> }; >> MODULE_DEVICE_TABLE(of, ls_pcie_of_match); >> -- >> 2.0.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pci" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] PCI: layerscape: add ls2085a compatible 2016-02-05 20:45 ` Shi, Yang @ 2016-02-05 22:25 ` Bjorn Helgaas 2016-02-17 2:17 ` Mingkai Hu 0 siblings, 1 reply; 13+ messages in thread From: Bjorn Helgaas @ 2016-02-05 22:25 UTC (permalink / raw) To: Shi, Yang Cc: Mingkai.Hu, Minghuan.Lian, bhelgaas, linux-pci, linux-kernel, linux-arm-kernel, linaro-kernel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree On Fri, Feb 05, 2016 at 12:45:25PM -0800, Shi, Yang wrote: > On 2/5/2016 12:38 PM, Bjorn Helgaas wrote: > >[+cc Rob, et al] > > > >On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote: > >>The layerscape PCI host driver needs recognize ls2085a compatible when using > >>firmware with ls2085a compatible property, otherwise the PCI bus won't be > >>detected even though ls2085a compatible is included by the dts. > >> > >>Signed-off-by: Yang Shi <yang.shi@linaro.org> > >>--- > >> drivers/pci/host/pci-layerscape.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >>diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c > >>index 3923bed..c40d8b2 100644 > >>--- a/drivers/pci/host/pci-layerscape.c > >>+++ b/drivers/pci/host/pci-layerscape.c > >>@@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = { > >> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, > >> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, > >> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, > >>+ { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, > > > >Hmm, "fsl,ls2085a-pcie" doesn't appear in > >Documentation/devicetree/bindings/pci/. > > > >Aren't we supposed to add these strings to the bindings before or at > >the same time we add them to drivers? > > The below patch will add it into dts and binding doc. I should > mentioned this in the commit log. > > https://patchwork.kernel.org/patch/7767061/ OK. This is really annoying as a reviewer. To me, adding "fsl,ls2085a-pcie" to: - the binding in Documentation/devicetree/bindings/pci/layerscape-pci.txt - the DT in arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi - the driver in drivers/pci/host/pci-layerscape.c are all logically related, and it would make sense to have them all in a single patch. But whatever. I applied this to pci/host-layerscape for v4.6. > >checkpatch doesn't complain though, so maybe I'm wrong about this. > > > >> { }, > >> }; > >> MODULE_DEVICE_TABLE(of, ls_pcie_of_match); > >>-- > >>2.0.2 > >> > >>-- > >>To unsubscribe from this list: send the line "unsubscribe linux-pci" in > >>the body of a message to majordomo@vger.kernel.org > >>More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] PCI: layerscape: add ls2085a compatible 2016-02-05 22:25 ` Bjorn Helgaas @ 2016-02-17 2:17 ` Mingkai Hu 0 siblings, 0 replies; 13+ messages in thread From: Mingkai Hu @ 2016-02-17 2:17 UTC (permalink / raw) To: Bjorn Helgaas, Shi, Yang Cc: Mingkai.Hu@freescale.com, Minghuan.Lian@freescale.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree@vger.kernel.org > -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@kernel.org] > Sent: Saturday, February 06, 2016 6:25 AM > To: Shi, Yang > Cc: Mingkai.Hu@freescale.com; Minghuan.Lian@freescale.com; > bhelgaas@google.com; linux-pci@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linaro- > kernel@lists.linaro.org; Rob Herring; Pawel Moll; Mark Rutland; Ian > Campbell; Kumar Gala; devicetree@vger.kernel.org > Subject: Re: [PATCH] PCI: layerscape: add ls2085a compatible > > On Fri, Feb 05, 2016 at 12:45:25PM -0800, Shi, Yang wrote: > > On 2/5/2016 12:38 PM, Bjorn Helgaas wrote: > > >[+cc Rob, et al] > > > > > >On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote: > > >>The layerscape PCI host driver needs recognize ls2085a compatible > > >>when using firmware with ls2085a compatible property, otherwise the > > >>PCI bus won't be detected even though ls2085a compatible is included > by the dts. > > >> > > >>Signed-off-by: Yang Shi <yang.shi@linaro.org> > > >>--- > > >> drivers/pci/host/pci-layerscape.c | 1 + > > >> 1 file changed, 1 insertion(+) > > >> > > >>diff --git a/drivers/pci/host/pci-layerscape.c > > >>b/drivers/pci/host/pci-layerscape.c > > >>index 3923bed..c40d8b2 100644 > > >>--- a/drivers/pci/host/pci-layerscape.c > > >>+++ b/drivers/pci/host/pci-layerscape.c > > >>@@ -203,6 +203,7 @@ static const struct of_device_id > ls_pcie_of_match[] = { > > >> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, > > >> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, > > >> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, > > >>+ { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata }, > > > > > >Hmm, "fsl,ls2085a-pcie" doesn't appear in > > >Documentation/devicetree/bindings/pci/. > > > > > >Aren't we supposed to add these strings to the bindings before or at > > >the same time we add them to drivers? > > > > The below patch will add it into dts and binding doc. I should > > mentioned this in the commit log. > > > > https://patchwork.kernel.org/patch/7767061/ > > OK. This is really annoying as a reviewer. To me, adding "fsl,ls2085a- > pcie" to: > > - the binding in Documentation/devicetree/bindings/pci/layerscape- > pci.txt > - the DT in arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi > - the driver in drivers/pci/host/pci-layerscape.c > > are all logically related, and it would make sense to have them all in a > single patch. > > But whatever. I applied this to pci/host-layerscape for v4.6. > Bojon, I have sent version3 of the patch to add strings to the bindings and dts file. https://patchwork.kernel.org/patch/8333761/ Sorry for the delayed response due to Chinese New Year holiday. Thanks, Mingkai ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-02-17 4:50 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-01-27 17:32 [PATCH] PCI: layerscape: add ls2085a compatible Yang Shi 2016-01-27 18:05 ` Shi, Yang 2016-02-04 22:37 ` Bjorn Helgaas 2016-02-04 23:49 ` Shi, Yang 2016-02-05 5:36 ` Bhupesh Sharma 2016-02-05 6:07 ` Minghuan Lian 2016-02-05 15:54 ` Bjorn Helgaas 2016-02-05 19:36 ` Yang-Leo Li 2016-02-14 2:10 ` Shawn Guo 2016-02-05 20:38 ` Bjorn Helgaas 2016-02-05 20:45 ` Shi, Yang 2016-02-05 22:25 ` Bjorn Helgaas 2016-02-17 2:17 ` Mingkai Hu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).