From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>, <kbuild-all@01.org>,
<Vineet.Gupta1@synopsys.com>, <arnd@arndb.de>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-snps-arc@lists.infradead.org>,
<CARLOS.PALMINHA@synopsys.com>, <Alexey.Brodkin@synopsys.com>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>
Subject: Re: [PATCH v9 2/2] pcie-designware platform driver
Date: Mon, 15 Feb 2016 18:15:55 +0000 [thread overview]
Message-ID: <56C215DB.50603@synopsys.com> (raw)
In-Reply-To: <56BB0777.6080208@synopsys.com>
Hi Bjorn!
Did you have opportunity to check the v9 patch set?
Thanks.
Joao
On 2/10/2016 9:48 AM, Joao Pinto wrote:
> Hi Bjorn,
>
> On 2/8/2016 11:28 PM, Bjorn Helgaas wrote:
>>> if (!pci_has_flag(PCI_PROBE_ONLY)) {
>>> ^
>>> drivers/pci/host/pcie-designware.c:581:20: note: each undeclared identifier is reported only once for each function it appears in
>>> cc1: some warnings being treated as errors
>>
>> I have fixes for this on my pci/misc branch, so you don't need to
>> worry about these errors. Basically I'm moving the PCI_PROBE_ONLY and
>> pci_has_flag() declarations from the arch-specific asm/pci-bridge.h
>> files to the generic linux/pci.h file.
>
> Ok, thanks.
>
>>
>>> vim +/pci_has_flag +581 drivers/pci/host/pcie-designware.c
>>>
>>> cbce7900 Zhou Wang 2015-10-29 575
>>> cbce7900 Zhou Wang 2015-10-29 576 #ifdef CONFIG_ARM
>>> cbce7900 Zhou Wang 2015-10-29 577 /* support old dtbs that incorrectly describe IRQs */
>>> cbce7900 Zhou Wang 2015-10-29 578 pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
>>> 0815f957 Yijing Wang 2014-11-11 579 #endif
>>> 0815f957 Yijing Wang 2014-11-11 580
>>> cbce7900 Zhou Wang 2015-10-29 @581 if (!pci_has_flag(PCI_PROBE_ONLY)) {
>>> cbce7900 Zhou Wang 2015-10-29 582 pci_bus_size_bridges(bus);
>>> cbce7900 Zhou Wang 2015-10-29 583 pci_bus_assign_resources(bus);
>>> 4b1ced84 Jingoo Han 2013-07-31 584
>>>
>>> :::::: The code at line 581 was first introduced by commit
>>> :::::: cbce7900598c26a12652f8ca9c41c5b29034c38d PCI: designware: Make driver arch-agnostic
>>>
>>> :::::: TO: Zhou Wang <wangzhou1@hisilicon.com>
>>> :::::: CC: Bjorn Helgaas <bhelgaas@google.com>
>>>
>>> ---
>>> 0-DAY kernel test infrastructure Open Source Technology Center
>>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>>
>>
>
> If there's anything else that is needed for the pcie-designware platform driver,
> please let me know.
>
> Thanks,
> Joao
>
next prev parent reply other threads:[~2016-02-15 18:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 17:45 [PATCH v9 0/2] adding PCI support to AXS10x Joao Pinto
2016-02-08 17:45 ` [PATCH v9 1/2] PCI support added to ARC Joao Pinto
2016-02-25 16:30 ` [PATCH RESEND " Bjorn Helgaas
2016-02-25 16:52 ` Vineet Gupta
2016-02-17 17:46 ` [PATCH RESEND v9 2/2] pcie-designware platform driver Joao Pinto
2016-02-08 21:29 ` [PATCH " kbuild test robot
2016-02-08 23:28 ` Bjorn Helgaas
2016-02-10 9:48 ` Joao Pinto
2016-02-15 18:15 ` Joao Pinto [this message]
2016-02-25 16:32 ` [PATCH RESEND " Bjorn Helgaas
2016-02-25 17:01 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C215DB.50603@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=galak@codeaurora.org \
--cc=helgaas@kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).