From: Babu Moger <babu.moger@oracle.com>
To: "Seymour, Shane M" <shane.seymour@hpe.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Hannes Reinecke <hare@suse.de>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Jordan Hargrave <Jordan_Hargrave@dell.com>,
Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH v4 00/11] PCI VPD access fixes
Date: Mon, 29 Feb 2016 16:36:41 -0600 [thread overview]
Message-ID: <56D4C7F9.1060609@oracle.com> (raw)
In-Reply-To: <DDB9C85B850785449757F9914A034FCB445368F5@G4W3219.americas.hpqcorp.net>
On 2/23/2016 10:52 PM, Seymour, Shane M wrote:
> Retested v4. For the series tested two PCIe cards that support VPD:
>
> 0d:00.0 Serial Attached SCSI controller: LSI Logic / Symbios Logic SAS2308 PCI-Express Fusion-MPT SAS-2 (rev 05)
> 1e:00.0 Fibre Channel: QLogic Corp. ISP2432-based 4Gb Fibre Channel to PCI Express HBA (rev 03)
>
> The first card exposes 32KiB of NUL bytes as VPD and the second 154 bytes of non-NUL data repeating every 4KiB for 32KiB before the change. After the change the first card returns no data for VPD (since it contains only NUL bytes) and the second the expected 154 bytes of data.
>
> The following warning message comes out as expected for the LSI card (changed from dyn debug controlled message):
>
> [ 614.475984] mpt3sas 0000:0d:00.0: invalid short VPD tag 00 at offset 1
>
> lspci works correctly with the patch in the kernel. The only change on the system (apart from the size of the vpd file) was that with the LSI card lspci with -vvvv as root it now says "Not readable" instead of "Unknown small resource type 00, will not decode more." in the VPD section.
> ---
> Tested-by: Shane Seymour <shane.seymour@hpe.com>
>
I have also retested the V4 series. Did not see any side effects.
Once again here is the bug I opened for this issue.
https://bugzilla.kernel.org/show_bug.cgi?id=110681
---
Tested-by: Babu Moger <babu.moger@oracle.com>
next prev parent reply other threads:[~2016-02-29 22:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 0:46 [PATCH v4 00/11] PCI VPD access fixes Bjorn Helgaas
2016-02-23 0:46 ` [PATCH v4 01/11] PCI: Update VPD definitions Bjorn Helgaas
2016-02-23 0:46 ` [PATCH v4 02/11] PCI: Allow access to VPD attributes with size 0 Bjorn Helgaas
2016-02-23 0:46 ` [PATCH v4 03/11] PCI: Use bitfield instead of bool for struct pci_vpd_pci22.busy Bjorn Helgaas
2016-02-23 12:19 ` Hannes Reinecke
2016-02-23 0:46 ` [PATCH v4 04/11] PCI: Determine actual VPD size on first access Bjorn Helgaas
2016-02-23 0:47 ` [PATCH v4 05/11] FIXME need bugzilla link Bjorn Helgaas
2016-02-23 0:47 ` [PATCH v4 06/11] PCI: Move pci_read_vpd() and pci_write_vpd() close to other VPD code Bjorn Helgaas
2016-02-23 12:20 ` Hannes Reinecke
2016-02-23 0:47 ` [PATCH v4 07/11] PCI: Move pci_vpd_release() from header file to pci/access.c Bjorn Helgaas
2016-02-23 12:21 ` Hannes Reinecke
2016-02-23 0:47 ` [PATCH v4 08/11] PCI: Remove struct pci_vpd_ops.release function pointer Bjorn Helgaas
2016-02-23 12:22 ` Hannes Reinecke
2016-02-23 0:47 ` [PATCH v4 09/11] PCI: Rename VPD symbols to remove unnecessary "pci22" Bjorn Helgaas
2016-02-23 12:23 ` Hannes Reinecke
2016-02-23 0:47 ` [PATCH v4 10/11] PCI: Fold struct pci_vpd_pci22 into struct pci_vpd Bjorn Helgaas
2016-02-23 12:24 ` Hannes Reinecke
2016-02-23 0:47 ` [PATCH v4 11/11] PCI: Sleep rather than busy-wait for VPD access completion Bjorn Helgaas
2016-02-23 12:25 ` Hannes Reinecke
2016-02-23 14:07 ` [PATCH v4 00/11] PCI VPD access fixes Bjorn Helgaas
2016-02-23 21:48 ` Hannes Reinecke
2016-02-23 22:36 ` Bjorn Helgaas
2016-02-24 0:30 ` Hannes Reinecke
2016-02-24 0:45 ` Bjorn Helgaas
2016-02-23 17:11 ` Bjorn Helgaas
2016-02-24 4:52 ` Seymour, Shane M
2016-02-29 22:36 ` Babu Moger [this message]
2016-02-29 17:27 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D4C7F9.1060609@oracle.com \
--to=babu.moger@oracle.com \
--cc=Jordan_Hargrave@dell.com \
--cc=alexander.duyck@gmail.com \
--cc=bhelgaas@google.com \
--cc=hare@suse.de \
--cc=linux-pci@vger.kernel.org \
--cc=shane.seymour@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).