Re: [RFC/RFT] Add noats flag to boot parameters

[Nadav Amit <nadav.amit@gmail.com>]

Sinan Kaya <okaya@codeaurora.org> wrote:

> +Bjorn,
>=20
> On 5/3/2018 9:59 AM, Joerg Roedel wrote:
>> On Thu, May 03, 2018 at 09:46:34AM -0400, Sinan Kaya wrote:
>>> I also like the idea in general.
>>> Minor nit..
>>>=20
>>> Shouldn't this be an iommu parameter rather than a PCI kernel =
command line parameter?
>>> We now have an iommu.passthrough argument that prevents page =
translation.
>>>=20
>>> Doesn't this fit into the same category especially when it is the =
IOMMU drivers that
>>> call ATS functions for enablement not the PCI drivers.
>>=20
>> ATS is a bit of a grey area between PCI and IOMMU, but since ATS is
>> PCI-specific and the code to enable/disable it is in PCI as well, I
>> think the parameter makes sense for PCI too.
>=20
> OK. Bjorn was interested in having a command line driven feature =
enables in driver/pci
> directory with bitmasks for each optional PCI spec capability rather =
than noXYZ feature.
>=20
> This would allow us to troubleshoot code breakage as well as the =
platform bring up to
> turn off all optional features.
>=20
> Sounds like this would be a good match for that work.

I think that since this feature (ATS) has security implications, it =
should
be controllable through the kernel boot parameters. Otherwise, it can be
potentially too late to turn it off.

Regards,
Nadav=